From: brett l. <wak...@gm...> - 2006-02-15 22:51:08
|
Unfortunately, I haven't had a lot of time in the last week to finish working on this. Currently, all of the underlying methods seem to be working, the only problem is fixing the many repaint/drawing bugs that have crept in during this change. I am going to commit this major change today, despite it not being quite as seamless a change as I wanted it to be. If anyone wants to help squash the repainting bugs before I get to them, they're welcome to jump on in. I'm hoping to get some time this weekend to work on finishing off these changes, if this damned head cold I've got allows me to do anything. A quick overview of what's changed: I've removed all constructor arguments from ORWindow, ORPanel, UpgradesPanel, and any other children of ORWindow. I've reduced the visibility of GameUILoader's copy of MapPanel. There's a suitable get method, but no direct access to mapPanel anymore. I've moved a ton of methods upward from sub-Containers into ORWindow.=20 There's still a few methods that I feel are out of place, and have left comments on some of them, but most of the method placements seem to fit better now. The StatusWindow no longer "owns" the ORWindow. The ORWindow obtains any necessary data from the game model objects rather than from the StatusWindow. Where possible, I've left many of the old sections of code commented out just in case I've pruned too much and something is needed. Right now, resizing the ORWindow correctly repaints the window.=20 Hopefully, I just need to add some more calls to repaint in the right spots to get the ORWindow fully working again. ---Brett. |
From: brett l. <wak...@gm...> - 2006-02-18 22:05:26
|
Ok... I've commited some additional changes that return the ORWindow to fully functioning. I'm noticing a bit of flicker in StatusWindow. I'll check and see if we're painting it too often. ---Brett. > > Right now, resizing the ORWindow correctly repaints the window. > Hopefully, I just need to add some more calls to repaint in the right > spots to get the ORWindow fully working again. > |
From: Erik V. <eri...@hc...> - 2006-02-18 23:30:18
|
> Ok... I've commited some additional changes that return the ORWindow > to fully functioning. I'm now getting a ClassCastException at UpgradesPanel.mouseClicked, line 216, when the first tile is laid. > I'm noticing a bit of flicker in StatusWindow. I'll check and see if > we're painting it too often. I see this flickering only in the part of StatusWindow that overlaps with the StockChart window, and it seems to be caused by excessive repainting of the StockChart, even if nothing has changed there. Erik. |
From: brett l. <wak...@gm...> - 2006-02-21 01:40:50
|
On 2/18/06, Erik Vos <eri...@hc...> wrote: > > Ok... I've commited some additional changes that return the ORWindow > > to fully functioning. > > I'm now getting a ClassCastException at UpgradesPanel.mouseClicked, line > 216, > when the first tile is laid. > OK... Fixed that. > > I'm noticing a bit of flicker in StatusWindow. I'll check and see if > > we're painting it too often. > > I see this flickering only in the part of StatusWindow that overlaps with > the StockChart window, and it seems to be caused by excessive repainting > of the StockChart, even if nothing has changed there. > I've committed some initial changes to StockChart that lay the groundwork for fixing this. Essentially the problem is that, with every repaint, we're removing all elements of the StockChart, and repopulating the whole thing. So, I'm having to rework a bit of the structure of StockChart to allow us to update a single element of the chart without having to repopulate the whole thing. ----Brett. |
From: brett l. <wak...@gm...> - 2006-02-22 03:05:12
|
I'm seeing a bug in StatusWindow where after buying out 100% of the company, the selector button remains at 10%. ----Brett. On 2/20/06, brett lentz <wak...@gm...> wrote: > On 2/18/06, Erik Vos <eri...@hc...> wrote: > > > Ok... I've commited some additional changes that return the ORWindow > > > to fully functioning. > > > > I'm now getting a ClassCastException at UpgradesPanel.mouseClicked, lin= e > > 216, > > when the first tile is laid. > > > > OK... Fixed that. > > |
From: brett l. <wak...@gm...> - 2006-02-23 20:12:58
|
I've fixed the bug. It looks like it was due to me being a little over-zealous and commenting some necessary methods. ---Brett. On 2/21/06, brett lentz <wak...@gm...> wrote: > I'm seeing a bug in StatusWindow where after buying out 100% of the > company, the selector button remains at 10%. > > > ----Brett. > > > |
From: Erik V. <eri...@hc...> - 2006-02-23 21:06:45
|
> I've fixed the bug. It looks like it was due to me being a little > over-zealous and commenting some necessary methods. I've also found a fix, but a different one (you have re-enabled some redundant methods that I had removed - and in fact replaced=20 - which did the job in the old way).=20 However, when testing my fix it I noticed that SR2 does no longer start properly.=20 SR2 is announced, but the GameStatus panel does not change in any way,=20 disallowing any user action. I have now undone my changes, but SR2 still does not start. So it looks there is a problem with your recent changes. What do you see in SR2? Erik. >=20 > ---Brett. >=20 >=20 > On 2/21/06, brett lentz <wak...@gm...> wrote: > > I'm seeing a bug in StatusWindow where after buying out 100% of the > > company, the selector button remains at 10%. > > > > > > ----Brett. > > > > > > >=20 >=20 > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking=20 > scripting language > that extends applications into web and mobile media. Attend=20 > the live webcast > and join the prime developer group breaking into this new=20 > coding territory! > http://sel.as-us.falkag.net/sel?cmd=3Dk&kid=110944&bid$1720&dat=121642 > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel >=20 >=20 |
From: brett l. <wak...@gm...> - 2006-02-23 23:23:09
|
On 2/23/06, Erik Vos <eri...@hc...> wrote: > > I've fixed the bug. It looks like it was due to me being a little > > over-zealous and commenting some necessary methods. > > I've also found a fix, but a different one (you have re-enabled > some redundant methods that I had removed - and in fact replaced > - which did the job in the old way). > Ok... I thought I may have disabled them when I was mucking about with ORWi= ndow. Go ahead and remove them, and put in your new fix. > However, when testing my fix it I noticed that SR2 does no longer start > properly. > SR2 is announced, but the GameStatus panel does not change in any way, > disallowing any user action. > > I have now undone my changes, but SR2 still does not start. > So it looks there is a problem with your recent changes. > What do you see in SR2? > I'll test this shortly. ---Brett. |