rails-devel — List for discussion of Rails development

Re: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II

[Erik V. <eri...@xs...>]

Indeed the problem seems to be that the *current* player sequence is saved, instead of the *original* sequence.

When reloading, the game engine replays the game from the start, so the original player names list must be saved.

That should be easy to fix.  

 

Another problem, is that the player list is not a state variable and so reordering is not undoable. But I’ll leave that as is for a while, as Stefan will turn it upside down anyway.

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Thursday, January 26, 2012 8:12 PM
To: Erik Vos; Rails Development
Subject: Re: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II

 

Hi Erik,

 

please find enclosed the savegame.

 

The problem arises fro the fact that in 1880 i "artificially" reorder the players based on the outcome of Startround. The game of course only saves actions and some variables and the load mechanismn cant determine the changed player order. This leads to the fact that the playername array will have the original player as actionstarter "A" while getcurrentplayer() of course returns the new playerorder (in this case "C") as the players-array has been reordered after the startinground and C ist the player with the fewest money thus the first player in the new seat order.

 

How do we want to go here ?

 

If we add the original seat order as additional data to be saved we still have the problem to be solved that the actions up to a specific point in game time (end of Startround) which we currently cant pinpoint (as only actions get saved and restored), are connected to the wrong player.

Should we perhaps create a special action that then can be saved ? and of course must be run automatically ? or manually ?

 

Regards,

Martin

 

Von: "Erik Vos" <eri...@xs...>
An: <Dr....@t-...>
Cc: "Development list for Rails: an 18xx game" <rai...@li...>
Betreff: RE: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II
Datum: Thu, 26 Jan 2012 14:45:07 +0100

Martin,

OK, let's work on these issues together.

1. The simple way out would be to change highlighting only, but I would immediately concede that actually changing the visible player order is much better. So let's aim for that.
However, before making plans, we should have a solution to the next problem as well.

2. Apparently, the player order change has not yet been fully worked out. Can you send me a saved file that doesn't reload, so I can check out why it fails?

3. This is a different matter that we can deal with separately. In any case, it's OK to start with using modal popups, which is much easier. Once that works, it's not a big deal to refactor to use non-modal popups. I can pick up the second part, or all of it if you still don't feel happy about it.

Erik.


From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Wednesday, January 25, 2012 10:02 PM
To: Erik Vos
Subject: Re: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II

Hi Erik,

a number jump to my mind :)

Problem 1:
Based on the Fact that the PlayerOrder can change afte the outcome of the StartRound we need to have a flag to switch that order around and let the UI know that it needs to be aware of a new playerorder: Subsequently.
1. The upperPlayerCaption and lowerPlayerCaption need to be updated with the new player order. 
2. the player related fields need to be updated also in new order.

Currently the player order gets changed, the wrong player is shown as acting but the right player credited with the action. I.e. Player order in Display is A B C D, player c has fewest money after start is now starting player for stock round. 

Player A is highlighted performs an action and result of action is credited to player c in display. (this is right but confusing as player c should have moved in display to first colomn been highlighted and shown as performing the action :))

Problem 2:
The reordering of players causes the game to reject any save game after the initial Startround. Player x cant perform that action...

Problem 3:

The StartCompany-mechanismn is now for StartroundWindow two actions subsequently (Because the share size of the BCR president share is fixed..)
For each other company its three actions in order: a) Determine the startprice/startingorderposition
b) Determine the size of the presidents share -20/30/40%
c) Determine the BuildingRight based on restrictions from the presidents share (40& Shares can only have Phase A or B or C or D, 30% can have 2 Phases and 20% can have 3 Phases (A+B+C, B+C+D)

This in connection with the radiobuttoncode is beyond my skills yet :)

Those are my most urgent problems where the wall is to stubborn to give way to my head !

Regards,
Martin

P.s. your comments where helpful and the right way to show me the way around, i can take positive criticismn :)



 

Re: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II

[Erik V. <eri...@xs...>]

Martin,

OK, let's work on these issues together.

1. The simple way out would be to change highlighting only, but I would immediately concede that actually changing the visible player order is much better.  So let's aim for that.
However, before making plans, we should have a solution to the next problem as well.

2. Apparently, the player order change has not yet been fully worked out.  Can you send me a saved file that doesn't reload, so I can check out why it fails?

3. This is a different matter that we can deal with separately.  In any case, it's OK to start with using modal popups, which is much easier.  Once that works, it's not a big deal to refactor to use non-modal popups.  I can pick up the second part, or all of it if you still don't feel happy about it.

Erik.


From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Wednesday, January 25, 2012 10:02 PM
To: Erik Vos
Subject: Re: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II

Hi Erik,
 
a number jump to my mind :)
 
Problem 1:
Based on the Fact that the PlayerOrder can change afte the outcome of the StartRound we need to have a flag to switch that order around and let the UI know that it needs to be aware of a new playerorder: Subsequently.
1. The upperPlayerCaption and lowerPlayerCaption need to be updated with the new player order. 
2. the player related fields need to be updated also in new order.
 
Currently the player order gets changed, the wrong player is shown as acting but the right player credited with the action. I.e. Player order in Display is A B C D, player c has fewest money after start is now starting player for stock round. 
 
Player A is highlighted performs an action and result of action is credited to player c in display. (this is right but confusing as player c should have moved in display to first colomn been highlighted and shown as performing the action :))
 
Problem 2:
The reordering of players causes the game to reject any save game after the initial Startround. Player x cant perform that action...
 
Problem 3:
 
The StartCompany-mechanismn is now for StartroundWindow two actions subsequently (Because the share size of the BCR president share is fixed..)
For each other company its three actions in order: a) Determine the startprice/startingorderposition
 b) Determine the size of the presidents share -20/30/40%
c) Determine the BuildingRight based on restrictions from the presidents share (40& Shares can only have Phase A or B or C or D, 30% can have 2 Phases and 20% can have 3 Phases (A+B+C, B+C+D)
 
This in connection with the radiobuttoncode is beyond my skills yet :)
 
Those are my most urgent problems where the wall is to stubborn to give way to my head !
 
Regards,
Martin
 
P.s. your comments where helpful and the right way to show me the way around, i can take positive criticismn :)
 

Re: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II

[Erik V. <eri...@xs...>]

Martin,

 

Your new patch was deemed invalid, I suppose because of whitespace differences, but it was easy enough to do manually.

It all seems to work now, the test set is still passed, so I have committed your changes into master.

I have also added the new tile 235 to TileDesigner, to prevent that its XML representation gets overwritten by future tile updates.

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Wednesday, January 25, 2012 10:48 AM
To: Rails Development
Subject: [Rails-devel] Fw: Re: Push Request : 1880 Code Update Part II

 

Hi Erik,

 

The Class rails.game.special.ExtraTileLay is currently not used. It should be removed from the data definition of the BCR.

Von: "Erik Vos" < <mailto:eri...@xs...> eri...@xs...>

An: <Dr....@t-...>, "'Development list for Rails: an 18xx game'" <rai...@li...>

Betreff: Re: [Rails-devel] Push Request : 1880 Code Update Part II

Datum: Wed, 25 Jan 2012 00:09:53 +0100

 

 

Martin,

 

The code compiles but doesn’t run, because you refer to a class "rails.game.special.ExtraTileLay" that doesn’t exist. Not sure what your intention is here – I think we have discussed before how to enable the BCR laying two tiles. Is this just a leftover?

 

Erik.

 

From:  <mailto:Dr....@t-...> Dr....@t-...  <mailto:[mailto:Dr....@t-...]> [mailto:Dr....@t-...] 
Sent: Tuesday, January 24, 2012 11:28 PM
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Push Request : 1880 Code Update Part II

 

Hi Erik,

 

you are welcome, sorry for the double work :).

 

Regards,

Martin

 

Von: "Erik Vos" < <mailto:eri...@xs...> eri...@xs...>

An: <Dr....@t-...>, "'Development list for Rails: an 18xx game'" <rai...@li...>

Betreff: Re: [Rails-devel] Push Request : 1880 Code Update Part II

Datum: Tue, 24 Jan 2012 23:06:22 +0100

 

 

Thanks Martin, this is much better! 

  

However, I’m having a problem to load these patches with ‘git am’, it says “Patch format detection fails”.  Does anyone have a clue? 

  

Erik. 

 

From:  <mailto:Dr....@t-...> Dr....@t-...  <mailto:[mailto:Dr....@t-...]> [mailto:Dr....@t-...] 
Sent: Tuesday, January 24, 2012 8:30 PM
To: Rails Development
Subject: [Rails-devel] Push Request : 1880 Code Update Part II

 

Hi Eric, et al.

 

please find attached the Code changes based on the originally submitted patch on Sunday.

 

Alternativly i have also attached the whole patch against the master also.

 

1.       Patch line 291: please don’t use static variables to represent dynamic and game-instance dependent data.  We want to be prepared to process multiple game instances in one program instance. 

Fixed temporarly as i still need to find out how to access the instance of gameManager to get the variable to show (Lack of Java Experience on my side)

  

2.       Patch line 341: can’t the constant ‘CAPITALISE_FIFTY_PERCENT’ better be replaced by the more generic ‘CAPITALISE_PERCENTAGE’ with an additional numeric attribute that states the percentage?  

 

Took out that code entirely. Hardcoded the capitalisation in floatCompany of StartRound_1880 and StockRound_1880. 

  

3.       I really wonder why you think you need an extra method PublicCompanyI.getNumberOfTileLays() with an additional company argument.  A company knows its own identity and name, doesn’t it?  So why pass that identity another time? 

 

Lack of Java Experience, understood now :)

 

4.       Patch lines 416-421:  you shouldn’t include 1880-specific code into the generic  Round class the way you do here.  I don’t want to see references to 1880 and Shanghai in this class.   If you can’t find a way to reformulate this in a generic way, you can always override floatCompany() in  StockRound_1880.

 

See 2.

 

5.       Patch lines 644-648:  similar comment as point 2.  I believe we have discussed this before.

 

Fixed.

 

6.       BuyStartItem: why add a new boolean method isSharePriceToSet() if we already have the identical hasSharePriceToSet()?  And why can’t the whole Building Rights code be included in BuyStartItem_1880, which you have created anyway, instead of polluting BuyStartItem with that?

 

Incidentally that was a left over as the code had already been brought down to BuyStartItem_1880 and stemmed from some refactoring attempts that didnt get cleaned up, sorry about that.

 

7.       Similarly, why can’t the whole par slots code be included into StockMarket_1880?

 

Will be moved there.

 

And thanks again for your comments Erik :)

 

Kind Regards,

 

Martin

 

 

 

 

 

Re: [Rails-devel] Push Request : 1880 Code Update Part II

[Erik V. <eri...@xs...>]

Martin,

 

The code compiles but doesn’t run, because you refer to a class "rails.game.special.ExtraTileLay" that doesn’t exist. Not sure what your intention is here – I think we have discussed before how to enable the BCR laying two tiles. Is this just a leftover?

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Tuesday, January 24, 2012 11:28 PM
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] Push Request : 1880 Code Update Part II

 

Hi Erik,

 

you are welcome, sorry for the double work :).

 

Regards,

Martin

 

Von: "Erik Vos" <eri...@xs...>

An: <Dr....@t-...>, "'Development list for Rails: an 18xx game'" <rai...@li...>

Betreff: Re: [Rails-devel] Push Request : 1880 Code Update Part II

Datum: Tue, 24 Jan 2012 23:06:22 +0100

 

 

Thanks Martin, this is much better!

 

However, I’m having a problem to load these patches with ‘git am’, it says “Patch format detection fails”.  Does anyone have a clue?

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Tuesday, January 24, 2012 8:30 PM
To: Rails Development
Subject: [Rails-devel] Push Request : 1880 Code Update Part II

 

Hi Eric, et al.

 

please find attached the Code changes based on the originally submitted patch on Sunday.

 

Alternativly i have also attached the whole patch against the master also.

 

1.       Patch line 291: please don’t use static variables to represent dynamic and game-instance dependent data.  We want to be prepared to process multiple game instances in one program instance. 

Fixed temporarly as i still need to find out how to access the instance of gameManager to get the variable to show (Lack of Java Experience on my side)

  

2.       Patch line 341: can’t the constant ‘CAPITALISE_FIFTY_PERCENT’ better be replaced by the more generic ‘CAPITALISE_PERCENTAGE’ with an additional numeric attribute that states the percentage?  

 

Took out that code entirely. Hardcoded the capitalisation in floatCompany of StartRound_1880 and StockRound_1880. 

  

3.       I really wonder why you think you need an extra method PublicCompanyI.getNumberOfTileLays() with an additional company argument.  A company knows its own identity and name, doesn’t it?  So why pass that identity another time? 

 

Lack of Java Experience, understood now :)

 

4.       Patch lines 416-421:  you shouldn’t include 1880-specific code into the generic  Round class the way you do here.  I don’t want to see references to 1880 and Shanghai in this class.   If you can’t find a way to reformulate this in a generic way, you can always override floatCompany() in  StockRound_1880.

 

See 2.

 

5.       Patch lines 644-648:  similar comment as point 2.  I believe we have discussed this before.

 

Fixed.

 

6.       BuyStartItem: why add a new boolean method isSharePriceToSet() if we already have the identical hasSharePriceToSet()?  And why can’t the whole Building Rights code be included in BuyStartItem_1880, which you have created anyway, instead of polluting BuyStartItem with that?

 

Incidentally that was a left over as the code had already been brought down to BuyStartItem_1880 and stemmed from some refactoring attempts that didnt get cleaned up, sorry about that.

 

7.       Similarly, why can’t the whole par slots code be included into StockMarket_1880?

 

Will be moved there.

 

And thanks again for your comments Erik :)

 

Kind Regards,

 

Martin

 

 

 

Re: [Rails-devel] Push Request : 1880 Code Update Part II

[<Dr....@t-...>]

Hi Erik, 

	you are welcome, sorry for the double work :). 

	Regards, 

	Martin

	Von: "Erik Vos" <eri...@xs...> 

	An: <Dr....@t-...>, "'Development list for Rails: an
18xx game'" <rai...@li...> 

	Betreff: Re: [Rails-devel] Push Request : 1880 Code Update Part II 

	Datum: Tue, 24 Jan 2012 23:06:22 +0100 

	Thanks Martin, this is much better! 

	However, I’m having a problem to load these patches with ‘git
am’, it says “Patch format detection fails”.  Does anyone have a
clue? 

	Erik. 

	From: Dr....@t-...
[mailto:Dr....@t-...] 
Sent: Tuesday, January 24, 2012 8:30 PM
To: Rails Development
Subject: [Rails-devel] Push Request : 1880 Code Update Part II   

	Hi Eric, et al. 

	please find attached the Code changes based on the originally
submitted patch on Sunday. 

	Alternativly i have also attached the whole patch against the master
also. 

	1.       Patch line 291: please don’t use static variables to
represent dynamic and game-instance dependent data.  We want to be
prepared to process multiple game instances in one program instance.  
 

	Fixed temporarly as i still need to find out how to access the
instance of gameManager to get the variable to show (Lack of Java
Experience on my side)  

	2.       Patch line 341: can’t the constant
‘CAPITALISE_FIFTY_PERCENT’ better be replaced by the more generic
‘CAPITALISE_PERCENTAGE’ with an additional numeric attribute that
states the percentage?   

	Took out that code entirely. Hardcoded the capitalisation in
floatCompany of StartRound_1880 and StockRound_1880.  

	3.       I really wonder why you think you need an extra method
PublicCompanyI.getNumberOfTileLays() with an additional company
argument.  A company knows its own identity and name, doesn’t it? 
So why pass that identity another time?  

	Lack of Java Experience, understood now :) 

	4.       Patch lines 416-421:  you shouldn’t include 1880-specific
code into the generic  Round class the way you do here.  I don’t
want to see references to 1880 and Shanghai in this class.   If you
can’t find a way to reformulate this in a generic way, you can
always override floatCompany() in  StockRound_1880. 

	See 2. 

	5.       Patch lines 644-648:  similar comment as point 2.  I believe
we have discussed this before. 

	Fixed. 

	6.       BuyStartItem: why add a new boolean method
isSharePriceToSet() if we already have the identical
hasSharePriceToSet()?  And why can’t the whole Building Rights code
be included in BuyStartItem_1880, which you have created anyway,
instead of polluting BuyStartItem with that? 

	Incidentally that was a left over as the code had already been
brought down to BuyStartItem_1880 and stemmed from some refactoring
attempts that didnt get cleaned up, sorry about that. 

	7.       Similarly, why can’t the whole par slots code be included
into StockMarket_1880? 

	Will be moved there. 

	And thanks again for your comments Erik :) 

	Kind Regards, 

	Martin

Re: [Rails-devel] Push Request : 1880 Code Update Part II

[brett l. <bre...@gm...>]

I think it's because the patches are missing any mail header
information. "am" stands for "apply mailbox", which makes it
especially useful if you use a text-based mail program, like mutt or
pine.

"git apply" (which is what 'git am' calls) does seem to correctly
detect the patch.

---Brett.



On Tue, Jan 24, 2012 at 5:06 PM, Erik Vos <eri...@xs...> wrote:
> Thanks Martin, this is much better!
>
>
>
> However, I’m having a problem to load these patches with ‘git am’, it says
> “Patch format detection fails”.  Does anyone have a clue?
>
>
>
> Erik.
>
>
>
> From: Dr....@t-... [mailto:Dr....@t-...]
> Sent: Tuesday, January 24, 2012 8:30 PM
> To: Rails Development
> Subject: [Rails-devel] Push Request : 1880 Code Update Part II
>
>
>
> Hi Eric, et al.
>
>
>
> please find attached the Code changes based on the originally submitted
> patch on Sunday.
>
>
>
> Alternativly i have also attached the whole patch against the master also.
>
>
>
> 1.       Patch line 291: please don’t use static variables to represent
> dynamic and game-instance dependent data.  We want to be prepared to process
> multiple game instances in one program instance.
>
> Fixed temporarly as i still need to find out how to access the instance of
> gameManager to get the variable to show (Lack of Java Experience on my side)
>
>
>
> 2.       Patch line 341: can’t the constant ‘CAPITALISE_FIFTY_PERCENT’
> better be replaced by the more generic ‘CAPITALISE_PERCENTAGE’ with an
> additional numeric attribute that states the percentage?
>
>
>
> Took out that code entirely. Hardcoded the capitalisation in floatCompany of
> StartRound_1880 and StockRound_1880.
>
>
>
> 3.       I really wonder why you think you need an extra method
> PublicCompanyI.getNumberOfTileLays() with an additional company argument.  A
> company knows its own identity and name, doesn’t it?  So why pass that
> identity another time?
>
>
>
> Lack of Java Experience, understood now :)
>
>
>
> 4.       Patch lines 416-421:  you shouldn’t include 1880-specific code into
> the generic  Round class the way you do here.  I don’t want to see
> references to 1880 and Shanghai in this class.   If you can’t find a way to
> reformulate this in a generic way, you can always override floatCompany()
> in  StockRound_1880.
>
>
>
> See 2.
>
>
>
> 5.       Patch lines 644-648:  similar comment as point 2.  I believe we
> have discussed this before.
>
>
>
> Fixed.
>
>
>
> 6.       BuyStartItem: why add a new boolean method isSharePriceToSet() if
> we already have the identical hasSharePriceToSet()?  And why can’t the whole
> Building Rights code be included in BuyStartItem_1880, which you have
> created anyway, instead of polluting BuyStartItem with that?
>
>
>
> Incidentally that was a left over as the code had already been brought down
> to BuyStartItem_1880 and stemmed from some refactoring attempts that didnt
> get cleaned up, sorry about that.
>
>
>
> 7.       Similarly, why can’t the whole par slots code be included into
> StockMarket_1880?
>
>
>
> Will be moved there.
>
>
>
> And thanks again for your comments Erik :)
>
>
>
> Kind Regards,
>
>
>
> Martin
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Push Request : 1880 Code Update Part II

[Erik V. <eri...@xs...>]

Thanks Martin, this is much better!

 

However, I’m having a problem to load these patches with ‘git am’, it says “Patch format detection fails”.  Does anyone have a clue?

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Tuesday, January 24, 2012 8:30 PM
To: Rails Development
Subject: [Rails-devel] Push Request : 1880 Code Update Part II

 

Hi Eric, et al.

 

please find attached the Code changes based on the originally submitted patch on Sunday.

 

Alternativly i have also attached the whole patch against the master also.

 

1.       Patch line 291: please don’t use static variables to represent dynamic and game-instance dependent data.  We want to be prepared to process multiple game instances in one program instance.

Fixed temporarly as i still need to find out how to access the instance of gameManager to get the variable to show (Lack of Java Experience on my side)

 

2.       Patch line 341: can’t the constant ‘CAPITALISE_FIFTY_PERCENT’ better be replaced by the more generic ‘CAPITALISE_PERCENTAGE’ with an additional numeric attribute that states the percentage? 

 

Took out that code entirely. Hardcoded the capitalisation in floatCompany of StartRound_1880 and StockRound_1880.

 

3.       I really wonder why you think you need an extra method PublicCompanyI.getNumberOfTileLays() with an additional company argument.  A company knows its own identity and name, doesn’t it?  So why pass that identity another time?

 

Lack of Java Experience, understood now :)

 

4.       Patch lines 416-421:  you shouldn’t include 1880-specific code into the generic  Round class the way you do here.  I don’t want to see references to 1880 and Shanghai in this class.   If you can’t find a way to reformulate this in a generic way, you can always override floatCompany() in  StockRound_1880.

 

See 2.

 

5.       Patch lines 644-648:  similar comment as point 2.  I believe we have discussed this before.

 

Fixed.

 

6.       BuyStartItem: why add a new boolean method isSharePriceToSet() if we already have the identical hasSharePriceToSet()?  And why can’t the whole Building Rights code be included in BuyStartItem_1880, which you have created anyway, instead of polluting BuyStartItem with that?

 

Incidentally that was a left over as the code had already been brought down to BuyStartItem_1880 and stemmed from some refactoring attempts that didnt get cleaned up, sorry about that.

 

7.       Similarly, why can’t the whole par slots code be included into StockMarket_1880?

 

Will be moved there.

 

And thanks again for your comments Erik :)

 

Kind Regards,

 

Martin

 

 

Re: [Rails-devel] Push request: 1880 code update

[Erik V. <eri...@xs...>]

Hi Martin,

 

A few comments (just from looking at your code changes to generic classes. I haven’t tested anything yet):

 

1.       Patch line 291: please don’t use static variables to represent dynamic and game-instance dependent data.  We want to be prepared to process multiple game instances in one program instance.

 

2.       Patch line 341: can’t the constant ‘CAPITALISE_FIFTY_PERCENT’ better be replaced by the more generic ‘CAPITALISE_PERCENTAGE’ with an additional numeric attribute that states the percentage?  

 

3.       I really wonder why you think you need an extra method PublicCompanyI.getNumberOfTileLays() with an additional company argument.  A company knows its own identity and name, doesn’t it?  So why pass that identity another time?

 

4.       Patch lines 416-421:  you shouldn’t include 1880-specific code into the generic  Round class the way you do here.  I don’t want to see references to 1880 and Shanghai in this class.   If you can’t find a way to reformulate this in a generic way, you can always override floatCompany() in  StockRound_1880.

 

5.       Patch lines 644-648:  similar comment as point 2.  I believe we have discussed this before.

 

6.       BuyStartItem: why add a new boolean method isSharePriceToSet() if we already have the identical hasSharePriceToSet()?  And why can’t the whole Building Rights code be included in BuyStartItem_1880, which you have created anyway, instead of polluting BuyStartItem with that?

 

7.       Similarly, why can’t the whole par slots code be included into StockMarket_1880?

 

Apologies for being critical, but I really feel you are putting too many 1880 specials into generic code.

 

Erik.

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Sunday, January 22, 2012 7:48 PM
To: Rails Development
Subject: [Rails-devel] Push request: 1880 code update

 

Hello Eric, Brett, Stefan et al.

 

please find the current status of 1880 specific code in the attachment. 

I would like to ask you to review the code and push it to the master or a branch as you see fit.

 

If theres anything that needs changed please dont hesitate to either apply the changes or point me in the right direction.

 

 

    Fixed Tile definition for Tile 235
    1880 Implemented Roundmechanismn for Stock and Operation Rounds.
    Fixed Typo in TileColour for extra permanent Tilelay of BCR

   Added tile235.svg it apparently got lost somehow in the first
    transmission.
   Removed wrong configuration point 1826 TGV modifier
    Reverse Commit of Trainmanager. action has been moved to
    OperatingRound_1880

   1880:     Overriding newPhaseChecks() from OperatingRound
            Overriding resume() from OperatingRound
            Overriding process() from OperatingRound
            The Stockround should now begin if trains trigger a phase change and
            if noone buys a train for a complete Round.
            Trains of the last active type will be made unavailable.
            Creating a method to remove all trains from the bank portfolio

   1880: Creating and introducing GameManager_1880 class

    1880: Changing finishGame to protected to be able to call it from
    subclasses.

  1880: Introducing GameManager_1880 Class

    1880: Make finishGame visible in a GameManager Subclass by changing it
    to protected instead of private. This is needed in the moment if theres
    no game specific finish game procedure.

   1880: Initialising a string which otherwise might lead to a problem.

    1880: Start of implementation of the Operating Round; Making sure that
    the BCR is allowed to lay 2 yellow tiles even in the first phase.

    Creating and implementing an interface in PublicCompanyI &
    PublicCompany to allow a search for the number of tiles a
    specific company is allowed to lay in a Phase.

    Fixed Company Listing in CompanyManager.xml
    Implemented Use of Capitalisation Rule


    1880 Additions Startound is now playable.
    Caveat: Mechanismn in the moment not specific for the only Starting
    Paper of 1880 but generic implementation.
    The BCR is always a 20% Starting Paper so we dont need to adjust the
    portfolio there, but it can choose from the whole spectrum of building
    right.
    
    
    Modifications to StartRoundWindow and BuyStartItem to allow access to
    certain variables.
    
    Next Step:
    -introduction of StockRoundWindow_1880.
    -update of StatusWindow_1880 to incoporate the buildingrights into
    display.
       
    Modifications to StartRoundWindow and BuyStartItem to allow access to certain variables.
    
    Next Step:
    -introduction of StockRoundWindow_1880.
    -update of StatusWindow_1880 to incoporate the buildingrights into display.

    1880:
    - Changes based on the PhaseAction Mechanismn that Erik introduced
    recently
    -PublicCompany_1880 now has the ability to set the Floating Percentage
    this is used in 1880
    and might be used in combination with checkFlotation() if introduced
    into PublicCompanyI or via the PhaseAction
    -added the Capitalisation Method of 1880 to PublicCompany. just to
    make sure somebody else knows about that concept.
    - implemented the CommunistPhase and its Stockmarket handling.
    
    rails/game/Company.java: Fixed Spelling Error in Comment

    Changes to StockSpace and StockMarket to incorporate the additional revenues on the Stocktableau
    
    Preparing steps to incorporate the building rights for public companies.
    
    preparing Steps to generate a Subclass for StartRoundWindow.

 

 

 

The following files have been changed:

 

data/1880/Tiles.xml
tiles/TileDictionary.xml
tiles/svg/tile235.svg

rails/game/specific/_1880/GameManager_1880.java
rails/game/specific/_1880/OperatingRound_1880.java

rails/game/specific/_1880/PublicCompany_1880.java

data/1880/Game.xml

rails/game/GameManager.java

rails/ui/swing/gamespecific/_1880/StartRoundWindow_1880.java

rails/game/PublicCompany.java
rails/game/PublicCompanyI.java

data/1880/CompanyManager.xml
rails/game/Round.java
rails/game/specific/_1880/StockRound_1880.java

rails/game/action/BuyStartItem.java
rails/game/specific/_1880/BuyStartItem_1880.java

rails/ui/swing/StartRoundWindow.java

LocalisedText.properties

rails/game/StockMarket.java
rails/game/StockMarketI.java
rails/game/StockSpace.java
rails/game/StockSpaceI.java
rails/game/StockSpaceType.java
rails/game/StockSpaceTypeI.java

 

 

 

There is still a few things to do for 1880 to become fully playable:

Minor Companies need to get automatic trains to support Revenue finding

Minor Companies need to get Shares

Mechanismn to close Minor Companies upon reaching their destination

Modification of share handling taking care of the fact that only 50% are initially avail until the first 3 train has been purchased.

Modification of share portfolio (20,30,40%) president shares

Making sure that the building right is used in operational moves (layTile Action).

Making the different UIs( StartRoundWindow, StockRoundWindow) aware of the seating order Change)

Make the par slot mechanismn active (Operation order of companies is fixed during ORS/dynamically after a Stockround)

 

And the most problematic of all: Make the game aware of seating order changes, currently a changed seating order prevents the game from loading any save files after that change. (This is of course also the case for 1853 or any other game that determines the seating order after game setup).

 

 

Regards,

Martin

Re: [Rails-devel] Change: Tiles are excluded from upgrade panel if no valid orientation exists

[Stefan F. <ste...@we...>]

Frederick:
(implicitly) increasing the pressure on you to follow up with this 
functionality worked great ;-)

Love how it works, the only thing missing now is that the image shows the 
first possible allowed rotation (and may be after selecting all others).

Stefan


On Sunday, January 22, 2012 01:38:35 pm Frederick Weld wrote:
> Stefan:
> > I will not include your change into the 1.6.1 change, as it might come to
> > a surprise for users.
> 
> No problem.
> In most cases, I add configuration options the default value of which
> refers to the behavior in prior releases. But I hadn't done this for
> this change.
> 
> btw: Master now contains the logic for grayed out invalid tile lays
> and reasons (in popups - only two most interesting ones). Furthermore,
> I couldn't resist the temptation to add interactive map hex
> highlighting on unavailable tiles (highlight shows where tile
> instances have been layed to).
> 
> ---------------------------------------------------------------------------
> --- Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Change: Tiles are excluded from upgrade panel if no valid orientation exists

[Frederick W. <fre...@go...>]

Stefan:
> I will not include your change into the 1.6.1 change, as it might come to a surprise for users.

No problem.
In most cases, I add configuration options the default value of which
refers to the behavior in prior releases. But I hadn't done this for
this change.

btw: Master now contains the logic for grayed out invalid tile lays
and reasons (in popups - only two most interesting ones). Furthermore,
I couldn't resist the temptation to add interactive map hex
highlighting on unavailable tiles (highlight shows where tile
instances have been layed to).

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Frederick W. <fre...@go...>]

Stefan:
My compiler compliance level is/was at 1.5. The revalidate issue is
surprising as any Java compiler (irrespective of the version) should
have been unable to run that.

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Stefan F. <ste...@we...>]

Frederick:
made the same mistake before: Change Project Settings => Java Compiler => 
Compiler Compliance Level to 1.5 in Eclipse to avoid that in the future.

Erik:
From my point of view there is no reason to update as long to Java 6 or 7 if 
there is no technical reason to do so.

Stefan


On Saturday, January 21, 2012 08:18:15 pm Erik Vos wrote:
> Thanks.  Yes, I started wondering if the Java version could play a role.
> AFAIK, the Rails Java version is still 5.0 (at least mine is), although
> perhaps we could consider upping it.
> 
> Erik.
> 
> > -----Original Message-----
> > From: Frederick Weld [mailto:fre...@go...]
> > Sent: Saturday, January 21, 2012 7:31 PM
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Releasing 1.6.1 this weekend?
> > 
> > Erik:
> > That's very interesting. My Eclipse always compiled/run without any issue
> 
> but
> 
> > Container clearly does not have that method (even not in SE 6). So thanks
> 
> for
> 
> > this finding.
> > 
> > Appropriate casts are now available in master.
> 
> ---------------------------------------------------------------------------
> - --
> 
> > Try before you buy = See our experts in action!
> > The most comprehensive online learning library for Microsoft developers
> > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> 
> Metro
> 
> > Style Apps, more. Free future releases when you subscribe now!
> > http://p.sf.net/sfu/learndevnow-dev2
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> ---------------------------------------------------------------------------
> --- Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Change: Tiles are excluded from upgrade panel if no valid orientation exists

[Stefan F. <ste...@we...>]

Follow-up to Frederick:
I will not include your change into the 1.6.1 change, as it might come to a 
surprise for users. For adding a gray-scale support I am missing the time to 
add it now.
Stefan


On Thursday, January 19, 2012 12:11:15 am Stefan Frey wrote:
> Frederick:
> Sorry for the misunderstanding: I am not actually working on a tile lay
> mechanisms, I was only outlining for myself how a solution might look like.
> Unfortunately a full implementation of the tile lay mechanisms that covers
> all 18xx specifics is quite a task, so it is pretty low on my current
> agenda.
> 
> I was merely suggesting that you should consider to gray out the tiles that
> have no valid orientation instead of removing them from the upgrade panel.
> So feel free to either keep it as it is now or change it how you like it
> best. Stefan
> 
> On Wednesday, January 18, 2012 07:00:38 pm Frederick Weld wrote:
> > Stefan:
> > Your proposed mechanism sounds very promising (greying out & reasons).
> > 
> > Please feel free to revert my changes once having finished your work on
> > that.
> > 
> > -------------------------------------------------------------------------
> > -- --- Keep Your Developer Skills Current with LearnDevNow!
> > The most comprehensive online learning library for Microsoft developers
> > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> > Metro Style Apps, more. Free future releases when you subscribe now!
> > http://p.sf.net/sfu/learndevnow-d2d
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> ---------------------------------------------------------------------------
> --- Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Erik V. <eri...@xs...>]

Thanks.  Yes, I started wondering if the Java version could play a role.
AFAIK, the Rails Java version is still 5.0 (at least mine is), although
perhaps we could consider upping it.

Erik.

> -----Original Message-----
> From: Frederick Weld [mailto:fre...@go...]
> Sent: Saturday, January 21, 2012 7:31 PM
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Releasing 1.6.1 this weekend?
> 
> Erik:
> That's very interesting. My Eclipse always compiled/run without any issue
but
> Container clearly does not have that method (even not in SE 6). So thanks
for
> this finding.
> 
> Appropriate casts are now available in master.
> 
>
----------------------------------------------------------------------------
--
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers is
> just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro
> Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Frederick W. <fre...@go...>]

Erik:
That's very interesting. My Eclipse always compiled/run without any
issue but Container clearly does not have that method (even not in SE
6). So thanks for this finding.

Appropriate casts are now available in master.

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Erik V. <eri...@xs...>]

Apparently I wasn't clear: MessagePanel doesn't even compile.
 getParent() returns Container, but revalidate() is a method of JContainer.

Erik.

> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Saturday, January 21, 2012 6:02 PM
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Releasing 1.6.1 this weekend?
> 
> I'm getting two "undefined method" errors in MessagePanel, in lines that
> read
>             parentSlider.getParent().revalidate();
> 
> Erik.
> 
> > -----Original Message-----
> > From: Frederick Weld [mailto:fre...@go...]
> > Sent: Saturday, January 21, 2012 4:18 PM
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Releasing 1.6.1 this weekend?
> >
> > A polished version of the grid panel (used by or panel and status
> > window) is now available in master.
> >
> > This opens some options for the future regarding grid panel
highlighting.
> >
> > Note that the table borders (which I like a lot - but which could be
> > controversal to others) are configured to be disabled as default.
> >
> > -----------
> > More details:
> > -----------
> >
> >     Introduced highlighting and table borders for Status Win & ORPanel
> >
> >     Instead of insets as parts of GridBag constraints, GridPanel now
> >     attaches dynamic borders to the fields.
> >
> >     This has enabled the following:
> >     - GridPanel table borders are visualized without any effort - making
> >       the panels much nicer
> >     - GridPanel cells (fields,...) can now be highlighted by altering
> >       their dynamic borders
> >         - even inner borders (margins) used for the highlight outline
box
> >         - design corresponds to the one used for displaying selected
> >           tiles in the hex map
> >
> >     Introduced new option to enable/disable table borders in grid
> > panels
> >
> >     By default, borders are disabled (but highlighting is always
enabled).
> >
> >
>
----------------------------------------------------------------------------
> --
> > Try before you buy = See our experts in action!
> > The most comprehensive online learning library for Microsoft
> > developers is just $99.99! Visual Studio, SharePoint, SQL - plus
> > HTML5, CSS3, MVC3,
> Metro
> > Style Apps, more. Free future releases when you subscribe now!
> > http://p.sf.net/sfu/learndevnow-dev2
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 
>
----------------------------------------------------------------------------
--
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers is
> just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro
> Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Frederick W. <fre...@go...>]

Erik:
Could you please attach a save game for reproducing the issue?
I had thoroughly tested the scrollable message panel functionality
before pushing it about 10 days ago - but remaining bugs cannot be
excluded, of course.
(At least, I'm sure that it's not related to today's grid panel redesign.)

---Frederick

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Erik V. <eri...@xs...>]

I'm getting two "undefined method" errors in MessagePanel, in lines that
read
            parentSlider.getParent().revalidate();

Erik.

> -----Original Message-----
> From: Frederick Weld [mailto:fre...@go...]
> Sent: Saturday, January 21, 2012 4:18 PM
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Releasing 1.6.1 this weekend?
> 
> A polished version of the grid panel (used by or panel and status
> window) is now available in master.
> 
> This opens some options for the future regarding grid panel highlighting.
> 
> Note that the table borders (which I like a lot - but which could be
> controversal to others) are configured to be disabled as default.
> 
> -----------
> More details:
> -----------
> 
>     Introduced highlighting and table borders for Status Win & ORPanel
> 
>     Instead of insets as parts of GridBag constraints, GridPanel now
>     attaches dynamic borders to the fields.
> 
>     This has enabled the following:
>     - GridPanel table borders are visualized without any effort - making
>       the panels much nicer
>     - GridPanel cells (fields,...) can now be highlighted by altering
>       their dynamic borders
>         - even inner borders (margins) used for the highlight outline box
>         - design corresponds to the one used for displaying selected
>           tiles in the hex map
> 
>     Introduced new option to enable/disable table borders in grid panels
> 
>     By default, borders are disabled (but highlighting is always enabled).
> 
>
----------------------------------------------------------------------------
--
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers is
> just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro
> Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Frederick W. <fre...@go...>]

Brett:
It's configurable in the configuration window (new tab "Appearance"
that also contains the route colors).

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[brett l. <bre...@gm...>]

On Sat, Jan 21, 2012 at 10:17 AM, Frederick Weld
<fre...@go...> wrote:
> Note that the table borders (which I like a lot - but which could be
> controversal to others) are configured to be disabled as default.

Based on the commit diff, it looks like these are only configurable
via the config files. Is that correct?

If that's true, it might be good to think about surfacing some of
these display options into their own menu.

---Brett.

Re: [Rails-devel] Releasing 1.6.1 this weekend?

[Frederick W. <fre...@go...>]

A polished version of the grid panel (used by or panel and status
window) is now available in master.

This opens some options for the future regarding grid panel highlighting.

Note that the table borders (which I like a lot - but which could be
controversal to others) are configured to be disabled as default.

-----------
More details:
-----------

    Introduced highlighting and table borders for Status Win & ORPanel

    Instead of insets as parts of GridBag constraints, GridPanel now
    attaches dynamic borders to the fields.

    This has enabled the following:
    - GridPanel table borders are visualized without any effort - making
      the panels much nicer
    - GridPanel cells (fields,...) can now be highlighted by altering
      their dynamic borders
        - even inner borders (margins) used for the highlight outline box
        - design corresponds to the one used for displaying selected
          tiles in the hex map

    Introduced new option to enable/disable table borders in grid panels

    By default, borders are disabled (but highlighting is always enabled).

[Rails-devel] Releasing 1.6.1 this weekend?

[Stefan F. <ste...@we...>]

All:
I plan to release 1.6.1. at the end of this weekend, as there are quite a few 
of Frederick changes are piling up.
So keep last-minute fixes and changes rolling in ...

My intention is to update the 2.0 branch with my current local repo this or 
next weekend latest. Lots of stuff changed, so I hope to present something 
soon that is worth of feedback.

Stefan

Re: [Rails-devel] Change: Tiles are excluded from upgrade panel if no valid orientation exists

[Stefan F. <ste...@we...>]

Frederick:
Sorry for the misunderstanding: I am not actually working on a tile lay 
mechanisms, I was only outlining for myself how a solution might look like.
Unfortunately a full implementation of the tile lay mechanisms that covers all 
18xx specifics is quite a task, so it is pretty low on my current agenda.

I was merely suggesting that you should consider to gray out the tiles that 
have no valid orientation instead of removing them from the upgrade panel.
So feel free to either keep it as it is now or change it how you like it best.
Stefan



On Wednesday, January 18, 2012 07:00:38 pm Frederick Weld wrote:
> Stefan:
> Your proposed mechanism sounds very promising (greying out & reasons).
> 
> Please feel free to revert my changes once having finished your work on
> that.
> 
> ---------------------------------------------------------------------------
> --- Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Change: Tiles are excluded from upgrade panel if no valid orientation exists

[Frederick W. <fre...@go...>]

Stefan:
Your proposed mechanism sounds very promising (greying out & reasons).

Please feel free to revert my changes once having finished your work on that.

Re: [Rails-devel] Change: Tiles are excluded from upgrade panel if no valid orientation exists

[Stefan F. <ste...@we...>]

Frederick,
sorry pretty busy at work, so only a short comment:

In my planned implementation of full tile laying support I intended
to give users hints in the UI that distinguish between between the reasons why 
they are not able to lay a tile (no route, no valid orientation, no remaining 
quantity).

I have not tested your implementation yet, but from your wording below, it 
seems that you simply not display those tiles that cannot be laid in a valid 
orientation: I suggest that it is better to gray those out for example. 

This reminds that I cannot remember exactly how tiles are treated that have a 
zero quantity remaining: Do they show up in the upgrade panel? It is 
definitely too long I have not played Rails myself or any 18xx ;-)

Stefan

On Sunday, January 15, 2012 06:57:52 am Frederick Weld wrote:
> Before, selecting a tile of the upgrade panel could lead to the
> message "This tile cannot be laid in a valid orientation."
> 
> Now, tiles are excluded from the upgrade panel selection if such
> message would be issued upon clicking on them. Stated differently,
> every tile listed in the upgrade panel can now be laid by the user.
> 
> The level of rule enforcement is not affected by this change. So
> hopefully there are no objections to this change.
> 
> ---------------------------------------------------------------------------
> --- RSA(R) Conference 2012
> Mar 27 - Feb 2
> Save $400 by Jan. 27
> Register now!
> http://p.sf.net/sfu/rsa-sfdev2dev2
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel