rails-devel — List for discussion of Rails development

[Rails-devel] FEST assertion library added to rails2.0

[Stefan F. <ste...@we...>]

After some annoyance about the usage of the Hamcrest matchers in 
combination with JUnit, I have decided to replace them by those ones 
supplied by FEST (see http://code.google.com/p/fest/).

For those with no previous experience with Hamcrest, the basic idea is 
to write assertions in "fluent" expressions.

Take the example that I test that the Root object contains a 
StateManager after creation:

assertThat(root.getStateManager()).isInstanceOf(StateManager.class);

Other usages is that it allows to assert if an object is inside a 
collection etc.

More examples are in section 3 of the following guide:
https://github.com/alexruiz/fest-assert-2.x/wiki/One-minute-starting-guide

Given that there is a separate tree for all testing code (junit versus 
src), I moved all libraries (junit, jmockito and FEST assertions) which 
are used for testing only into a lib folder inside that tree.

Stefan

Re: [Rails-devel] Rails 1.7.7 1856 bug - CGR president's certificate

[John D. G. <jd...@di...>]

Kevin J. Price wrote:
>> It looks like the game is configured so that the President's certificate counts
>> as a single certificate, even if the CGR issues its second set of shares.
>>
>> The rules are admittedly slightly ambiguous on this, but I'm fairly certain the
>> intent is that each certificate, including the president's certificate, counts
>> as half a cert.
>>
>> Do you agree that this is a bug, or are you interpreting the rules otherwise?

On 2012-07-02 11:37, Mike Bourke wrote:
> Presidency, including that of the CGR, is always a double share. If the second
> set of shares is issued, each regular cert is 5% and the president’s cert is
> 10%, for a total of 18+1=19 certs. If not, each is 10% and the President’s
> share is 20%, for a total of 8+1=9 certs.

Correction: I hit Send too soon.

True but not on point.  Kevin is talking about how each CGR certificate is
supposed to be "counted" against each player's certificate limit.

I do not agree with Kevin that this is a bug.  The single shares of CGR are
supposed to count as half certificates if they are 5% each, but since the
president's certificate is two shares (as Mike said) it counts as one whole
certificate whether it is 10% or 20%.  I see no bug.

Re: [Rails-devel] Rails 1.7.7 1856 bug - CGR president's certificate

[John D. G. <jd...@di...>]

Kevin J. Price wrote:
>> It looks like the game is configured so that the President's certificate counts
>> as a single certificate, even if the CGR issues its second set of shares.
>>
>> The rules are admittedly slightly ambiguous on this, but I'm fairly certain the
>> intent is that each certificate, including the president's certificate, counts
>> as half a cert.
>>
>> Do you agree that this is a bug, or are you interpreting the rules otherwise?

On 2012-07-02 11:37, Mike Bourke wrote:
> Presidency, including that of the CGR, is always a double share. If the second
> set of shares is issued, each regular cert is 5% and the president’s cert is
> 10%, for a total of 18+1=19 certs. If not, each is 10% and the President’s
> share is 20%, for a total of 8+1=9 certs.

True but not on point.  Kevin is talking about how each CGR certificate is
supposed to be "counted" against each player's certificate limit.

I do not agree with Kevin that this is a bug.  The single shares of CGR are
supposed to count as half certificates, but the president's certificate is two
shares (as Mike said) and therefore counts as a whole certificate.  I see no bug.

Re: [Rails-devel] Rails 1.7.7 1856 bug - CGR president's certificate

[Mike B. <com...@ip...>]

Presidency, including that of the CGR, is always a double share. If the
second set of shares is issued, each regular cert is 5% and the president's
cert is 10%, for a total of 18+1=19 certs. If not, each is 10% and the
President's share is 20%, for a total of 8+1=9 certs.

 

Mike Bourke

Campaign Mastery http://www.campaignmastery.com
<http://www.campaignmastery.com/> 

Co-author, Assassin's Amulet  <http://www.legaciescampaignsetting.com/>
http://www.legaciescampaignsetting.com

  _____  

From: Kevin J. Price [mailto:kp...@gm...] 
Sent: Tuesday, 3 July 2012 3:09 AM
To: rai...@li...
Cc: Rich Price; Rick; Paul
Subject: [Rails-devel] Rails 1.7.7 1856 bug - CGR president's certificate

 

Rails developers,

I believe there is a bug in the 1856 configuration for the CGR president's
share.

It looks like the game is configured so that the President's certificate
counts as a single certificate, even if the CGR issues its second set of
shares.

The rules are admittedly slightly ambiguous on this, but I'm fairly certain
the intent is that each certificate, including the president's certificate,
counts as half a cert.

Do you agree that this is a bug, or are you interpreting the rules
otherwise?

Assuming you agree that this is a bug, I believe fixing this is a simple as
editing line 24 rails/data/1856/CompanyManager.xml, which currently reads:

<Certificate type="President" shares="2" certificateCount="1"/>

However, I do not know if that would fix an existing game or only a new
game.

Thanks,

  Kevin Price

-- 
Kevin J. Price  <kp...@gm...>   
"God is a comic playing to an audience that's afraid to laugh."




---
avast! Antivirus: Outbound message clean.
Virus Database (VPS): 120702-1, 02/07/2012
Tested on: 3/07/2012 4:37:43 AM
avast! - copyright (c) 1988-2012 AVAST Software.
http://www.avast.com

Re: [Rails-devel] Rails 1.7.7 1856 bug - CGR president's certificate

[Kevin J. P. <kp...@gm...>]

Rails developers,

I withdraw my concern.  I was directed to a rules clarification here:
http://users.stargate.net/~jerkich/1856clar.html.

- Kevin

On Mon, Jul 2, 2012 at 12:08 PM, Kevin J. Price <kp...@gm...> wrote:

> Rails developers,
>
> I believe there is a bug in the 1856 configuration for the CGR president's
> share.
>
> It looks like the game is configured so that the President's certificate
> counts as a single certificate, even if the CGR issues its second set of
> shares.
>
> The rules are admittedly slightly ambiguous on this, but I'm fairly
> certain the intent is that each certificate, including the president's
> certificate, counts as half a cert.
>
> Do you agree that this is a bug, or are you interpreting the rules
> otherwise?
>
> Assuming you agree that this is a bug, I believe fixing this is a simple
> as editing line 24 rails/data/1856/CompanyManager.xml, which currently
> reads:
>
> <Certificate type="President" shares="2" certificateCount="1"/>
>
> However, I do not know if that would fix an existing game or only a new
> game.
>
> Thanks,
>
>   Kevin Price
>
> --
> Kevin J. Price  <kp...@gm...>
> "God is a comic playing to an audience that's afraid to laugh."
>



-- 
Kevin J. Price  <kp...@gm...>
"God is a comic playing to an audience that's afraid to laugh."

Re: [Rails-devel] Rails 2.0: The item hierarchy

[Stefan F. <ste...@we...>]

Hi Erik,
glad to see that you like some of the refactoring goals...
I hope I will be able to make you jump boats at some point in time in 
the foreseeable future.
Stefan

On 06/30/2012 10:43 AM, Erik Vos wrote:
> Hi Stefan,
>
> This looks great.  How to find unrelated objects has been a major problem
> all the time, and your approach finally fixes that in a consistent way.
>
> I'm really looking forward to Rails 2.0!
>
> Erik.
>
>
>> -----Original Message-----
>> From: Stefan Frey [mailto:ste...@we...]
>> Sent: Saturday, June 30, 2012 7:30 AM
>> To: Development list for Rails: an 18xx game
>> Subject: [Rails-devel] Rails 2.0: The item hierarchy
>>
>> Another but hopefully the final update to the new Item hierarchy in Rails
> 2.0.
>>
>> The current iterations is simpler and closer to what we have in Rails 1.x,
> but
>> still powerful.
>>
>> An implementation is already there, but some major testing is still
> required.
>>
>> So what is the core idea?
>> One issue (especially with having more games added) is that is not easy to
>> access all objects of a Rails game from anywhere in the code. However this
> is
>> needed especially for the specialized classes that cover the (more or less
>> obscure) rules that pop up in various 18xx games: For those it cannot be
>> predicted which parts of the game might interact.
>>
>> To achieve this, every object (read: every Rails java object, which
> includes all
>> game objects) is part of a tree hierarchy: To ensure this every
> (non-utility)
>> class in Rails is derived from the Interface "Item".
>> It requires the definition of a parent (Item) and an id (String).
>>
>> To locate an item there can be special nodes defined by the Interface
>> "Context", which extends Item. Every Item gets stored inside a lookup
> table
>> of the closest Context up the tree.
>> An abstract class implementation of a Context is the "Manager".
>>
>> The top node is a special class "Root" which itself an extension of
> Manager. It
>> serves as the "Super"-Context of all Items.
>> (It might change its name into "GameManager" later, but this is already
>> used).
>>
>> A concrete example:
>> The 1830 Company "B&M" is an Item with the CompanyManager as parent,
>> which acts as the closest Context here. So one could locate B&M by asking
>> companyManager.locate("B&M").
>> Another possibility is to ask the root.locate("companies/B&M"), if
> companies
>> itself has the root as parent.
>>
>> Relation to the State mechanisms:
>> The Root itself contains a StateManager which is responsible for handling
> the
>> changes of the States (those variables which can change during the game
>> progress).
>>
>> An important feature of the object tree is that the parent/id definitions
> are
>> not states themselves (thus cannot change), however the lookup tables
>> inside the Context are States themselves and can thus change without
>> breaking the undo mechanism.
>>
>> Stefan
>>
>>
> ----------------------------------------------------------------------------
> --
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and threat
>> landscape has changed and how IT managers can respond. Discussions will
>> include endpoint security, mobile security and the latest in malware
> threats.
>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Rails 1.7.7 1856 bug - CGR president's certificate

[Kevin J. P. <kp...@gm...>]

Rails developers,

I believe there is a bug in the 1856 configuration for the CGR president's
share.

It looks like the game is configured so that the President's certificate
counts as a single certificate, even if the CGR issues its second set of
shares.

The rules are admittedly slightly ambiguous on this, but I'm fairly certain
the intent is that each certificate, including the president's certificate,
counts as half a cert.

Do you agree that this is a bug, or are you interpreting the rules
otherwise?

Assuming you agree that this is a bug, I believe fixing this is a simple as
editing line 24 rails/data/1856/CompanyManager.xml, which currently reads:

<Certificate type="President" shares="2" certificateCount="1"/>

However, I do not know if that would fix an existing game or only a new
game.

Thanks,

  Kevin Price

-- 
Kevin J. Price  <kp...@gm...>
"God is a comic playing to an audience that's afraid to laugh."

Re: [Rails-devel] How to Display additional Information in the StatusWindow..?

[Stefan F. <ste...@we...>]

Martin:
regardless if you want to display the number of free slots or only use 
it for internal book-keeping you need a state-type variable.
Otherwise you will run into undo-problems.

To have an updating display you need to create an observable model-type 
object which delivers that information to the display element after
each update.

So using an fixed-length array is not a solution.
To solve the state issue I propose the following solutions:

A) As the par prices of companies are already state-variables the number 
of free slots could be derived without adding another state variable. 
This is an easy solution if you only check the number of free slots at 
the time of choosing a new par price.

B) Or you could use a HashMapState<Integer, Integer>  variable which has 
the par prices as keys and the the number of available slots as values.
A disadvantage of this approach is that you have to change every code 
location that assigns par prices, something that is not necessary for A.
(Most likely there is only one, but better check).

To solve the observable issue:

A) If you want to make this observable you have to write your own 
subclass of ModelObject.
Then you have to make this ModelObject dependent on the par price state 
variables of all companies in 1880 at initialization time.

B) The HashMapState itself is a sub-class of ModelObject, thus it is a 
ModelObject already.

In Rails2.0 the State/Model mechanisms will be easier to use and more 
powerful, however they are not 100% compatible, so it will need some 
manual changes anyway.

Stefan

On 06/30/2012 10:41 PM, Dr. Martin Brumm wrote:
> Hi Erik, Brett, Stefan,
>
> i would like to display the parslots (in 1880 there are a number of
> ParPrices each with an fixed amount of slots available) and their
> current Status (occupied or not and if occupied by whom).
>
> At start those slots are unoccupied and get occupied upon Starting a
> Major Corporation. The player is able to choose the ParPrice and the
> “ParSlot” to determine the position of his company in the operational order.
>
> So from what I have seen this would require a new Model to be observed ?
> Even though it’s an Array with a predetermined length.
>
> Is that the right way, or is there an easier way to handle that ? J
>
> Regrds,
>
> Martin
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] How to Display additional Information in the 1880 Stockmarket pane/StatusWindow..?

[Dr. M. B. <dr....@t-...>]

Hi John & Chris,

 

The information from a coneceptual standpoint should go on the StockMarket
pane.

 

IN the Stautswindow itself we already show parprice, currentprice for
simplicity reasons/overview. (That information could be gained from the
stockmarket pane also (hm why isn't the par price per company noted on the
stockmarket pane ?).

 

So should the Parslot Status be shown on the Stockmarket Pane only or also
in the StatusWindow ? And if should it be an additional Column in the
companies Price Section ? Or anyone has another idea where and how to show
that info ?

 

Regards,

Martin

 

Von: Chris Shaffer [mailto:chr...@gm...] 
Gesendet: Sonntag, 1. Juli 2012 13:32
An: Development list for Rails: an 18xx game
Betreff: Re: [Rails-devel] How to Display additional Information in the
StatusWindow..?

 

In 1880, the par value selected affects the operating order.  There are
definitely times when knowing which specific slots are vacant matters a lot.
For example, given ordering 100A, 100B, 100C, 100D, 90A, 90B... if company
100B is operating, and slot 100C is vacant, triggering a stock round means
someone can open a company in slot 100C and operate immediately.  If instead
company 100D is operating and slot 100C is vacant, triggering a stock round
doesn't open up the same opportunity.

 

Similarly, if company 100B triggers a stock round, a player might want to
buy shares in company 100D, while they might want to avoid buying shares of
company 100A.

 

A huge part of the game is manipulating the timing of the stock rounds and
the subsequent opportunities to open companies in upcoming vacant slots.


 

--
Chris

Please consider the environment before printing this e-mail.



On Sat, Jun 30, 2012 at 3:27 PM, John David Galt
<jd...@di...> wrote:

> Dr. Martin Brumm wrote:
>     i would like to display the parslots (in 1880 there are a number of
> ParPrices each with an fixed amount of slots available) and their current

> Status (occupied or not and if occupied by whom). ____

1837 has this feature too.  In the printed game it is on the stock price
chart.


On 2012-06-30 15:05, Chris Shaffer wrote:
> Why not have it be a display on the map?

Because it's unrelated to anything in the map pane.  It is a stock price and
if
displayed anywhere, I'd put it in either the status window or the stock
price
chart.

But in practical terms I don't even see a need to display it beyond the
existing
"Par" column on the status window.  The only time it will matter in the game
is
if somebody is starting a new company and some of the par prices are
unavailable
because all the slots are taken.  In which case -- just gray out those
prices in
the radio-button dialog in which the president sets the par price!


----------------------------------------------------------------------------
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

 

Re: [Rails-devel] How to Display additional Information in the StatusWindow..?

[Chris S. <chr...@gm...>]

In 1880, the par value selected affects the operating order.  There are
definitely times when knowing which specific slots are vacant matters a
lot.  For example, given ordering 100A, 100B, 100C, 100D, 90A, 90B... if
company 100B is operating, and slot 100C is vacant, triggering a stock
round means someone can open a company in slot 100C and operate
immediately.  If instead company 100D is operating and slot 100C is vacant,
triggering a stock round doesn't open up the same opportunity.

Similarly, if company 100B triggers a stock round, a player might want to
buy shares in company 100D, while they might want to avoid buying shares of
company 100A.

A huge part of the game is manipulating the timing of the stock rounds and
the subsequent opportunities to open companies in upcoming vacant slots.

--
Chris

Please consider the environment before printing this e-mail.


On Sat, Jun 30, 2012 at 3:27 PM, John David Galt <
jd...@di...> wrote:

> > Dr. Martin Brumm wrote:
> >     i would like to display the parslots (in 1880 there are a number of
> > ParPrices each with an fixed amount of slots available) and their current
> > Status (occupied or not and if occupied by whom). ____
>
> 1837 has this feature too.  In the printed game it is on the stock price
> chart.
>
> On 2012-06-30 15:05, Chris Shaffer wrote:
> > Why not have it be a display on the map?
>
> Because it's unrelated to anything in the map pane.  It is a stock price
> and if
> displayed anywhere, I'd put it in either the status window or the stock
> price
> chart.
>
> But in practical terms I don't even see a need to display it beyond the
> existing
> "Par" column on the status window.  The only time it will matter in the
> game is
> if somebody is starting a new company and some of the par prices are
> unavailable
> because all the slots are taken.  In which case -- just gray out those
> prices in
> the radio-button dialog in which the president sets the par price!
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] How to Display additional Information in the StatusWindow..?

[John D. G. <jd...@di...>]

> Dr. Martin Brumm wrote:
>     i would like to display the parslots (in 1880 there are a number of
> ParPrices each with an fixed amount of slots available) and their current
> Status (occupied or not and if occupied by whom). ____

1837 has this feature too.  In the printed game it is on the stock price chart.

On 2012-06-30 15:05, Chris Shaffer wrote:
> Why not have it be a display on the map?

Because it's unrelated to anything in the map pane.  It is a stock price and if
displayed anywhere, I'd put it in either the status window or the stock price
chart.

But in practical terms I don't even see a need to display it beyond the existing
"Par" column on the status window.  The only time it will matter in the game is
if somebody is starting a new company and some of the par prices are unavailable
because all the slots are taken.  In which case -- just gray out those prices in
the radio-button dialog in which the president sets the par price!

Re: [Rails-devel] How to Display additional Information in the StatusWindow..?

[Chris S. <chr...@gm...>]

Why not have it be a display on the map?

--
Chris

Please consider the environment before printing this e-mail.


On Sat, Jun 30, 2012 at 1:41 PM, Dr. Martin Brumm <
dr....@t-...> wrote:

> Hi Erik, Brett, Stefan,****
>
> ** **
>
> i would like to display the parslots (in 1880 there are a number of
> ParPrices each with an fixed amount of slots available) and their current
> Status (occupied or not and if occupied by whom). ****
>
> ** **
>
> At start those slots are unoccupied and get occupied upon Starting a Major
> Corporation. The player is able to choose the ParPrice and the “ParSlot” to
> determine the position of his company in the operational order.****
>
> ** **
>
> So from what I have seen this would require a new Model to be observed ?
> Even though it’s an Array with a predetermined length.****
>
> ** **
>
> Is that the right way, or is there an easier way to handle that ? J****
>
> ** **
>
> Regrds,****
>
> Martin****
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

[Rails-devel] How to Display additional Information in the StatusWindow..?

[Dr. M. B. <dr....@t-...>]

Hi Erik, Brett, Stefan,

 

i would like to display the parslots (in 1880 there are a number of
ParPrices each with an fixed amount of slots available) and their current
Status (occupied or not and if occupied by whom). 

 

At start those slots are unoccupied and get occupied upon Starting a Major
Corporation. The player is able to choose the ParPrice and the "ParSlot" to
determine the position of his company in the operational order.

 

So from what I have seen this would require a new Model to be observed ?
Even though it's an Array with a predetermined length.

 

Is that the right way, or is there an easier way to handle that ? J

 

Regrds,

Martin

Re: [Rails-devel] Rails 2.0: The item hierarchy

[Erik V. <eri...@xs...>]

Hi Stefan,

This looks great.  How to find unrelated objects has been a major problem
all the time, and your approach finally fixes that in a consistent way.

I'm really looking forward to Rails 2.0!

Erik.  


> -----Original Message-----
> From: Stefan Frey [mailto:ste...@we...]
> Sent: Saturday, June 30, 2012 7:30 AM
> To: Development list for Rails: an 18xx game
> Subject: [Rails-devel] Rails 2.0: The item hierarchy
> 
> Another but hopefully the final update to the new Item hierarchy in Rails
2.0.
> 
> The current iterations is simpler and closer to what we have in Rails 1.x,
but
> still powerful.
> 
> An implementation is already there, but some major testing is still
required.
> 
> So what is the core idea?
> One issue (especially with having more games added) is that is not easy to
> access all objects of a Rails game from anywhere in the code. However this
is
> needed especially for the specialized classes that cover the (more or less
> obscure) rules that pop up in various 18xx games: For those it cannot be
> predicted which parts of the game might interact.
> 
> To achieve this, every object (read: every Rails java object, which
includes all
> game objects) is part of a tree hierarchy: To ensure this every
(non-utility)
> class in Rails is derived from the Interface "Item".
> It requires the definition of a parent (Item) and an id (String).
> 
> To locate an item there can be special nodes defined by the Interface
> "Context", which extends Item. Every Item gets stored inside a lookup
table
> of the closest Context up the tree.
> An abstract class implementation of a Context is the "Manager".
> 
> The top node is a special class "Root" which itself an extension of
Manager. It
> serves as the "Super"-Context of all Items.
> (It might change its name into "GameManager" later, but this is already
> used).
> 
> A concrete example:
> The 1830 Company "B&M" is an Item with the CompanyManager as parent,
> which acts as the closest Context here. So one could locate B&M by asking
> companyManager.locate("B&M").
> Another possibility is to ask the root.locate("companies/B&M"), if
companies
> itself has the root as parent.
> 
> Relation to the State mechanisms:
> The Root itself contains a StateManager which is responsible for handling
the
> changes of the States (those variables which can change during the game
> progress).
> 
> An important feature of the object tree is that the parent/id definitions
are
> not states themselves (thus cannot change), however the lookup tables
> inside the Context are States themselves and can thus change without
> breaking the undo mechanism.
> 
> Stefan
> 
>
----------------------------------------------------------------------------
--
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and threat
> landscape has changed and how IT managers can respond. Discussions will
> include endpoint security, mobile security and the latest in malware
threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

[Rails-devel] Rails 2.0: The item hierarchy

[Stefan F. <ste...@we...>]

Another but hopefully the final update to the new Item hierarchy in 
Rails 2.0.

The current iterations is simpler and closer to what we have in Rails 
1.x, but still powerful.

An implementation is already there, but some major testing is still 
required.

So what is the core idea?
One issue (especially with having more games added) is that is not easy 
to access all objects of a Rails game from anywhere in the code. However 
this is needed especially for the specialized classes that cover the 
(more or less obscure) rules that pop up in various 18xx games: For 
those it cannot be predicted which parts of the game might interact.

To achieve this, every object (read: every Rails java object, which 
includes all game objects) is part of a tree hierarchy: To ensure this 
every (non-utility) class in Rails is derived from the Interface "Item". 
It requires the definition of a parent (Item) and an id (String).

To locate an item there can be special nodes defined by the Interface 
"Context", which extends Item. Every Item gets stored inside a lookup 
table of the closest Context up the tree.
An abstract class implementation of a Context is the "Manager".

The top node is a special class "Root" which itself an extension of 
Manager. It serves as the "Super"-Context of all Items.
(It might change its name into "GameManager" later, but this is already 
used).

A concrete example:
The 1830 Company "B&M" is an Item with the CompanyManager as parent, 
which acts as the closest Context here. So one could locate B&M
by asking companyManager.locate("B&M").
Another possibility is to ask the root.locate("companies/B&M"), if 
companies itself has the root as parent.

Relation to the State mechanisms:
The Root itself contains a StateManager which is responsible for 
handling the changes of the States (those variables which can change 
during the game progress).

An important feature of the object tree is that the
parent/id definitions are not states themselves (thus cannot change), 
however the lookup tables inside the Context are States themselves and 
can thus change without breaking the undo mechanism.

Stefan

Re: [Rails-devel] 1870 patch and questions

[Erik V. <eri...@xs...>]

I have applied your patch, and have also applied the new method of
configuring two yellow tiles to 1870 (for 18EU, it had already been changed
in the 'master' repo branch).

Phase 2 is now defined as:

<Phase name="2" realName="1">
	<Tiles colour="yellow">
	                <Lays companyType="Public" colour="yellow"
number="2"/>
	</Tiles>
	<OperatingRounds number="1"/>
	<Trains tradingAllowed="yes"/>
</Phase>

But I can't test this, so I must leave that to you.

(BTW all phase properties are automatically copied to 'higher' phases,
unless changed explicitly).

Erik.


> -----Original Message-----
> From: John David Galt [mailto:jd...@di...]
> Sent: Monday, June 25, 2012 12:00 AM
> To: rai...@li...
> Subject: [Rails-devel] 1870 patch and questions
> 
> 1. This patch is to allow the private company tokens to be laid.
> 
> (I realize that someone else is working on 1870, and if this isn't welcome
I'll
> stop.  I'm doing it more to teach myself the code than anything else.)
> 
> 2. I haven't yet figured out how to let the major companies lay two tiles
in
> their first turn.  CompanyManager.xml does have
> 
>         <TileLays>
>                 <Number colour="yellow" phase="1,2,3,4,5,6,7,8"
number="2"/>
>         </TileLays>
> 
> which seems to work in 18EU; I haven't figured out why it fails in 1870.
> 
> 3. How do I go about getting 1837 added to the "prototype" list so I can
see
> how it behaves so far (since I can't seem to get it to build on Windows)?

Re: [Rails-devel] 1870 patch and questions

[Stefan F. <ste...@we...>]

Further comments:
1) Actually there was nobody working on 1870 for quite some time.
My initial trigger to start rails2.0 was the intention to have a better 
foundation for adding the changes required for 1870 (especially for 
price protection and destination runs).

3) The latest releases were based on the code in the rails1.7.x branch.
The 1837 patches were applied to the rails master branch and will be 
included in the next major release (1.8.0). If you checkout the master 
branch you will see 1837 listed as "in development".

Seems that there are several labels for that (some others are 
"prototype"s, some are "not playable" and 1880 is already almost playable.

If there is the demand, I can make a build of the master branch 
available on the rails webpage. The build and upload process is fully 
automated so there is hardly any effort involved from my side.

However as Martin pointed out there most other developers have a Windows 
setup as well, so it should be possible to track down those issues. I 
wonder how you developed and tested your patches without a working 
environment?

Stefan




On 06/25/2012 12:00 AM, John David Galt wrote:
> 1. This patch is to allow the private company tokens to be laid.
>
> (I realize that someone else is working on 1870, and if this isn't welcome I'll
> stop.  I'm doing it more to teach myself the code than anything else.)
>
> 2. I haven't yet figured out how to let the major companies lay two tiles in their
> first turn.  CompanyManager.xml does have
>
>          <TileLays>
>                  <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/>
>          </TileLays>
>
> which seems to work in 18EU; I haven't figured out why it fails in 1870.
>
> 3. How do I go about getting 1837 added to the "prototype" list so I can see how
> it behaves so far (since I can't seem to get it to build on Windows)?
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] 1870 patch and questions

[<Dr....@t-...>]

Hi John, 

	1837 is in the List as in development (at least under 1.7.x ) ? 

	And i can start it out of the development tree ? 

	Can you give some more specific infos about not being able to build
it on windows ? (whats the behaviour, error) 

	Regards Martin 

	P.s. i use Eclipse and Netbeans and have been able to build Rails on
Windows on both IDEs ?  

	  Von: John David Galt <jd...@di...>
 An: rai...@li...
 Betreff: [Rails-devel] 1870 patch and questions
 Datum: Mon, 25 Jun 2012 00:00:00 +0200

 1. This patch is to allow the private company tokens to be laid.

 (I realize that someone else is working on 1870, and if this isn't
welcome I'll
 stop.  I'm doing it more to teach myself the code than anything
else.)

 2. I haven't yet figured out how to let the major companies lay two
tiles in their
 first turn.  CompanyManager.xml does have

 <TileLays>
 <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/>
 </TileLays>

 which seems to work in 18EU; I haven't figured out why it fails in
1870.

 3. How do I go about getting 1837 added to the "prototype" list so I
can see how
 it behaves so far (since I can't seem to get it to build on Windows)?

Re: [Rails-devel] 1870 patch and questions

[<Dr....@t-...>]

Hi John, 

	that code in CompanyManager.xml is outdated. 

	The Definition is in Game.xmlfor 18EU

	    <Component name="PhaseManager" class="rails.game.PhaseManager">
        <Phase name="2">
            <Tiles colour="yellow">
                <Lays companyType="Minor" colour="yellow" number="2"
occurrences="1"/>
                <Lays companyType="Minor" colour="green" number="0"/>
                <Lays companyType="Minor" colour="brown" number="0"/>
                <Lays companyType="Minor" colour="grey" number="0"/>
            </Tiles>
            <OperatingRounds number="2"/>
            <Trains tradingAllowed="yes"/>
        </Phase>
        <Phase name="3">
            <Tiles colour="yellow,green"/>
            <Trains released="P"/>
        </Phase>
        <Phase name="4">
            <Trains rusted="2" limitStep="2"/>
        </Phase>
        <Phase name="5">
            <Tiles colour="yellow,green,brown"/>
            <Trains limitStep="3"/>
            <OffBoardRevenue step="2"/>
        </Phase>
        <Phase name="6">
            <Trains rusted="3"/>
        </Phase>
        <Phase name="8">
            <Tiles colour="yellow,green,brown,grey"/>
            <Trains rusted="4"/>
        </Phase> 

	So my current understanding is that you would have to define 

	<Lays companyType="Major" colour="yellow" number="2"/> for each phase
where that should be valid. 

	But on a side note to EriK why do we define the other colour lays
(green, brown, grey) in Phase 2 ? This seems irrelevant ? 

Regards, 

	Martin 

	  Von: John David Galt <jd...@di...>
 An: rai...@li...
 Betreff: [Rails-devel] 1870 patch and questions
 Datum: Mon, 25 Jun 2012 00:00:00 +0200

 1. This patch is to allow the private company tokens to be laid.

 (I realize that someone else is working on 1870, and if this isn't
welcome I'll
 stop.  I'm doing it more to teach myself the code than anything
else.)

 2. I haven't yet figured out how to let the major companies lay two
tiles in their
 first turn.  CompanyManager.xml does have

 <TileLays>
 <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/>
 </TileLays>

 which seems to work in 18EU; I haven't figured out why it fails in
1870.

 3. How do I go about getting 1837 added to the "prototype" list so I
can see how
 it behaves so far (since I can't seem to get it to build on Windows)?

[Rails-devel] 1870 patch and questions

[John D. G. <jd...@di...>]

1. This patch is to allow the private company tokens to be laid.

(I realize that someone else is working on 1870, and if this isn't welcome I'll
stop.  I'm doing it more to teach myself the code than anything else.)

2. I haven't yet figured out how to let the major companies lay two tiles in their
first turn.  CompanyManager.xml does have

        <TileLays>
                <Number colour="yellow" phase="1,2,3,4,5,6,7,8" number="2"/>
        </TileLays>

which seems to work in 18EU; I haven't figured out why it fails in 1870.

3. How do I go about getting 1837 added to the "prototype" list so I can see how
it behaves so far (since I can't seem to get it to build on Windows)?

Re: [Rails-devel] Bank size at start in game report

[Stefan F. <ste...@we...>]

OK I will fix that in the Rails1.7.x branch.
The fix will trigger an update for all test game reports.

On 06/17/2012 12:28 PM, Erik Vos wrote:
> No.  I suppose the bank size report has somehow moved downwards, until after
> player money has been distributed. Moving it back would be more logical, and
> probably fix this problem as well.
>
>> -----Original Message-----
>> From: Stefan Frey [mailto:ste...@we...]
>> Sent: Sunday, June 17, 2012 12:07 PM
>> To: Development list for Rails: an 18xx game
>> Subject: [Rails-devel] Bank size at start in game report
>>
>> Erik:
>> just starting a game for testing I realized that the game reports shows
>>
>>> (**)Game is 1830.
>>> Player 1 is T1.
>>> Player 2 is T2.
>>> Player 3 is T3.
>>> Each player receives $800 from the Bank.
>>> The Bank has $9600.
>>> Start of phase 2.
>>> Bank size is $9600
>>>   ================ Start of initial round ================
>>> T1 has the Priority Deal
>>
>> Is there any reason that the Bank size is reported to be identical to the
>> amount in the bank instead of the total bank size?
>>
>> Stefan
>>
>>
> ----------------------------------------------------------------------------
> --
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and threat
>> landscape has changed and how IT managers can respond. Discussions will
>> include endpoint security, mobile security and the latest in malware
> threats.
>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bank size at start in game report

[Erik V. <eri...@xs...>]

No.  I suppose the bank size report has somehow moved downwards, until after
player money has been distributed. Moving it back would be more logical, and
probably fix this problem as well.

> -----Original Message-----
> From: Stefan Frey [mailto:ste...@we...]
> Sent: Sunday, June 17, 2012 12:07 PM
> To: Development list for Rails: an 18xx game
> Subject: [Rails-devel] Bank size at start in game report
> 
> Erik:
> just starting a game for testing I realized that the game reports shows
> 
> > (**)Game is 1830.
> > Player 1 is T1.
> > Player 2 is T2.
> > Player 3 is T3.
> > Each player receives $800 from the Bank.
> > The Bank has $9600.
> > Start of phase 2.
> > Bank size is $9600
> >  ================ Start of initial round ================
> > T1 has the Priority Deal
> 
> Is there any reason that the Bank size is reported to be identical to the
> amount in the bank instead of the total bank size?
> 
> Stefan
> 
>
----------------------------------------------------------------------------
--
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and threat
> landscape has changed and how IT managers can respond. Discussions will
> include endpoint security, mobile security and the latest in malware
threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

[Rails-devel] Bank size at start in game report

[Stefan F. <ste...@we...>]

Erik:
just starting a game for testing I realized that the game reports shows

> (**)Game is 1830.
> Player 1 is T1.
> Player 2 is T2.
> Player 3 is T3.
> Each player receives $800 from the Bank.
> The Bank has $9600.
> Start of phase 2.
> Bank size is $9600
>  ================ Start of initial round ================
> T1 has the Priority Deal

Is there any reason that the Bank size is reported to be identical to 
the amount in the bank instead of the total bank size?

Stefan

Re: [Rails-devel] Download Release 1.7.7

[Stefan F. <ste...@we...>]

Hi Volker,
thanks for the info. Fixed.

Uploading is fully automated inside the ant-script, which reported a 
successful build, so it seems that  broken uploads get not reported 
correctly, either due to a bug of ant, rsync or the sourceforge server.

Stefan



On 06/17/2012 11:50 AM, Schnell, Volker wrote:
> Hi,
>
> the Zip-file on sourcrforge is broken (only 753 KB). the TAR-file is ok.
>
> Greetings Volker
>

[Rails-devel] Download Release 1.7.7

[Schnell, V. <vol...@ar...>]

Hi,

the Zip-file on sourcrforge is broken (only 753 KB). the TAR-file is ok.

Greetings Volker

-- 
Volker Schnell
email: vol...@ar...
homepage: home.arcor.de\volker_schnell