rails-devel — List for discussion of Rails development

[Rails-devel] End game.

[brett l. <wak...@gm...>]

To allow the end game conditions to be detected, I'm changing the
return types to various cash transferring methods from void to
boolean.

This seems to be the easiest way of detecting the end of the game.

One thing to note:   I'm not including logic into CashHolder that will
prevent the transaction from completing, I'm simply inserting a check
that, if the transaction results in the cash value being reduced to
zero or below, we're returning a false value that can be looked for by
anyone calling the addCash() methods.

It is going to be up to certain CashHolders to detect whether they are
allowed to go negative or not.  I'm fairly certain, most of those who
should be doing this, are already doing it this way.


---Brett.

Re: [Rails-devel] Screen messages

[brett l. <wak...@gm...>]

I finally got a chance to check out the changes...

Overall, I like the helper text bar. It's exactly what the UI was needing.

More comments below...


On 2/2/06, Erik Vos <eri...@hc...> wrote:
> I have committed stuff around messages to be displayed during the game.
> For now, during the OR only. Aspects are:
>
> 1. A new, low line near the top of the OR Window, in which one-line messa=
ges
> are displayed
> about what the player can do at each moment in the game. Currently, this
> message line
> disappears between token laying and train buying; I don't understand why,
> but that will no doubt be sorted out in due time.


Looks like it doesn't disappear completely, it just gets resized very
very small.

I suspect we may need a more formal layout for the ORWindow than
BoxLayout.  As painful as GridBag is to deal with, it provides the
most control.


> 2. The messages are internationalised by defining these in a
> language-dependent
> properties file. The default file is LocalisedText.properties. Versions f=
or
> any
> language/country can be added with names like LocalisedText_en_US.propert=
ies
> or LocalisedText_fr.properties.
> In the code, localised messages can be obtained by calling
> Game.getText(messageKey).
>

Uh oh.  You've let the genie out of the bottle. ;-)

Now we're going to have to go through and internationalize all of our strin=
gs.

There's a few new people to the list... this would be a GREAT project
for a newbie. It would provide them a good opportunity to learn their
way around our code.


>
> 3. Messages about special properties that can be exercised will be added
> later,
> I propose in a somewhat lighter colour.
>
> 4. The tile and token laying steps are now explicitly defined (in HexMap)=
,
> and the messages are directly related to these steps. The code is somewha=
t
> reorganised around these steps.
>

I saw this...  I'm not sure I completely agree with the implementation deta=
ils.

I think it may be time to move toward using AbstractActions rather
than static integers to interact with the state of the model.


---Brett.

[Rails-devel] Screen messages

[Erik V. <eri...@hc...>]

I have committed stuff around messages to be displayed during the game.
For now, during the OR only. Aspects are:

1. A new, low line near the top of the OR Window, in which one-line messages
are displayed
about what the player can do at each moment in the game. Currently, this
message line
disappears between token laying and train buying; I don't understand why,
but that will no doubt be sorted out in due time.

2. The messages are internationalised by defining these in a
language-dependent
properties file. The default file is LocalisedText.properties. Versions for
any
language/country can be added with names like LocalisedText_en_US.properties
or LocalisedText_fr.properties.
In the code, localised messages can be obtained by calling
Game.getText(messageKey).

3. Messages about special properties that can be exercised will be added
later,
I propose in a somewhat lighter colour.

4. The tile and token laying steps are now explicitly defined (in HexMap),
and the messages are directly related to these steps. The code is somewhat
reorganised around these steps.

Erik.

[Rails-devel] New E-mail Address.

[brett l. <wak...@gm...>]

I've moved e-mail addresses.   Please update your addressbooks.

---Brett.

RE: [Rails-devel] M&H

[Brett L. <wak...@ea...>]

-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Jan 26, 2006 1:01 PM
>To: rai...@li...
>Subject: RE: [Rails-devel] M&H
>
>> >> I think we should do this same sort of thing for the other 
>> >> special abilities, especially the C&StL.  Right now, after a 
>> >> company purchases the C&StL, the UI inexplicably maintains 
>> >> the "Lay Tile" buttons after the lays it's normal tile, and 
>> >> doesn't give any sort of notification that we're allowing for 
>> >> the C&StL tile lay before moving on to laying tokens.
>> >
>> >Yes, I agree, but I have not yet found a good way to do that.
>> >
>> >Perhaps we should add a message line over the full width of the
>> >SR and OR windows in which we can show a one-line message about 
>> >what the player having the turn is supposed to do. Here we could 
>> >also add a reminder about special properties that can be exercised.
>> >
>> 
>> That would be helpful. 
>> 
>> Currently, I think we do just fine with the turn order flow. 
>> There's some minor UI cleanups I want to do, but overall I 
>> think we're doing well enough.  The only exception being that 
>> when we deviate, we need to tell the user why we're altering 
>> the normal turn order.  So, maybe a good thing to add is 
>> changing the text over the UpgradesPanel to indicate we're 
>> allowing for the C&Stl Optional Tile Lay. 
>
>That's also an option.
>In fact, I do not much like the visual appearance of the text 
>and buttons currently in the upgrades panel. I have thought of
>moving (or perhaps duplicating) these buttons to the OR buttons panel.
>It's a bit unfriendly that, if you don't want to lay a tile or
>a token, you have to click in a place far away from the other buttons.


I think the upgradesPanel is a necessary evil for tile upgrades, but not necessary for much else.   I prefer the panel over the 1830pc mechanic of clicking through the options.

We can definitely move the Token placement buttons to the OR Button Panel.

Once we do that, anytime we're not in the "lay tile" phase, we can set the upgradesPanel visibility to false, and just keep it out of the way.

>> I think that, ideally, we should just provide a button for 
>> jumping outside the normal turn order, to activate the 
>> special ability, and then return back to the normal turn 
>> order at the same point we left.
>
>Yes, that would perhaps also have been easier to implement.
>
>> Perhaps rather than a new message line, we should just set 
>> the Title on the JFrame to indicate the current stage of the 
>> turn.  That would be a bit less intrusive.  What do you think?
>
>Yes. And any special messages in the status bar?
>


Sure, or we can use the LogWindow for it.


----Brett

RE: [Rails-devel] M&H

[Erik V. <eri...@hc...>]

> >> I think we should do this same sort of thing for the other 
> >> special abilities, especially the C&StL.  Right now, after a 
> >> company purchases the C&StL, the UI inexplicably maintains 
> >> the "Lay Tile" buttons after the lays it's normal tile, and 
> >> doesn't give any sort of notification that we're allowing for 
> >> the C&StL tile lay before moving on to laying tokens.
> >
> >Yes, I agree, but I have not yet found a good way to do that.
> >
> >Perhaps we should add a message line over the full width of the
> >SR and OR windows in which we can show a one-line message about 
> >what the player having the turn is supposed to do. Here we could 
> >also add a reminder about special properties that can be exercised.
> >
> 
> That would be helpful. 
> 
> Currently, I think we do just fine with the turn order flow. 
> There's some minor UI cleanups I want to do, but overall I 
> think we're doing well enough.  The only exception being that 
> when we deviate, we need to tell the user why we're altering 
> the normal turn order.  So, maybe a good thing to add is 
> changing the text over the UpgradesPanel to indicate we're 
> allowing for the C&Stl Optional Tile Lay. 

That's also an option.
In fact, I do not much like the visual appearance of the text 
and buttons currently in the upgrades panel. I have thought of
moving (or perhaps duplicating) these buttons to the OR buttons panel.
It's a bit unfriendly that, if you don't want to lay a tile or
a token, you have to click in a place far away from the other buttons.

> I think that, ideally, we should just provide a button for 
> jumping outside the normal turn order, to activate the 
> special ability, and then return back to the normal turn 
> order at the same point we left.

Yes, that would perhaps also have been easier to implement.

> Perhaps rather than a new message line, we should just set 
> the Title on the JFrame to indicate the current stage of the 
> turn.  That would be a bit less intrusive.  What do you think?

Yes. And any special messages in the status bar?

Erik.

RE: [Rails-devel] M&H

[Brett L. <wak...@ea...>]

>> Also note: If the swap is done before the president's share 
>> is bought, this swap sets the par value for the NYC.
>
>I don't think so. The free PRR share that comes with the C&A
>does not have a price either, until the PRR is opened by
>buying the presidency. AFAIK the same holds for the NYC.
> 


Hmm... I'll doublecheck the rule book.  I'd swear I remember encountering this with 1830 pc game, and seeing that it forces you to set the par value if it's unset.


>> I finally got a chance to check out your updates. I think the 
>> extra button in the status window is perfect. It's not 
>> intrusive, but it let's the player owning the M&H know that 
>> his ability is available.
>> 
>> I think we should do this same sort of thing for the other 
>> special abilities, especially the C&StL.  Right now, after a 
>> company purchases the C&StL, the UI inexplicably maintains 
>> the "Lay Tile" buttons after the lays it's normal tile, and 
>> doesn't give any sort of notification that we're allowing for 
>> the C&StL tile lay before moving on to laying tokens.
>
>Yes, I agree, but I have not yet found a good way to do that.
>
>Perhaps we should add a message line over the full width of the
>SR and OR windows in which we can show a one-line message about 
>what the player having the turn is supposed to do. Here we could 
>also add a reminder about special properties that can be exercised.
>

That would be helpful. 

Currently, I think we do just fine with the turn order flow. There's some minor UI cleanups I want to do, but overall I think we're doing well enough.  The only exception being that when we deviate, we need to tell the user why we're altering the normal turn order.  So, maybe a good thing to add is changing the text over the UpgradesPanel to indicate we're allowing for the C&Stl Optional Tile Lay. 

I think that, ideally, we should just provide a button for jumping outside the normal turn order, to activate the special ability, and then return back to the normal turn order at the same point we left.

Perhaps rather than a new message line, we should just set the Title on the JFrame to indicate the current stage of the turn.  That would be a bit less intrusive.  What do you think?


---Brett.

RE: [Rails-devel] M&H

[Erik V. <eri...@hc...>]

> Also note: If the swap is done before the president's share 
> is bought, this swap sets the par value for the NYC.

I don't think so. The free PRR share that comes with the C&A
does not have a price either, until the PRR is opened by
buying the presidency. AFAIK the same holds for the NYC.
 
> I finally got a chance to check out your updates. I think the 
> extra button in the status window is perfect. It's not 
> intrusive, but it let's the player owning the M&H know that 
> his ability is available.
> 
> I think we should do this same sort of thing for the other 
> special abilities, especially the C&StL.  Right now, after a 
> company purchases the C&StL, the UI inexplicably maintains 
> the "Lay Tile" buttons after the lays it's normal tile, and 
> doesn't give any sort of notification that we're allowing for 
> the C&StL tile lay before moving on to laying tokens.

Yes, I agree, but I have not yet found a good way to do that.

Perhaps we should add a message line over the full width of the
SR and OR windows in which we can show a one-line message about 
what the player having the turn is supposed to do. Here we could 
also add a reminder about special properties that can be exercised.

Erik.

Re: [Rails-devel] M&H

[Brett L. <wak...@ea...>]

Also note: If the swap is done before the president's share is bought, this swap sets the par value for the NYC.

I finally got a chance to check out your updates. I think the extra button in the status window is perfect. It's not intrusive, but it let's the player owning the M&H know that his ability is available.

I think we should do this same sort of thing for the other special abilities, especially the C&StL.  Right now, after a company purchases the C&StL, the UI inexplicably maintains the "Lay Tile" buttons after the lays it's normal tile, and doesn't give any sort of notification that we're allowing for the C&StL tile lay before moving on to laying tokens.


---Brett.

-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Jan 22, 2006 4:52 PM
>To: rai...@li...
>Subject: [Rails-devel] M&H
>
>I have partially implemented the M&H special property.
>
>When starting this job, I was under the impression, that
>it could only be exercised in the owner's SR turn,
>but after checking the rules I found that the swap can
>in fact be done almost always. 
>
>To fix this, the special property needs to be set up in 
>a different way than I had in mind, and for now I will
>leave it as it is: an extra button in the Status Window
>that is visible in the owner's turn.
>
>(BTW I wonder how often this property is used in real life.
>In fact, I can't remember ever having seen it used.)
>
>Erik.
>
>
>
>
>
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
>for problems?  Stop!  Download the new AJAX search engine that makes
>searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
>_______________________________________________
>Rails-devel mailing list
>Rai...@li...
>https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] M&H

[Brett L. <wak...@ea...>]

I've used it a few different times to fill roughly the same function as the Camden & Amboy. In 1830, being able to float a company and only needing to buy 5 shares can be important, especially in a 5 or 6 player game where starting capital is a bit slim.

---Brett.

-----Original Message-----
>From: "John A. Tamplin" <ja...@ja...>
>Sent: Jan 22, 2006 3:57 PM
>To: rai...@li...
>Subject: Re: [Rails-devel] M&H
>
>On Sun, 22 Jan 2006, Erik Vos wrote:
>
>> (BTW I wonder how often this property is used in real life.
>> In fact, I can't remember ever having seen it used.)
>
>The only time I have seen it used that way is to steal the NYC from 
>someone else (ie you have 30%, the president has 40% and you go before 
>them in the stock round).  Otherwise, you get better value by buying it 
>into a company you own, although I suppose there might be a case where you 
>have no company and it is about to go away or if your company can't afford 
>to pay as much for it as a share of NYC is worth.
>
>-- 
>John A. Tamplin					ja...@ja...
>770/436-5387 HOME				4116 Manson Ave
>                 		 		Smyrna, GA  30082-3723
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
>for problems?  Stop!  Download the new AJAX search engine that makes
>searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
>_______________________________________________
>Rails-devel mailing list
>Rai...@li...
>https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] M&H

[John A. T. <ja...@ja...>]

On Sun, 22 Jan 2006, Erik Vos wrote:

> (BTW I wonder how often this property is used in real life.
> In fact, I can't remember ever having seen it used.)

The only time I have seen it used that way is to steal the NYC from 
someone else (ie you have 30%, the president has 40% and you go before 
them in the stock round).  Otherwise, you get better value by buying it 
into a company you own, although I suppose there might be a case where you 
have no company and it is about to go away or if your company can't afford 
to pay as much for it as a share of NYC is worth.

-- 
John A. Tamplin					ja...@ja...
770/436-5387 HOME				4116 Manson Ave
                 		 		Smyrna, GA  30082-3723

[Rails-devel] M&H

[Erik V. <eri...@hc...>]

I have partially implemented the M&H special property.

When starting this job, I was under the impression, that
it could only be exercised in the owner's SR turn,
but after checking the rules I found that the swap can
in fact be done almost always. 

To fix this, the special property needs to be set up in 
a different way than I had in mind, and for now I will
leave it as it is: an extra button in the Status Window
that is visible in the owner's turn.

(BTW I wonder how often this property is used in real life.
In fact, I can't remember ever having seen it used.)

Erik.

RE: [Rails-devel] M&H Special Ability?

[Brett L. <wak...@ea...>]

-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Jan 20, 2006 5:10 PM
>To: rai...@li...
>Subject: RE: [Rails-devel] M&H Special Ability?
>
>> >> I'm not seeing any way to trigger the M&H's special ability 
>> >> to be traded for a share of NYC stock.
>> >> 
>> >> Have we implemented this yet?
>> >
>> >Not yet, it's on my list as one of the next things to do,
>> >with emergency train buying and bankruptcy.
>> >
>> 
>> Perfect.   I just ran into those two items as well. ;-)
>> 
>> Near as I can tell I think those are the only items left that 
>> are preventing me from completing a game.
>
>Eh, except that the game end is not yet noticed at all.
>I suppose you can keep playing for years now.
>Sounds like a good item to finish this phase of development with!
> 
>> So, maybe now's a good time for me to start figuring out how 
>> to package things up into a single JAR. 
>
>Well, that's easy with Eclipse, but wasn't the idea to publish
>it as a JavaStart application? I vaguely remember having seen
>that the rules for that were not so simple.


I'm pretty sure that doing JNLP (Java Web-Start) requires making a JAR for the app.

Making a JAR is easy, making a working JAR is a little more involved. ;-)

There's a few things we need to fix, such as the game selector drop-down menu.


----Brett.

RE: [Rails-devel] M&H Special Ability?

[Erik V. <eri...@hc...>]

> >> I'm not seeing any way to trigger the M&H's special ability 
> >> to be traded for a share of NYC stock.
> >> 
> >> Have we implemented this yet?
> >
> >Not yet, it's on my list as one of the next things to do,
> >with emergency train buying and bankruptcy.
> >
> 
> Perfect.   I just ran into those two items as well. ;-)
> 
> Near as I can tell I think those are the only items left that 
> are preventing me from completing a game.

Eh, except that the game end is not yet noticed at all.
I suppose you can keep playing for years now.
Sounds like a good item to finish this phase of development with!
 
> So, maybe now's a good time for me to start figuring out how 
> to package things up into a single JAR. 

Well, that's easy with Eclipse, but wasn't the idea to publish
it as a JavaStart application? I vaguely remember having seen
that the rules for that were not so simple.

Erik.

RE: [Rails-devel] M&H Special Ability?

[Brett L. <wak...@ea...>]

-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Jan 20, 2006 4:32 PM
>To: rai...@li...
>Subject: RE: [Rails-devel] M&H Special Ability?
>
>> I'm not seeing any way to trigger the M&H's special ability 
>> to be traded for a share of NYC stock.
>> 
>> Have we implemented this yet?
>
>Not yet, it's on my list as one of the next things to do,
>with emergency train buying and bankruptcy.
>

Perfect.   I just ran into those two items as well. ;-)

Near as I can tell I think those are the only items left that are preventing me from completing a game.

So, maybe now's a good time for me to start figuring out how to package things up into a single JAR. 

---Brett.

RE: [Rails-devel] M&H Special Ability?

[Erik V. <eri...@hc...>]

> I'm not seeing any way to trigger the M&H's special ability 
> to be traded for a share of NYC stock.
> 
> Have we implemented this yet?

Not yet, it's on my list as one of the next things to do,
with emergency train buying and bankruptcy.

Erik.

[Rails-devel] M&H Special Ability?

[Brett L. <wak...@ea...>]

I'm not seeing any way to trigger the M&H's special ability to be traded for a share of NYC stock.

Have we implemented this yet?


---Brett.

RE: [Rails-devel] ArrayIndexOutOfBoundsException in getTrainLimit()

[Brett L. <wak...@ea...>]

Yeah... for some reason my e-mail has a bit of a transmission delay.  I sent this two days ago.

---Brett.


-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Jan 19, 2006 3:20 PM
>To: rai...@li...
>Subject: RE: [Rails-devel] ArrayIndexOutOfBoundsException in getTrainLimit()
>
>> Looking over the code... it looks like we're just not 
>> checking for the existance of a value at the designated array index.
>
>There was a check, but it was wrong (off by one, as I indicated yesterday).
>The code is a bit more compact now too.
>
>Erik.
>
>
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
>for problems?  Stop!  Download the new AJAX search engine that makes
>searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
>_______________________________________________
>Rails-devel mailing list
>Rai...@li...
>https://lists.sourceforge.net/lists/listinfo/rails-devel

RE: [Rails-devel] Stock Purchase bug found.

[Erik V. <eri...@hc...>]

> Here, I've found that we're allowing a player to buy stock of 
> a company that he's sold previously in the round.
> 
> In the below stock round, player 1 sells C&O and later buys a 
> share of C&O.

The check was there, but sales were registered on company name
and checked on the company object, so that a previois sale was
not detected. Fixed now.

Erik.

RE: [Rails-devel] ArrayIndexOutOfBoundsException in getTrainLimit()

[Erik V. <eri...@hc...>]

> Looking over the code... it looks like we're just not 
> checking for the existance of a value at the designated array index.

There was a check, but it was wrong (off by one, as I indicated yesterday).
The code is a bit more compact now too.

Erik.

[Rails-devel] Stock Purchase bug found.

[Brett L. <wak...@ea...>]

>Another good catch, and BTW thanks for all of them.
>

No problemo.  We're getting close to fixing all the bugs blocking us from completing a full game.


Here, I've found that we're allowing a player to buy stock of a company that he's sold previously in the round.

In the below stock round, player 1 sells C&O and later buys a share of C&O.

---Brett.



Start of Stock Round 5
1 has the Priority Deal
1 buys 1 share(s) (10%) of C&O from IPO for $82.
2 sells 1 shares (10%) of NYC for $90
NYC prices goes from $90 (J5) to $80 (J6)
2 sells 1 shares (10%) of PRR for $111
PRR prices goes from $111 (J3) to $100 (J4)
2 starts NYNH at 100 and buys 2 share(s) (20%) for $200.
3 sells 1 shares (10%) of C&O for $111
C&O prices goes from $111 (J3) to $100 (J4)
3 starts B&M at 100 and buys 2 share(s) (20%) for $200.
0 sells 1 shares (10%) of C&O for $100
C&O prices goes from $100 (J4) to $90 (J5)
0 starts Erie at 100 and buys 2 share(s) (20%) for $200.
1 buys 1 share(s) (10%) of C&O from Pool for $90.
2 buys 1 share(s) (10%) of NYNH from IPO for $100.
3 buys 1 share(s) (10%) of B&M from IPO for $100.
0 buys 1 share(s) (10%) of Erie from IPO for $100.
1 buys 1 share(s) (10%) of PRR from IPO for $82.
2 buys 1 share(s) (10%) of NYNH from IPO for $100.
3 buys 1 share(s) (10%) of B&M from IPO for $100.
0 buys 1 share(s) (10%) of Erie from IPO for $100.
1 sells 1 shares (10%) of C&O for $90
C&O prices goes from $90 (J5) to $80 (J6)
1 sells 1 shares (10%) of C&O for $90
C&O stays at J6
1 buys 1 share(s) (10%) of PRR from IPO for $82.
2 buys 1 share(s) (10%) of NYNH from IPO for $100.
3 buys 1 share(s) (10%) of B&M from IPO for $100.
0 buys 1 share(s) (10%) of Erie from IPO for $100.
1 buys 1 share(s) (10%) of PRR from IPO for $82.
2 buys 1 share(s) (10%) of NYNH from IPO for $100.
NYNH floats and receives $1000
3 cannot buy 1 share(s) of B&M from IPO: 3 does not have enough money
3 sells 1 shares (10%) of NYC for $80
NYC stays at J6
3 buys 1 share(s) (10%) of B&M from IPO for $100.
B&M floats and receives $1000
0 buys 1 share(s) (10%) of Erie from IPO for $100.
Erie floats and receives $1000
1 buys 1 share(s) (10%) of C&O from Pool for $80.
1 sells 1 shares (10%) of C&O for $80
C&O stays at J6
1 cannot buy 1 share(s) of C&O from Pool: 1 already bought C&O this turn
2 passes.
3 passes.
0 passes.
1 buys 1 share(s) (10%) of NYC from IPO for $76.
2 passes.
3 passes.
0 passes.
1 passes.
All players have passed, end of SR 5
Phase=3 ORs=2

[Rails-devel] ArrayIndexOutOfBoundsException in getTrainLimit()

[Brett L. <wak...@ea...>]

Looking over the code... it looks like we're just not checking for the existance of a value at the designated array index.


---Brett.


>
>It looks like all the issues with 5-trains have been fixed.  Now, there's a new issue with 6-trains:
>
>
>Start of Operating Round 6.1
>[Irrelevant parts of the round snipped out...]
>
>CPR buys 6-train from IPO for $630
>First 6-train bought
>Start of phase 6
>All 3-trains are rusted and have been removed
>D-trains now available
>java.lang.ArrayIndexOutOfBoundsException: 4
>	at game.PublicCompany.getTrainLimit(PublicCompany.java:1036)
>	at game.CompanyManager.getCompaniesWithExcessTrains(CompanyManager.java:320)
>	at ui.ORPanel.actionPerformed(ORPanel.java:924)
>	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1786)
>	at javax.swing.AbstractButton$ForwardActionEvents.actionPerformed(AbstractButton.java:1839)
>	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:420)
>	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:258)
>	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:245)
>	at java.awt.Component.processMouseEvent(Component.java:5100)
>	at java.awt.Component.processEvent(Component.java:4897)
>	at java.awt.Container.processEvent(Container.java:1569)
>	at java.awt.Component.dispatchEventImpl(Component.java:3615)
>	at java.awt.Container.dispatchEventImpl(Container.java:1627)
>	at java.awt.Component.dispatchEvent(Component.java:3477)
>	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:3483)
>	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:3198)
>	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:3128)
>	at java.awt.Container.dispatchEventImpl(Container.java:1613)
>	at java.awt.Window.dispatchEventImpl(Window.java:1606)
>	at java.awt.Component.dispatchEvent(Component.java:3477)
>	at java.awt.EventQueue.dispatchEvent(EventQueue.java:480)
>	at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:201)
>	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:151)
>	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:145)
>	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:137)
>	at java.awt.EventDispatchThread.run(EventDispatchThread.java:100)
>count = 0, total = 170
>count = 0, total = 510
>count = 0, total = 215
>
>
>

RE: [Rails-devel] Found two new bugs

[Erik V. <eri...@hc...>]

> It looks like all the issues with 5-trains have been fixed.  
> Now, there's a new issue with 6-trains:
> 
> 
> Start of Operating Round 6.1
> [Irrelevant parts of the round snipped out...]
> 
> CPR buys 6-train from IPO for $630
> First 6-train bought
> Start of phase 6
> All 3-trains are rusted and have been removed
> D-trains now available
> java.lang.ArrayIndexOutOfBoundsException: 4
> 	at game.PublicCompany.getTrainLimit(PublicCompany.java:1036)
> 	at 


Ah, the famous off-by-one error that array length is unequal
the highest index. I should have learned that by now...

Another good catch, and BTW thanks for all of them.

Erik.

[Rails-devel] Found and squashed another token bug.

[Brett L. <wak...@ea...>]

I noticed a bit of a logic error in MapHex.  I've corrected it and commited the changes. 


---Brett.

RE: [Rails-devel] Found two new bugs

[Brett L. <wak...@ea...>]

-----Original Message-----
>From: Erik Vos <eri...@hc...>
>Sent: Jan 17, 2006 3:29 PM
>To: rai...@li...
>Subject: RE: [Rails-devel] Found two new bugs
>
>> Bug 1: After buying a 5-train in OR 6.1, after the OR ends, 
>> we're returned to a stock round instead of going to OR 6.2.
>
>That was a bug in XML parsing in class Phase.
> 
>> Bug 2: The C&O is started in SR 4 for a par price of 76$, 
>> then in SR 7 you should see that player 3 buys a share of C&O 
>> from the IPO for $82."
>
>Yes, all buys were done at current price.
>Sloppy work from my side.
>One of those things that get first postponed and then forgotten.
>
>Should both be fixed now.
>


No worries.  That's why we do bug testing. :-)

It looks like all the issues with 5-trains have been fixed.  Now, there's a new issue with 6-trains:


Start of Operating Round 6.1
[Irrelevant parts of the round snipped out...]

CPR buys 6-train from IPO for $630
First 6-train bought
Start of phase 6
All 3-trains are rusted and have been removed
D-trains now available
java.lang.ArrayIndexOutOfBoundsException: 4
	at game.PublicCompany.getTrainLimit(PublicCompany.java:1036)
	at game.CompanyManager.getCompaniesWithExcessTrains(CompanyManager.java:320)
	at ui.ORPanel.actionPerformed(ORPanel.java:924)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1786)
	at javax.swing.AbstractButton$ForwardActionEvents.actionPerformed(AbstractButton.java:1839)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:420)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:258)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:245)
	at java.awt.Component.processMouseEvent(Component.java:5100)
	at java.awt.Component.processEvent(Component.java:4897)
	at java.awt.Container.processEvent(Container.java:1569)
	at java.awt.Component.dispatchEventImpl(Component.java:3615)
	at java.awt.Container.dispatchEventImpl(Container.java:1627)
	at java.awt.Component.dispatchEvent(Component.java:3477)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:3483)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:3198)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:3128)
	at java.awt.Container.dispatchEventImpl(Container.java:1613)
	at java.awt.Window.dispatchEventImpl(Window.java:1606)
	at java.awt.Component.dispatchEvent(Component.java:3477)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:480)
	at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:151)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:145)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:137)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:100)
count = 0, total = 170
count = 0, total = 510
count = 0, total = 215