rails-devel — List for discussion of Rails development

Re: [Rails-devel] Fixes & sorting

[brett l. <wak...@gm...>]

On 6/23/07, Erik Vos <eri...@hc...> wrote:
> > So...  first question I have is in the Game Status window, in the Move
> > menu, why are there two undo options?  There's "Undo" and "Undo!".
>
> The idea is that ultimately players will only be able to
> undo their own moves, but the game master will be able to undo everything.
> So the whole undo stack is kept, but players can only move between
> certain boundaries.
> Undo! simulates this master command; for now it is there mainly for testing.
> Don't expect it to work everywhere yet.
>

Ahhh...   how about we relabel it as "Master Undo (for testing)" ?



> > Last... it looks like there's an issue with Util.getStreamForFile().
> > It's not finding any of the images for me.  I'm going to try to debug
> > this.
>
> I have wrestled with that as well. I think the fix was to put all images
> in the Rails jar file. Finding property and image files clearly still needs
> work.
>

I found the problem.   there's a leading forward slash on the path
name.  it needs to be removed.


---Brett.

Re: [Rails-devel] Fixes & sorting

[Erik V. <eri...@hc...>]

> So...  first question I have is in the Game Status window, in the Move
> menu, why are there two undo options?  There's "Undo" and "Undo!".

The idea is that ultimately players will only be able to 
undo their own moves, but the game master will be able to undo everything.
So the whole undo stack is kept, but players can only move between
certain boundaries. 
Undo! simulates this master command; for now it is there mainly for testing.
Don't expect it to work everywhere yet.
 
> Next... it seems that I can't open the Map during the Start Round.
> When I select it from the Game Status window's Options menu, I get a
> ClassCastException.

Fixed.

> Last... it looks like there's an issue with Util.getStreamForFile().
> It's not finding any of the images for me.  I'm going to try to debug
> this.

I have wrestled with that as well. I think the fix was to put all images
in the Rails jar file. Finding property and image files clearly still needs
work.

Erik.

Re: [Rails-devel] Fixes & sorting

[brett l. <wak...@gm...>]

Awesome...   I fixed my classpathing issue, so now the game runs again.


So...  first question I have is in the Game Status window, in the Move
menu, why are there two undo options?  There's "Undo" and "Undo!".

Next... it seems that I can't open the Map during the Start Round.
When I select it from the Game Status window's Options menu, I get a
ClassCastException.

Last... it looks like there's an issue with Util.getStreamForFile().
It's not finding any of the images for me.  I'm going to try to debug
this.

---Brett.


On 6/18/07, Erik Vos <eri...@hc...> wrote:
> Committed some bug fixes and minor improvements to the previous commit.
>
> I have also implemented two feature requests to sort
> buyable privates and trains in selection popups such that
> those controlled by the current player come before those
> controlled by other players.
>
> Erik Vos
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Fixes & sorting

[Erik V. <eri...@hc...>]

Committed some bug fixes and minor improvements to the previous commit.

I have also implemented two feature requests to sort 
buyable privates and trains in selection popups such that
those controlled by the current player come before those
controlled by other players.

Erik Vos

[Rails-devel] StockRound changes

[Erik V. <eri...@hc...>]

I have committed the following changes:

- The StockRounds now also use PossibleAction objects as an
interface between UI and back-end. New PossibleAction subclasses
are BuyCertificate and SellShares. These allow selling or
(if in the brown zone) buying multiple shares by one action
(this also was an outstanding feature request).

- The StockRound UI has changed somewhat. The choice of the
number of shares to sell/buy can be indicated in a selection popup.
If there is no choice, this popup is replaced by a confirmation popup.
The Sell and Buy buttons, now being redundant, have been removed.

- Buttons now use ActionButton, a new subclass of JButton. 
ActionButton allows attaching a PossibleAction object, 
that will be sent to the back-end (representing the action to be executed). 
This is similar to what we already had in ClickField (a subclass of
JToggleButton).

- The now much more loose coupling between front- and back-end
should allow for easier changes to the UI or new versions of the UI.


Erik Vos
eri...@hc...
fax: 084 716 7187 

Re: [Rails-devel] Generics etc.

[brett l. <wak...@gm...>]

I don't think it necessarily needs to use Windows-style paths as just
needs to be able to specify a path name rather than just assuming it's
in the default path.

---Brett.

On 6/17/07, Erik Vos <eri...@hc...> wrote:
> I doubt if it is possible to have getResourceAsStream use
> (Windows-style) paths, but of course you can try.
> Erik.
>
> > -----Original Message-----
> > From: rai...@li...
> > [mailto:rai...@li...] On Behalf
> > Of brett lentz
> > Sent: Sunday 17 June 2007 21:02
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Generics etc.
> >
> > Yep, they're in the same directory.
> >
> > Perhaps we allow should specifying an alternate path for those config
> > files along with specifying alternate names for those files.
> >
> > ---Brett
> >
> > On 6/17/07, Erik Vos <eri...@hc...> wrote:
> > > No, but again: if it's in the classpath, it should be found.
> > > Do you have LocalisedText.properties in the same directory
> > as my.properties.
> > >
> > > In fact, I have been lying: I use the -D option because my
> > > version of my.properties is non-standard, and called
> > my_my.properties.
> > >
> > > I only pass the name, not the path, and it is found because
> > it is in the
> > > classpath.
> > >
> > > Erik.
> > >
> > > > -----Original Message-----
> > > > From: rai...@li...
> > > > [mailto:rai...@li...] On Behalf
> > > > Of brett lentz
> > > > Sent: Sunday 17 June 2007 18:33
> > > > To: Development list for Rails: an 18xx game
> > > > Subject: Re: [Rails-devel] Generics etc.
> > > >
> > > > Yep, that did it.  However, now it looks like there's a problem
> > > > locating the LocalisedText resource.   It looks like we
> > don't have a
> > > > flag to specify its location on the command-line.
> > > >
> > > >
> > > > Cmdline configfile setting = /Documents and
> > > > Settings/Brett/workspace/18xx/my.properties
> > > > Configuration file = /Documents and
> > > > Settings/Brett/workspace/18xx/my.properties
> > > > Exception in thread "AWT-EventQueue-0"
> > > > java.util.MissingResourceException: Can't find bundle for
> > base name
> > > > LocalisedText, locale en_US
> > > >       at
> > > >
> > java.util.ResourceBundle.throwMissingResourceException(Unknown Source)
> > > >       at java.util.ResourceBundle.getBundleImpl(Unknown Source)
> > > >       at java.util.ResourceBundle.getBundle(Unknown Source)
> > > >       at rails.util.LocalText.getText(LocalText.java:61)
> > > >       at rails.util.LocalText.getText(LocalText.java:27)
> > > >       at rails.game.Game.initialise(Game.java:55)
> > > >       at rails.ui.swing.Options.actionPerformed(Options.java:256)
> > > >       at
> > > > javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
> > > >       at
> > > > javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
> > > >       at
> > > > javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
> > > >       at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
> > > >       at
> > > > javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unkno
> > > > wn Source)
> > > >       at java.awt.Component.processMouseEvent(Unknown Source)
> > > >       at javax.swing.JComponent.processMouseEvent(Unknown Source)
> > > >       at java.awt.Component.processEvent(Unknown Source)
> > > >       at java.awt.Container.processEvent(Unknown Source)
> > > >       at java.awt.Component.dispatchEventImpl(Unknown Source)
> > > >       at java.awt.Container.dispatchEventImpl(Unknown Source)
> > > >       at java.awt.Component.dispatchEvent(Unknown Source)
> > > >       at
> > > > java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
> > > >       at
> > > > java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
> > > >       at
> > java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
> > > >       at java.awt.Container.dispatchEventImpl(Unknown Source)
> > > >       at java.awt.Window.dispatchEventImpl(Unknown Source)
> > > >       at java.awt.Component.dispatchEvent(Unknown Source)
> > > >       at java.awt.EventQueue.dispatchEvent(Unknown Source)
> > > >       at
> > > >
> > java.awt.EventDispatchThread.pumpOneEventForHierarchy(Unknown Source)
> > > >       at
> > > >
> > java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
> > > >       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> > > >       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> > > >       at java.awt.EventDispatchThread.run(Unknown Source)
> > > >
> > > >
> > > > ---Brett
> > > >
> > > > On 6/17/07, Erik Vos <eri...@hc...> wrote:
> > > > > BTW I remember having seen a similar thing fairly recently.
> > > > > Not sure if it was following the switch to Java 1.5, but if so,
> > > > > one theory could be that the 1.5 version of
> > getResourceAsStream()
> > > > > has problems with Windows-style file paths.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: rai...@li...
> > > > > > [mailto:rai...@li...] On Behalf
> > > > > > Of Erik Vos
> > > > > > Sent: Saturday 16 June 2007 22:31
> > > > > > To: 'Development list for Rails: an 18xx game'
> > > > > > Subject: Re: [Rails-devel] Generics etc.
> > > > > >
> > > > > > Don't know. Perhaps a classpath problem?
> > > > > >
> > > > > > I'm running it from Eclipse with VM-option
> > > > -Dconfigfile=my.properties,
> > > > > > with a classpath that includes the directory where the
> > > > configfile is
> > > > > > located.
> > > > > >
> > > > > > Erik.
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: rai...@li...
> > > > > > > [mailto:rai...@li...] On Behalf
> > > > > > > Of brett lentz
> > > > > > > Sent: Saturday 16 June 2007 21:04
> > > > > > > To: Development list for Rails: an 18xx game
> > > > > > > Subject: Re: [Rails-devel] Generics etc.
> > > > > > >
> > > > > > > I've finally gotten some free time to check out the changes.
> > > > > > > Unfortunately, it looks like I can't even start up
> > a game now...
> > > > > > >
> > > > > > >
> > > > > > > Cmdline configfile setting = C:\Documents and
> > > > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > > > Configuration file = C:\Documents and
> > > > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > > > log4j:WARN No appenders could be found for logger
> > (rails.util).
> > > > > > > log4j:WARN Please initialize the log4j system properly.
> > > > > > > Exception whilst loading properties file C:\Documents and
> > > > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > > > java.lang.NullPointerException
> > > > > > >     at
> > java.util.Properties$LineReader.readLine(Unknown Source)
> > > > > > >     at java.util.Properties.load(Unknown Source)
> > > > > > >     at rails.util.Config.load(Config.java:59)
> > > > > > >     at rails.util.Config.get(Config.java:40)
> > > > > > >     at rails.ui.swing.Options.initialize(Options.java:102)
> > > > > > >     at rails.ui.swing.Options.<init>(Options.java:214)
> > > > > > >     at
> > rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
> > > > > > >     at rails.test.GameTest.main(GameTest.java:34)
> > > > > > >
> > > > > > >
> > > > > > > Any ideas on why getResourceAsStream() is returning null?
> > > > > > >
> > > > > > >
> > > > > > > ---Brett
> > > > > > >
> > > > > > >
> > > > > > > On 6/3/07, Erik Vos <eri...@hc...> wrote:
> > > > > > > > In the past week I have parametrised most Collections
> > > > > > > > and applied quite a number of for/in loops.
> > > > > > > > Most of the Java 5 'Type Safety' warnings are gone now.
> > > > > > > > Not all of them; generics have some limitations.
> > > > > > > >
> > > > > > > > Erik Vos
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > --------------------------------------------------------------
> > > > > > > -----------
> > > > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > > > Download DB2 Express C - the FREE version of DB2
> > > > express and take
> > > > > > > > control of your XML. No limits. Just data. Click to
> > > > get it now.
> > > > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > > > _______________________________________________
> > > > > > > > Rails-devel mailing list
> > > > > > > > Rai...@li...
> > > > > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > > > > >
> > > > > > >
> > > > > > >
> > --------------------------------------------------------------
> > > > > > > -----------
> > > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > > Download DB2 Express C - the FREE version of DB2
> > > > express and take
> > > > > > > control of your XML. No limits. Just data. Click to
> > get it now.
> > > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > > _______________________________________________
> > > > > > > Rails-devel mailing list
> > > > > > > Rai...@li...
> > > > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --------------------------------------------------------------
> > > > > > -----------
> > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > Download DB2 Express C - the FREE version of DB2
> > express and take
> > > > > > control of your XML. No limits. Just data. Click to
> > get it now.
> > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > _______________________________________________
> > > > > > Rails-devel mailing list
> > > > > > Rai...@li...
> > > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > --------------------------------------------------------------
> > > > -----------
> > > > > This SF.net email is sponsored by DB2 Express
> > > > > Download DB2 Express C - the FREE version of DB2
> > express and take
> > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > http://sourceforge.net/powerbar/db2/
> > > > > _______________________________________________
> > > > > Rails-devel mailing list
> > > > > Rai...@li...
> > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > >
> > > >
> > > > --------------------------------------------------------------
> > > > -----------
> > > > This SF.net email is sponsored by DB2 Express
> > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > control of your XML. No limits. Just data. Click to get it now.
> > > > http://sourceforge.net/powerbar/db2/
> > > > _______________________________________________
> > > > Rails-devel mailing list
> > > > Rai...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > >
> > >
> > >
> > >
> > --------------------------------------------------------------
> > -----------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >
> >
> > --------------------------------------------------------------
> > -----------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Generics etc.

[Erik V. <eri...@hc...>]

I doubt if it is possible to have getResourceAsStream use 
(Windows-style) paths, but of course you can try.
Erik.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of brett lentz
> Sent: Sunday 17 June 2007 21:02
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Generics etc.
> 
> Yep, they're in the same directory.
> 
> Perhaps we allow should specifying an alternate path for those config
> files along with specifying alternate names for those files.
> 
> ---Brett
> 
> On 6/17/07, Erik Vos <eri...@hc...> wrote:
> > No, but again: if it's in the classpath, it should be found.
> > Do you have LocalisedText.properties in the same directory 
> as my.properties.
> >
> > In fact, I have been lying: I use the -D option because my
> > version of my.properties is non-standard, and called 
> my_my.properties.
> >
> > I only pass the name, not the path, and it is found because 
> it is in the
> > classpath.
> >
> > Erik.
> >
> > > -----Original Message-----
> > > From: rai...@li...
> > > [mailto:rai...@li...] On Behalf
> > > Of brett lentz
> > > Sent: Sunday 17 June 2007 18:33
> > > To: Development list for Rails: an 18xx game
> > > Subject: Re: [Rails-devel] Generics etc.
> > >
> > > Yep, that did it.  However, now it looks like there's a problem
> > > locating the LocalisedText resource.   It looks like we 
> don't have a
> > > flag to specify its location on the command-line.
> > >
> > >
> > > Cmdline configfile setting = /Documents and
> > > Settings/Brett/workspace/18xx/my.properties
> > > Configuration file = /Documents and
> > > Settings/Brett/workspace/18xx/my.properties
> > > Exception in thread "AWT-EventQueue-0"
> > > java.util.MissingResourceException: Can't find bundle for 
> base name
> > > LocalisedText, locale en_US
> > >       at
> > > 
> java.util.ResourceBundle.throwMissingResourceException(Unknown Source)
> > >       at java.util.ResourceBundle.getBundleImpl(Unknown Source)
> > >       at java.util.ResourceBundle.getBundle(Unknown Source)
> > >       at rails.util.LocalText.getText(LocalText.java:61)
> > >       at rails.util.LocalText.getText(LocalText.java:27)
> > >       at rails.game.Game.initialise(Game.java:55)
> > >       at rails.ui.swing.Options.actionPerformed(Options.java:256)
> > >       at
> > > javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
> > >       at
> > > javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
> > >       at
> > > javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
> > >       at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
> > >       at
> > > javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unkno
> > > wn Source)
> > >       at java.awt.Component.processMouseEvent(Unknown Source)
> > >       at javax.swing.JComponent.processMouseEvent(Unknown Source)
> > >       at java.awt.Component.processEvent(Unknown Source)
> > >       at java.awt.Container.processEvent(Unknown Source)
> > >       at java.awt.Component.dispatchEventImpl(Unknown Source)
> > >       at java.awt.Container.dispatchEventImpl(Unknown Source)
> > >       at java.awt.Component.dispatchEvent(Unknown Source)
> > >       at
> > > java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
> > >       at
> > > java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
> > >       at 
> java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
> > >       at java.awt.Container.dispatchEventImpl(Unknown Source)
> > >       at java.awt.Window.dispatchEventImpl(Unknown Source)
> > >       at java.awt.Component.dispatchEvent(Unknown Source)
> > >       at java.awt.EventQueue.dispatchEvent(Unknown Source)
> > >       at
> > > 
> java.awt.EventDispatchThread.pumpOneEventForHierarchy(Unknown Source)
> > >       at
> > > 
> java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
> > >       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> > >       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> > >       at java.awt.EventDispatchThread.run(Unknown Source)
> > >
> > >
> > > ---Brett
> > >
> > > On 6/17/07, Erik Vos <eri...@hc...> wrote:
> > > > BTW I remember having seen a similar thing fairly recently.
> > > > Not sure if it was following the switch to Java 1.5, but if so,
> > > > one theory could be that the 1.5 version of 
> getResourceAsStream()
> > > > has problems with Windows-style file paths.
> > > >
> > > > > -----Original Message-----
> > > > > From: rai...@li...
> > > > > [mailto:rai...@li...] On Behalf
> > > > > Of Erik Vos
> > > > > Sent: Saturday 16 June 2007 22:31
> > > > > To: 'Development list for Rails: an 18xx game'
> > > > > Subject: Re: [Rails-devel] Generics etc.
> > > > >
> > > > > Don't know. Perhaps a classpath problem?
> > > > >
> > > > > I'm running it from Eclipse with VM-option
> > > -Dconfigfile=my.properties,
> > > > > with a classpath that includes the directory where the
> > > configfile is
> > > > > located.
> > > > >
> > > > > Erik.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: rai...@li...
> > > > > > [mailto:rai...@li...] On Behalf
> > > > > > Of brett lentz
> > > > > > Sent: Saturday 16 June 2007 21:04
> > > > > > To: Development list for Rails: an 18xx game
> > > > > > Subject: Re: [Rails-devel] Generics etc.
> > > > > >
> > > > > > I've finally gotten some free time to check out the changes.
> > > > > > Unfortunately, it looks like I can't even start up 
> a game now...
> > > > > >
> > > > > >
> > > > > > Cmdline configfile setting = C:\Documents and
> > > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > > Configuration file = C:\Documents and
> > > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > > log4j:WARN No appenders could be found for logger 
> (rails.util).
> > > > > > log4j:WARN Please initialize the log4j system properly.
> > > > > > Exception whilst loading properties file C:\Documents and
> > > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > > java.lang.NullPointerException
> > > > > >     at 
> java.util.Properties$LineReader.readLine(Unknown Source)
> > > > > >     at java.util.Properties.load(Unknown Source)
> > > > > >     at rails.util.Config.load(Config.java:59)
> > > > > >     at rails.util.Config.get(Config.java:40)
> > > > > >     at rails.ui.swing.Options.initialize(Options.java:102)
> > > > > >     at rails.ui.swing.Options.<init>(Options.java:214)
> > > > > >     at 
> rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
> > > > > >     at rails.test.GameTest.main(GameTest.java:34)
> > > > > >
> > > > > >
> > > > > > Any ideas on why getResourceAsStream() is returning null?
> > > > > >
> > > > > >
> > > > > > ---Brett
> > > > > >
> > > > > >
> > > > > > On 6/3/07, Erik Vos <eri...@hc...> wrote:
> > > > > > > In the past week I have parametrised most Collections
> > > > > > > and applied quite a number of for/in loops.
> > > > > > > Most of the Java 5 'Type Safety' warnings are gone now.
> > > > > > > Not all of them; generics have some limitations.
> > > > > > >
> > > > > > > Erik Vos
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > 
> --------------------------------------------------------------
> > > > > > -----------
> > > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > > Download DB2 Express C - the FREE version of DB2
> > > express and take
> > > > > > > control of your XML. No limits. Just data. Click to
> > > get it now.
> > > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > > _______________________________________________
> > > > > > > Rails-devel mailing list
> > > > > > > Rai...@li...
> > > > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > > > >
> > > > > >
> > > > > > 
> --------------------------------------------------------------
> > > > > > -----------
> > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > Download DB2 Express C - the FREE version of DB2
> > > express and take
> > > > > > control of your XML. No limits. Just data. Click to 
> get it now.
> > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > _______________________________________________
> > > > > > Rails-devel mailing list
> > > > > > Rai...@li...
> > > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > > >
> > > > >
> > > > >
> > > > > --------------------------------------------------------------
> > > > > -----------
> > > > > This SF.net email is sponsored by DB2 Express
> > > > > Download DB2 Express C - the FREE version of DB2 
> express and take
> > > > > control of your XML. No limits. Just data. Click to 
> get it now.
> > > > > http://sourceforge.net/powerbar/db2/
> > > > > _______________________________________________
> > > > > Rails-devel mailing list
> > > > > Rai...@li...
> > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > >
> > > >
> > > >
> > > >
> > > --------------------------------------------------------------
> > > -----------
> > > > This SF.net email is sponsored by DB2 Express
> > > > Download DB2 Express C - the FREE version of DB2 
> express and take
> > > > control of your XML. No limits. Just data. Click to get it now.
> > > > http://sourceforge.net/powerbar/db2/
> > > > _______________________________________________
> > > > Rails-devel mailing list
> > > > Rai...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > >
> > >
> > > --------------------------------------------------------------
> > > -----------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >
> >
> >
> > 
> --------------------------------------------------------------
> -----------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] Generics etc.

[brett l. <wak...@gm...>]

Yep, they're in the same directory.

Perhaps we allow should specifying an alternate path for those config
files along with specifying alternate names for those files.

---Brett

On 6/17/07, Erik Vos <eri...@hc...> wrote:
> No, but again: if it's in the classpath, it should be found.
> Do you have LocalisedText.properties in the same directory as my.properties.
>
> In fact, I have been lying: I use the -D option because my
> version of my.properties is non-standard, and called my_my.properties.
>
> I only pass the name, not the path, and it is found because it is in the
> classpath.
>
> Erik.
>
> > -----Original Message-----
> > From: rai...@li...
> > [mailto:rai...@li...] On Behalf
> > Of brett lentz
> > Sent: Sunday 17 June 2007 18:33
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Generics etc.
> >
> > Yep, that did it.  However, now it looks like there's a problem
> > locating the LocalisedText resource.   It looks like we don't have a
> > flag to specify its location on the command-line.
> >
> >
> > Cmdline configfile setting = /Documents and
> > Settings/Brett/workspace/18xx/my.properties
> > Configuration file = /Documents and
> > Settings/Brett/workspace/18xx/my.properties
> > Exception in thread "AWT-EventQueue-0"
> > java.util.MissingResourceException: Can't find bundle for base name
> > LocalisedText, locale en_US
> >       at
> > java.util.ResourceBundle.throwMissingResourceException(Unknown Source)
> >       at java.util.ResourceBundle.getBundleImpl(Unknown Source)
> >       at java.util.ResourceBundle.getBundle(Unknown Source)
> >       at rails.util.LocalText.getText(LocalText.java:61)
> >       at rails.util.LocalText.getText(LocalText.java:27)
> >       at rails.game.Game.initialise(Game.java:55)
> >       at rails.ui.swing.Options.actionPerformed(Options.java:256)
> >       at
> > javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
> >       at
> > javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
> >       at
> > javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
> >       at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
> >       at
> > javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unkno
> > wn Source)
> >       at java.awt.Component.processMouseEvent(Unknown Source)
> >       at javax.swing.JComponent.processMouseEvent(Unknown Source)
> >       at java.awt.Component.processEvent(Unknown Source)
> >       at java.awt.Container.processEvent(Unknown Source)
> >       at java.awt.Component.dispatchEventImpl(Unknown Source)
> >       at java.awt.Container.dispatchEventImpl(Unknown Source)
> >       at java.awt.Component.dispatchEvent(Unknown Source)
> >       at
> > java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
> >       at
> > java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
> >       at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
> >       at java.awt.Container.dispatchEventImpl(Unknown Source)
> >       at java.awt.Window.dispatchEventImpl(Unknown Source)
> >       at java.awt.Component.dispatchEvent(Unknown Source)
> >       at java.awt.EventQueue.dispatchEvent(Unknown Source)
> >       at
> > java.awt.EventDispatchThread.pumpOneEventForHierarchy(Unknown Source)
> >       at
> > java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
> >       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> >       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> >       at java.awt.EventDispatchThread.run(Unknown Source)
> >
> >
> > ---Brett
> >
> > On 6/17/07, Erik Vos <eri...@hc...> wrote:
> > > BTW I remember having seen a similar thing fairly recently.
> > > Not sure if it was following the switch to Java 1.5, but if so,
> > > one theory could be that the 1.5 version of getResourceAsStream()
> > > has problems with Windows-style file paths.
> > >
> > > > -----Original Message-----
> > > > From: rai...@li...
> > > > [mailto:rai...@li...] On Behalf
> > > > Of Erik Vos
> > > > Sent: Saturday 16 June 2007 22:31
> > > > To: 'Development list for Rails: an 18xx game'
> > > > Subject: Re: [Rails-devel] Generics etc.
> > > >
> > > > Don't know. Perhaps a classpath problem?
> > > >
> > > > I'm running it from Eclipse with VM-option
> > -Dconfigfile=my.properties,
> > > > with a classpath that includes the directory where the
> > configfile is
> > > > located.
> > > >
> > > > Erik.
> > > >
> > > > > -----Original Message-----
> > > > > From: rai...@li...
> > > > > [mailto:rai...@li...] On Behalf
> > > > > Of brett lentz
> > > > > Sent: Saturday 16 June 2007 21:04
> > > > > To: Development list for Rails: an 18xx game
> > > > > Subject: Re: [Rails-devel] Generics etc.
> > > > >
> > > > > I've finally gotten some free time to check out the changes.
> > > > > Unfortunately, it looks like I can't even start up a game now...
> > > > >
> > > > >
> > > > > Cmdline configfile setting = C:\Documents and
> > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > Configuration file = C:\Documents and
> > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > log4j:WARN No appenders could be found for logger (rails.util).
> > > > > log4j:WARN Please initialize the log4j system properly.
> > > > > Exception whilst loading properties file C:\Documents and
> > > > > Settings\Brett\workspace\18xx\my.properties
> > > > > java.lang.NullPointerException
> > > > >     at java.util.Properties$LineReader.readLine(Unknown Source)
> > > > >     at java.util.Properties.load(Unknown Source)
> > > > >     at rails.util.Config.load(Config.java:59)
> > > > >     at rails.util.Config.get(Config.java:40)
> > > > >     at rails.ui.swing.Options.initialize(Options.java:102)
> > > > >     at rails.ui.swing.Options.<init>(Options.java:214)
> > > > >     at rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
> > > > >     at rails.test.GameTest.main(GameTest.java:34)
> > > > >
> > > > >
> > > > > Any ideas on why getResourceAsStream() is returning null?
> > > > >
> > > > >
> > > > > ---Brett
> > > > >
> > > > >
> > > > > On 6/3/07, Erik Vos <eri...@hc...> wrote:
> > > > > > In the past week I have parametrised most Collections
> > > > > > and applied quite a number of for/in loops.
> > > > > > Most of the Java 5 'Type Safety' warnings are gone now.
> > > > > > Not all of them; generics have some limitations.
> > > > > >
> > > > > > Erik Vos
> > > > > >
> > > > > >
> > > > > >
> > > > > --------------------------------------------------------------
> > > > > -----------
> > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > Download DB2 Express C - the FREE version of DB2
> > express and take
> > > > > > control of your XML. No limits. Just data. Click to
> > get it now.
> > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > _______________________________________________
> > > > > > Rails-devel mailing list
> > > > > > Rai...@li...
> > > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > > >
> > > > >
> > > > > --------------------------------------------------------------
> > > > > -----------
> > > > > This SF.net email is sponsored by DB2 Express
> > > > > Download DB2 Express C - the FREE version of DB2
> > express and take
> > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > http://sourceforge.net/powerbar/db2/
> > > > > _______________________________________________
> > > > > Rails-devel mailing list
> > > > > Rai...@li...
> > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > >
> > > >
> > > >
> > > > --------------------------------------------------------------
> > > > -----------
> > > > This SF.net email is sponsored by DB2 Express
> > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > control of your XML. No limits. Just data. Click to get it now.
> > > > http://sourceforge.net/powerbar/db2/
> > > > _______________________________________________
> > > > Rails-devel mailing list
> > > > Rai...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > >
> > >
> > >
> > >
> > --------------------------------------------------------------
> > -----------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >
> >
> > --------------------------------------------------------------
> > -----------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Generics etc.

[Erik V. <eri...@hc...>]

No, but again: if it's in the classpath, it should be found.
Do you have LocalisedText.properties in the same directory as my.properties.

In fact, I have been lying: I use the -D option because my 
version of my.properties is non-standard, and called my_my.properties.

I only pass the name, not the path, and it is found because it is in the
classpath.

Erik.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of brett lentz
> Sent: Sunday 17 June 2007 18:33
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Generics etc.
> 
> Yep, that did it.  However, now it looks like there's a problem
> locating the LocalisedText resource.   It looks like we don't have a
> flag to specify its location on the command-line.
> 
> 
> Cmdline configfile setting = /Documents and
> Settings/Brett/workspace/18xx/my.properties
> Configuration file = /Documents and 
> Settings/Brett/workspace/18xx/my.properties
> Exception in thread "AWT-EventQueue-0"
> java.util.MissingResourceException: Can't find bundle for base name
> LocalisedText, locale en_US
> 	at 
> java.util.ResourceBundle.throwMissingResourceException(Unknown Source)
> 	at java.util.ResourceBundle.getBundleImpl(Unknown Source)
> 	at java.util.ResourceBundle.getBundle(Unknown Source)
> 	at rails.util.LocalText.getText(LocalText.java:61)
> 	at rails.util.LocalText.getText(LocalText.java:27)
> 	at rails.game.Game.initialise(Game.java:55)
> 	at rails.ui.swing.Options.actionPerformed(Options.java:256)
> 	at 
> javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
> 	at 
> javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
> 	at 
> javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
> 	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
> 	at 
> javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unkno
> wn Source)
> 	at java.awt.Component.processMouseEvent(Unknown Source)
> 	at javax.swing.JComponent.processMouseEvent(Unknown Source)
> 	at java.awt.Component.processEvent(Unknown Source)
> 	at java.awt.Container.processEvent(Unknown Source)
> 	at java.awt.Component.dispatchEventImpl(Unknown Source)
> 	at java.awt.Container.dispatchEventImpl(Unknown Source)
> 	at java.awt.Component.dispatchEvent(Unknown Source)
> 	at 
> java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
> 	at 
> java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
> 	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
> 	at java.awt.Container.dispatchEventImpl(Unknown Source)
> 	at java.awt.Window.dispatchEventImpl(Unknown Source)
> 	at java.awt.Component.dispatchEvent(Unknown Source)
> 	at java.awt.EventQueue.dispatchEvent(Unknown Source)
> 	at 
> java.awt.EventDispatchThread.pumpOneEventForHierarchy(Unknown Source)
> 	at 
> java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
> 	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> 	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
> 	at java.awt.EventDispatchThread.run(Unknown Source)
> 
> 
> ---Brett
> 
> On 6/17/07, Erik Vos <eri...@hc...> wrote:
> > BTW I remember having seen a similar thing fairly recently.
> > Not sure if it was following the switch to Java 1.5, but if so,
> > one theory could be that the 1.5 version of getResourceAsStream()
> > has problems with Windows-style file paths.
> >
> > > -----Original Message-----
> > > From: rai...@li...
> > > [mailto:rai...@li...] On Behalf
> > > Of Erik Vos
> > > Sent: Saturday 16 June 2007 22:31
> > > To: 'Development list for Rails: an 18xx game'
> > > Subject: Re: [Rails-devel] Generics etc.
> > >
> > > Don't know. Perhaps a classpath problem?
> > >
> > > I'm running it from Eclipse with VM-option 
> -Dconfigfile=my.properties,
> > > with a classpath that includes the directory where the 
> configfile is
> > > located.
> > >
> > > Erik.
> > >
> > > > -----Original Message-----
> > > > From: rai...@li...
> > > > [mailto:rai...@li...] On Behalf
> > > > Of brett lentz
> > > > Sent: Saturday 16 June 2007 21:04
> > > > To: Development list for Rails: an 18xx game
> > > > Subject: Re: [Rails-devel] Generics etc.
> > > >
> > > > I've finally gotten some free time to check out the changes.
> > > > Unfortunately, it looks like I can't even start up a game now...
> > > >
> > > >
> > > > Cmdline configfile setting = C:\Documents and
> > > > Settings\Brett\workspace\18xx\my.properties
> > > > Configuration file = C:\Documents and
> > > > Settings\Brett\workspace\18xx\my.properties
> > > > log4j:WARN No appenders could be found for logger (rails.util).
> > > > log4j:WARN Please initialize the log4j system properly.
> > > > Exception whilst loading properties file C:\Documents and
> > > > Settings\Brett\workspace\18xx\my.properties
> > > > java.lang.NullPointerException
> > > >     at java.util.Properties$LineReader.readLine(Unknown Source)
> > > >     at java.util.Properties.load(Unknown Source)
> > > >     at rails.util.Config.load(Config.java:59)
> > > >     at rails.util.Config.get(Config.java:40)
> > > >     at rails.ui.swing.Options.initialize(Options.java:102)
> > > >     at rails.ui.swing.Options.<init>(Options.java:214)
> > > >     at rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
> > > >     at rails.test.GameTest.main(GameTest.java:34)
> > > >
> > > >
> > > > Any ideas on why getResourceAsStream() is returning null?
> > > >
> > > >
> > > > ---Brett
> > > >
> > > >
> > > > On 6/3/07, Erik Vos <eri...@hc...> wrote:
> > > > > In the past week I have parametrised most Collections
> > > > > and applied quite a number of for/in loops.
> > > > > Most of the Java 5 'Type Safety' warnings are gone now.
> > > > > Not all of them; generics have some limitations.
> > > > >
> > > > > Erik Vos
> > > > >
> > > > >
> > > > >
> > > > --------------------------------------------------------------
> > > > -----------
> > > > > This SF.net email is sponsored by DB2 Express
> > > > > Download DB2 Express C - the FREE version of DB2 
> express and take
> > > > > control of your XML. No limits. Just data. Click to 
> get it now.
> > > > > http://sourceforge.net/powerbar/db2/
> > > > > _______________________________________________
> > > > > Rails-devel mailing list
> > > > > Rai...@li...
> > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > > >
> > > >
> > > > --------------------------------------------------------------
> > > > -----------
> > > > This SF.net email is sponsored by DB2 Express
> > > > Download DB2 Express C - the FREE version of DB2 
> express and take
> > > > control of your XML. No limits. Just data. Click to get it now.
> > > > http://sourceforge.net/powerbar/db2/
> > > > _______________________________________________
> > > > Rails-devel mailing list
> > > > Rai...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > >
> > >
> > >
> > > --------------------------------------------------------------
> > > -----------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >
> >
> >
> > 
> --------------------------------------------------------------
> -----------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] Generics etc.

[brett l. <wak...@gm...>]

Yep, that did it.  However, now it looks like there's a problem
locating the LocalisedText resource.   It looks like we don't have a
flag to specify its location on the command-line.


Cmdline configfile setting = /Documents and
Settings/Brett/workspace/18xx/my.properties
Configuration file = /Documents and Settings/Brett/workspace/18xx/my.properties
Exception in thread "AWT-EventQueue-0"
java.util.MissingResourceException: Can't find bundle for base name
LocalisedText, locale en_US
	at java.util.ResourceBundle.throwMissingResourceException(Unknown Source)
	at java.util.ResourceBundle.getBundleImpl(Unknown Source)
	at java.util.ResourceBundle.getBundle(Unknown Source)
	at rails.util.LocalText.getText(LocalText.java:61)
	at rails.util.LocalText.getText(LocalText.java:27)
	at rails.game.Game.initialise(Game.java:55)
	at rails.ui.swing.Options.actionPerformed(Options.java:256)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)


---Brett

On 6/17/07, Erik Vos <eri...@hc...> wrote:
> BTW I remember having seen a similar thing fairly recently.
> Not sure if it was following the switch to Java 1.5, but if so,
> one theory could be that the 1.5 version of getResourceAsStream()
> has problems with Windows-style file paths.
>
> > -----Original Message-----
> > From: rai...@li...
> > [mailto:rai...@li...] On Behalf
> > Of Erik Vos
> > Sent: Saturday 16 June 2007 22:31
> > To: 'Development list for Rails: an 18xx game'
> > Subject: Re: [Rails-devel] Generics etc.
> >
> > Don't know. Perhaps a classpath problem?
> >
> > I'm running it from Eclipse with VM-option -Dconfigfile=my.properties,
> > with a classpath that includes the directory where the configfile is
> > located.
> >
> > Erik.
> >
> > > -----Original Message-----
> > > From: rai...@li...
> > > [mailto:rai...@li...] On Behalf
> > > Of brett lentz
> > > Sent: Saturday 16 June 2007 21:04
> > > To: Development list for Rails: an 18xx game
> > > Subject: Re: [Rails-devel] Generics etc.
> > >
> > > I've finally gotten some free time to check out the changes.
> > > Unfortunately, it looks like I can't even start up a game now...
> > >
> > >
> > > Cmdline configfile setting = C:\Documents and
> > > Settings\Brett\workspace\18xx\my.properties
> > > Configuration file = C:\Documents and
> > > Settings\Brett\workspace\18xx\my.properties
> > > log4j:WARN No appenders could be found for logger (rails.util).
> > > log4j:WARN Please initialize the log4j system properly.
> > > Exception whilst loading properties file C:\Documents and
> > > Settings\Brett\workspace\18xx\my.properties
> > > java.lang.NullPointerException
> > >     at java.util.Properties$LineReader.readLine(Unknown Source)
> > >     at java.util.Properties.load(Unknown Source)
> > >     at rails.util.Config.load(Config.java:59)
> > >     at rails.util.Config.get(Config.java:40)
> > >     at rails.ui.swing.Options.initialize(Options.java:102)
> > >     at rails.ui.swing.Options.<init>(Options.java:214)
> > >     at rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
> > >     at rails.test.GameTest.main(GameTest.java:34)
> > >
> > >
> > > Any ideas on why getResourceAsStream() is returning null?
> > >
> > >
> > > ---Brett
> > >
> > >
> > > On 6/3/07, Erik Vos <eri...@hc...> wrote:
> > > > In the past week I have parametrised most Collections
> > > > and applied quite a number of for/in loops.
> > > > Most of the Java 5 'Type Safety' warnings are gone now.
> > > > Not all of them; generics have some limitations.
> > > >
> > > > Erik Vos
> > > >
> > > >
> > > >
> > > --------------------------------------------------------------
> > > -----------
> > > > This SF.net email is sponsored by DB2 Express
> > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > control of your XML. No limits. Just data. Click to get it now.
> > > > http://sourceforge.net/powerbar/db2/
> > > > _______________________________________________
> > > > Rails-devel mailing list
> > > > Rai...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > > >
> > >
> > > --------------------------------------------------------------
> > > -----------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >
> >
> >
> > --------------------------------------------------------------
> > -----------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Generics etc.

[Erik V. <eri...@hc...>]

BTW I remember having seen a similar thing fairly recently.
Not sure if it was following the switch to Java 1.5, but if so, 
one theory could be that the 1.5 version of getResourceAsStream() 
has problems with Windows-style file paths.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of Erik Vos
> Sent: Saturday 16 June 2007 22:31
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Generics etc.
> 
> Don't know. Perhaps a classpath problem?
> 
> I'm running it from Eclipse with VM-option -Dconfigfile=my.properties,
> with a classpath that includes the directory where the configfile is
> located.
> 
> Erik.
> 
> > -----Original Message-----
> > From: rai...@li... 
> > [mailto:rai...@li...] On Behalf 
> > Of brett lentz
> > Sent: Saturday 16 June 2007 21:04
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Generics etc.
> > 
> > I've finally gotten some free time to check out the changes.
> > Unfortunately, it looks like I can't even start up a game now...
> > 
> > 
> > Cmdline configfile setting = C:\Documents and
> > Settings\Brett\workspace\18xx\my.properties
> > Configuration file = C:\Documents and
> > Settings\Brett\workspace\18xx\my.properties
> > log4j:WARN No appenders could be found for logger (rails.util).
> > log4j:WARN Please initialize the log4j system properly.
> > Exception whilst loading properties file C:\Documents and
> > Settings\Brett\workspace\18xx\my.properties
> > java.lang.NullPointerException
> > 	at java.util.Properties$LineReader.readLine(Unknown Source)
> > 	at java.util.Properties.load(Unknown Source)
> > 	at rails.util.Config.load(Config.java:59)
> > 	at rails.util.Config.get(Config.java:40)
> > 	at rails.ui.swing.Options.initialize(Options.java:102)
> > 	at rails.ui.swing.Options.<init>(Options.java:214)
> > 	at rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
> > 	at rails.test.GameTest.main(GameTest.java:34)
> > 
> > 
> > Any ideas on why getResourceAsStream() is returning null?
> > 
> > 
> > ---Brett
> > 
> > 
> > On 6/3/07, Erik Vos <eri...@hc...> wrote:
> > > In the past week I have parametrised most Collections
> > > and applied quite a number of for/in loops.
> > > Most of the Java 5 'Type Safety' warnings are gone now.
> > > Not all of them; generics have some limitations.
> > >
> > > Erik Vos
> > >
> > >
> > > 
> > --------------------------------------------------------------
> > -----------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >
> > 
> > --------------------------------------------------------------
> > -----------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > 
> 
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] Generics etc.

[Erik V. <eri...@hc...>]

Don't know. Perhaps a classpath problem?

I'm running it from Eclipse with VM-option -Dconfigfile=my.properties,
with a classpath that includes the directory where the configfile is
located.

Erik.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of brett lentz
> Sent: Saturday 16 June 2007 21:04
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Generics etc.
> 
> I've finally gotten some free time to check out the changes.
> Unfortunately, it looks like I can't even start up a game now...
> 
> 
> Cmdline configfile setting = C:\Documents and
> Settings\Brett\workspace\18xx\my.properties
> Configuration file = C:\Documents and
> Settings\Brett\workspace\18xx\my.properties
> log4j:WARN No appenders could be found for logger (rails.util).
> log4j:WARN Please initialize the log4j system properly.
> Exception whilst loading properties file C:\Documents and
> Settings\Brett\workspace\18xx\my.properties
> java.lang.NullPointerException
> 	at java.util.Properties$LineReader.readLine(Unknown Source)
> 	at java.util.Properties.load(Unknown Source)
> 	at rails.util.Config.load(Config.java:59)
> 	at rails.util.Config.get(Config.java:40)
> 	at rails.ui.swing.Options.initialize(Options.java:102)
> 	at rails.ui.swing.Options.<init>(Options.java:214)
> 	at rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
> 	at rails.test.GameTest.main(GameTest.java:34)
> 
> 
> Any ideas on why getResourceAsStream() is returning null?
> 
> 
> ---Brett
> 
> 
> On 6/3/07, Erik Vos <eri...@hc...> wrote:
> > In the past week I have parametrised most Collections
> > and applied quite a number of for/in loops.
> > Most of the Java 5 'Type Safety' warnings are gone now.
> > Not all of them; generics have some limitations.
> >
> > Erik Vos
> >
> >
> > 
> --------------------------------------------------------------
> -----------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] Generics etc.

[brett l. <wak...@gm...>]

I've finally gotten some free time to check out the changes.
Unfortunately, it looks like I can't even start up a game now...


Cmdline configfile setting = C:\Documents and
Settings\Brett\workspace\18xx\my.properties
Configuration file = C:\Documents and
Settings\Brett\workspace\18xx\my.properties
log4j:WARN No appenders could be found for logger (rails.util).
log4j:WARN Please initialize the log4j system properly.
Exception whilst loading properties file C:\Documents and
Settings\Brett\workspace\18xx\my.properties
java.lang.NullPointerException
	at java.util.Properties$LineReader.readLine(Unknown Source)
	at java.util.Properties.load(Unknown Source)
	at rails.util.Config.load(Config.java:59)
	at rails.util.Config.get(Config.java:40)
	at rails.ui.swing.Options.initialize(Options.java:102)
	at rails.ui.swing.Options.<init>(Options.java:214)
	at rails.ui.swing.GameUILoader.<init>(GameUILoader.java:18)
	at rails.test.GameTest.main(GameTest.java:34)


Any ideas on why getResourceAsStream() is returning null?


---Brett


On 6/3/07, Erik Vos <eri...@hc...> wrote:
> In the past week I have parametrised most Collections
> and applied quite a number of for/in loops.
> Most of the Java 5 'Type Safety' warnings are gone now.
> Not all of them; generics have some limitations.
>
> Erik Vos
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Generics etc.

[Erik V. <eri...@hc...>]

In the past week I have parametrised most Collections
and applied quite a number of for/in loops.
Most of the Java 5 'Type Safety' warnings are gone now.
Not all of them; generics have some limitations.

Erik Vos

[Rails-devel] StartRound updated

[Erik V. <eri...@hc...>]

I have updated Start Round processing, which had long been left untouched, 
by implementing all the new ideas that we have developed over time.
These include:

- The whole start round is now fully un/redoable. 
I think I have catched all state variables in this type of round,
and embedded these in a State object.

- Model/View communication about actions is now completely done
via PossibleAction subclasses. A new subclass NullAction is used for
actions like Pass, Done, Undo and Redo (who knows a better name for this
class?).
New is, that the GUI now lets the player select one PossibleAction object 
and sends that back to the Model (possibly with added info, such as 
the selected bid value or the B&O share price).
I believe this pattern will make it easier to accomplish the future
client/server aplit.

- As in the OR, all fields are now kept up to date via the Observer pattern.

- I have found a generic way to apply the Observer pattern to calculated
values (such as player worth) by using reflection. I am using this now for
the
"free cash" amount shown in the 1830 start round window. This is calculated
by subtracting blocked cash (the total of all outstanding bids) from
the actual player cash. I have added a new class
	public CalculatedMoneyModel (Object object, String methodName)
which calls the (parameterless) method with the provided name in the
provided object.
The free cash model object is now created by the statement
	freeCash = new CalculatedMoneyModel (this, "getFreeCash");
where 'this' is the current Player object which has a method called
freeCash().
This method is then called each time the model is updated (by calling its
update() method).
This works nicely (and I have learned a new Java trick along the way).

This way we can also avoid specialized ModelObject subclasses (like
WorthModel)
for similar-looking values that are calculated in different ways.


I have tested the 1830 and 1835 start rounds fairly extensively, 
but I would not be surprised if glitches would still be found. 
Bug reports welcome, as always.


Next I will start applying the Java 1.5 generics and for/in loop
(in fact there is already one ArrayList<String>).
So, anyone compiling this code should now use at least a 1.5 (or 5.0) JDK.


Erik Vos

Re: [Rails-devel] Java 1.5

[Erik V. <eri...@hc...>]

> Now that Sun has pushed up to 1.6 (aka Java 6), I think 1.5 
> is probably
> well supported enough that I think we can increment our minimum
> requirements up to 1.5.
> 
> At this point, I can't think of a reason not to do it.

OK, I rebuilt the whole thing with Java 1.5.0.11 (I think)
and got the expected load of warnings (over 300). 
But that is OK, and all seems well otherwise.

Once the warnings start being fixed by using generics, 
there is no way back, so this is the last call for any objections.

Erik.

Re: [Rails-devel] Java 1.5

[Brett L. <wak...@gm...>]

On Mon, 2007-05-21 at 23:24 +0200, Erik Vos wrote:
> In the meantime I have been exposed to Java 1.5, 
> and I am changing my mind about a switch to that version.
> 
> In particular generics and the for/in loop appeal to me,
> and autoboxing might also be handy now that I have to wrap
> many primitives into objects on behalf on undo/redo.
> 
> The many warnings generated on unsafe use of Collections
> will be an initial annoyance, but will at the same time
> point to the places where generics should be applied.
> 
> No urgency on this switch, though.
> 
> Erik Vos
> 



Yeah, there are certainly a few nice things about Java 1.5. 

Now that Sun has pushed up to 1.6 (aka Java 6), I think 1.5 is probably
well supported enough that I think we can increment our minimum
requirements up to 1.5.

At this point, I can't think of a reason not to do it.

 ---Brett.


A motion to adjourn is always in order.

[Rails-devel] Java 1.5

[Erik V. <eri...@hc...>]

In the meantime I have been exposed to Java 1.5, 
and I am changing my mind about a switch to that version.

In particular generics and the for/in loop appeal to me,
and autoboxing might also be handy now that I have to wrap
many primitives into objects on behalf on undo/redo.

The many warnings generated on unsafe use of Collections
will be an initial annoyance, but will at the same time
point to the places where generics should be applied.

No urgency on this switch, though.

Erik Vos

Re: [Rails-devel] More undo

[brett l. <wak...@gm...>]

Awesome.   I've been meaning to try to work on Rails, but haven't been
able to find the time.

Last night I worked 22 hours...

I'll check out the new code and give it a look soon.

---Brett.


On 5/20/07, Erik Vos <eri...@hc...> wrote:
> The first quarter has been busy for me, and so it has been quiet for a
> while, but this week I have managed to resume work on this project.
>
> I'm still almost exclusively working on Undo/Redo, which, once finished,
> should also provide for Save/Load.
>
> The OR is basically done, although I don't claim that all side-effects have
> been covered yet.
> There are numerous state variables around, and it takes a lot of time to
> catch all of them.
> But the good news is that I have found a nice way to wrap such variables in
> a State (sub)class in such a way that the high-level code (in OperatingRound
> etc.) keeps simple or even can be simplified.
>
> I have just committed the whole bunch of changes.
>
> Erik Vos
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] More undo

[Erik V. <eri...@hc...>]

The first quarter has been busy for me, and so it has been quiet for a
while, but this week I have managed to resume work on this project.

I'm still almost exclusively working on Undo/Redo, which, once finished,
should also provide for Save/Load.

The OR is basically done, although I don't claim that all side-effects have
been covered yet. 
There are numerous state variables around, and it takes a lot of time to
catch all of them.
But the good news is that I have found a nice way to wrap such variables in
a State (sub)class in such a way that the high-level code (in OperatingRound
etc.) keeps simple or even can be simplified.

I have just committed the whole bunch of changes.

Erik Vos

Re: [Rails-devel] rails-package rails.ui.swing SVG revenue

[Erik V. <eri...@hc...>]

Oh yes, and I have removed crimson.jar, xalan.jar and xml-apis.jar.
These jars were corrupt (here at least), and blocked the whole move
operation.
Removing these did not harm to me.
If these are still needed, we should replace them by better copies.
Erik.


  _____  

From: Erik Vos [mailto:eri...@hc...] 
Sent: Tuesday 23 January 2007 22:56
To: 'Development list for Rails: an 18xx game'
Subject: RE: [Rails-devel] rails-package rails.ui.swing SVG revenue


OK, I have changed the package names by prepending rails.
The ui packages are now in rails.ui.swing.
This all has been committed, so expect a bulky sync next time.
My games still work, so I hope everything will be right for all of you as
well.
 
The outcommented sources in test could not be moved, so these are still in
test.
Serves them right.
 
Erik.


  _____  

From: rai...@li...
[mailto:rai...@li...] On Behalf Of brett lentz
Sent: Monday 22 January 2007 23:42
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] rails-package rails.ui.swing SVG revenue




On 1/22/07, Erik Vos <eri...@hc...> wrote: 



> > IMHO the package name changes (prepending 'rails.')
> > is worth doing now, better than later.

<snip>

> > However, I leave the decision to Brett.
> > One of us should do it, as only the two of us can commit code now. 
> > I'm prepared to do the package name changes next Sunday,
> > but it's equally fine to me drop the whole issue.
> >

> I might have time this weekend to do it. If not, it can 
> happen next weekend.

Brett, I haven't heard your verdict on this one,
and I'm staying away from the code until I know
if and when this will be done (by you or me).




Sorry if I've been unclear.

Yes, it should be done.

I've tried to find time for it, but it looks like I'm not going to be able
to get to it.  So, Erik, go ahead and do it.




---Brett. 

Re: [Rails-devel] rails-package rails.ui.swing SVG revenue

[Erik V. <eri...@hc...>]

OK, I have changed the package names by prepending rails.
The ui packages are now in rails.ui.swing.
This all has been committed, so expect a bulky sync next time.
My games still work, so I hope everything will be right for all of you as
well.
 
The outcommented sources in test could not be moved, so these are still in
test.
Serves them right.
 
Erik.


  _____  

From: rai...@li...
[mailto:rai...@li...] On Behalf Of brett lentz
Sent: Monday 22 January 2007 23:42
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] rails-package rails.ui.swing SVG revenue




On 1/22/07, Erik Vos <eri...@hc...> wrote: 



> > IMHO the package name changes (prepending 'rails.')
> > is worth doing now, better than later.

<snip>

> > However, I leave the decision to Brett.
> > One of us should do it, as only the two of us can commit code now. 
> > I'm prepared to do the package name changes next Sunday,
> > but it's equally fine to me drop the whole issue.
> >

> I might have time this weekend to do it. If not, it can 
> happen next weekend.

Brett, I haven't heard your verdict on this one,
and I'm staying away from the code until I know
if and when this will be done (by you or me).




Sorry if I've been unclear.

Yes, it should be done.

I've tried to find time for it, but it looks like I'm not going to be able
to get to it.  So, Erik, go ahead and do it.




---Brett. 

Re: [Rails-devel] rails-package rails.ui.swing SVG revenue

[Erik V. <eri...@hc...>]

OK, one of these days.
 
Erik.


  _____  

From: rai...@li...
[mailto:rai...@li...] On Behalf Of brett lentz
Sent: Monday 22 January 2007 23:42
To: Development list for Rails: an 18xx game
Subject: Re: [Rails-devel] rails-package rails.ui.swing SVG revenue




On 1/22/07, Erik Vos <eri...@hc...> wrote: 



> > IMHO the package name changes (prepending 'rails.')
> > is worth doing now, better than later.

<snip>

> > However, I leave the decision to Brett.
> > One of us should do it, as only the two of us can commit code now. 
> > I'm prepared to do the package name changes next Sunday,
> > but it's equally fine to me drop the whole issue.
> >

> I might have time this weekend to do it. If not, it can 
> happen next weekend.

Brett, I haven't heard your verdict on this one,
and I'm staying away from the code until I know
if and when this will be done (by you or me).




Sorry if I've been unclear.

Yes, it should be done.

I've tried to find time for it, but it looks like I'm not going to be able
to get to it.  So, Erik, go ahead and do it.




---Brett. 

Re: [Rails-devel] rails-package rails.ui.swing SVG revenue

[brett l. <wak...@gm...>]

On 1/22/07, Erik Vos <eri...@hc...> wrote:
>
>
>
> > > IMHO the package name changes (prepending 'rails.')
> > > is worth doing now, better than later.
>
> <snip>
>
> > > However, I leave the decision to Brett.
> > > One of us should do it, as only the two of us can commit code now.
> > > I'm prepared to do the package name changes next Sunday,
> > > but it's equally fine to me drop the whole issue.
> > >
>
> > I might have time this weekend to do it. If not, it can
> > happen next weekend.
>
> Brett, I haven't heard your verdict on this one,
> and I'm staying away from the code until I know
> if and when this will be done (by you or me).




Sorry if I've been unclear.

Yes, it should be done.

I've tried to find time for it, but it looks like I'm not going to be able
to get to it.  So, Erik, go ahead and do it.



---Brett.

Re: [Rails-devel] Comments on Patch for Disclaimer, UserConfirmation and new Main-Class

[brett l. <wak...@gm...>]

On 1/22/07, Erik Vos <eri...@hc...> wrote:
>
>
> > >I agree that in principle there should not be public variables.
> > >Do we really have sinned as much as you seem to imply?
> > >It is possible that I have not always been consistent,
> > >so I would appreciate your examples of wrong use of public etc.
> > For example, all windows (views) are public, so I guess you
> > call them direct
> > from the gmae-classes (model).
>
> No, the UI classes are in control, and pull all info from the game
> classes.
> The only exception is the use of the Observer pattern
> to keep the UI fields up to date. But here also the UI Observer
> must register at the game Observable.
>
> So it might very well be true that the UI classes don't need to be public.
> Your fault, Brett... ;-)



Yeah, I admit that I've made plenty of mistakes. :-)



----Brett.