Re: [Rails-devel] 18AL named trains

[Brett L. <wak...@gm...>]

On Sat, 2007-12-22 at 00:32 +0100, Erik Vos wrote:
> I have implemented the 18AL named trains (a special ability of the M&C
> private).
> 

Excellent!  With the holidays, I've had no time to do any coding. :(

> I have put these new subclasses in two new game-specific packages:
> rails.game.specific._18AL and rails.ui.swing.gamespecific._18AL.
> 

That looks fine to me.  "Game" is starting to look awfully out of place
in our namespace. Perhaps sometime in the future we should consider
refactoring that a little. 

Also, I'm getting rather tired of dealing with CVS's bone-headed design.
I know Sourceforge has other RCSes available (e.g. subversion). I should
probably investigate if migrating to a modern RCS would make our lives a
little easier.


> Looking back, I think the 1830 M&H/NYC swap is unique to that game, 
> so it might be an idea to take it out of the generic code. 
> I'll gladly leave that as an exercise for someone else.
> 

That's fine.  It's another good project for any potential new developers
looking for a small-ish task to gain familiarity with our code.


> BTW I think the term (and class name) SpecialProperty should perhaps be
> replaced 
> by SpecialAbility, as I find the latter a lot more descriptive.

That sounds fine by me. Java has other things it calls "properties" so,
I find that it's a little misleading to me as well.


 ---Brett.


Some of the things that live the longest in peoples' memories never
really happened.