Re: [Rails-devel] 1844 implementation and some general thoughts on Rails coding

[Stefan F. <ste...@we...>]

Martin:
the current state of mbr_2_1844 does not compile. After fixing the 
obvious typo there are even more errors.

This is in TrainManager_1844.

Some quick comments up-front:

* I do not think that we do not need special classes for Mountain or 
Tunnel companies. Most likely they will end up as PrivateCompany.
The only other idea what be to treat them as SpecialRight.

* The train conversion is mainly a change in the attributes for revenue 
calculation. Most likely there is no need to move certificates around, 
but merely some attribute state changes triggered by phase changes.
Other possibility is to use Double-Train Certificate, which Erik started 
to implement.

More to follow soon.

Stefan


On 08/30/2015 01:45 PM, Martin Brumm wrote:
> Am 30.08.2015 um 11:54 schrieb Stefan Frey:
>>
>> now that I have hopefully all changes for 2.0 done, I will focus on
>> 1844/1854.
>>
>> One thing I would like to avoid this time is the code duplication in
>> sub-classes of major Rails classes (like OperatingRound, StockRound,
>> PublicCompany etc.). This is a nightmare to support and debug.
>>
> Yes indeed :)
> https://github.com/freystef/Rails/wiki/1844
>
> I have added some points there for a start.
>
> Regards,
> Martin
>
>
>
> ------------------------------------------------------------------------------
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>