Re: [Rails-devel] Bug in StartRound Code for reducing prices

[Stefan F. <ste...@we...>]

Yes you are correct. There is some legacy mechanism that updates the 
player captions in the Game Status panel.

I will add a PlayerNameModel that provides automatic updates.

Thanks,
Stefan

On 08/28/2015 01:20 PM, Dr. Martin Brumm wrote:
> Hi Stefan,
>
> regarding the priority not working i think thats a bug of the "static"
> StartRoundWIndow internally rails keeps track of the priority and
> everything is ok.
>
> Regards,
> Martin
> Am 28.08.15 um 12:49 schrieb Stefan Frey:
>> Martin:
>> good catch!
>>
>> Yes, this does not work correctly. Interestingly this bug is also in
>> Rails 1.x, thus most likely it never worked. :-(
>>
>> A fix is in that does the following:
>>
>> * The last player passed, first stock round finished
>>
>> * The first player has to purchase the first private for free, however
>> this counts as a purchase (see 1830 rules), thus the next player to act
>> is the second player.
>>
>> The next bug to fix is that the priority deal is not updated during the
>> StartRound. This was also true in Rails 1.x.
>>
>>
>> Stefan
>>
>> PS: I always assume now that bug reports etc. refer to rails_2_develop,
>> unless you specify a different branch.
>>
>>
>> On 08/28/2015 08:11 AM, Dr. Martin Brumm wrote:
>>> Good morning,
>>> the current StartRound Code for 1830 with the price reducing contains a
>>> slight flaw.
>>>
>>> If all participants pass enough times that the price of the object in
>>> question drops to zero the object will be assigned to the last person
>>> that passed and not to the first person that faces the object with price
>>> 0 in the new round. Apparently rails doesnt handle the
>>> setcurrenttonextplayer-part in that context correctly. See the attached
>>> save game.
>>>
>>> Player Erik was the last one to pass the price dropped to zero, he got
>>> the private, but still has to pass anew for the next item in the
>>> StartRound ?...
>>>
>>> Regards,
>>> Martin
>>>
>>>
>>> ------------------------------------------------------------------------------
>>>
>>>
>>>
>>> _______________________________________________
>>> Rails-devel mailing list
>>> Rai...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> Rails-devel mailing list
>> Rai...@li...
>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>