From: Stefan F. <ste...@we...> - 2014-04-26 15:11:11
|
Seems like that calls for another CreationStrategy implementation: ForcedMerger versus FreeformMerger. From my experience now I prefer naming the classes in the core engine avoiding references to specific 18xx, as most of the time it requires knowing the title. So I prefer MergerCompany to NationalCompany. As the company templates defined in CompanyManager.xml are game specific, they can define game specific wording. Example: You have the PrivateCompany class, but define in CompanyManager.xml for 1837, that private companies are called Mountain Railways. > > Those games' mergers are very similar to each other, but not to 1835/37 > (not only no reserved shares, but no predetermination of what companies > will merge). So I think they should have their own class rather than be > included in the one I've called NationalCompany -- but maybe I should > use some other name, since CGR and Etat/SNCF are national companies too. > > |