Re: [Rails-devel] Introducing Myself

[Stefan F. <ste...@we...>]

Hi Mike,
thanks a lot for your patch. A warm welcome to Rails devel.

I have not tried your patch yet, however on first glance it should work. 
Usually it is not recommended to add such a check into one of the UI 
classes, as it breaks the UI/engine separation.

The recommended solution is to not include the action in the set of 
possible actions that is sent to the UI.
However in this case it is the only solution that avoids breaking old 
save files (which can still contain a pass in such situations).

I intend to break backward-compatibility at e.g. Rails 2.1 or 2.2 to 
remove such fixes from the code and replace them by the better ones, so 
this will be included there.

Question: I assume you still have to choose Pass manually, would it be 
possible to skip the player automatically and activate the next one?
That would be optimal.

Stefan

On 04/25/2014 06:28 AM, Michael Anastasia wrote:
> Hi all,
>
> I found rails via board game geek a few days ago. Unfortunately for me,
> I'm not familiar with most of the titles that rails has already
> implemented. Fortunately for me, my day job is programming in Java, and
> I'm kind of excited about contributing to this project. I checked out
> the repo the other day and decided to get my feet wet by trying my hand
> at one of your open bugs. Attached is my attempt to fix ticket #133,
> related to the initial auction in 18EU (which I chose because I actually
> have played that title)
>
> If there are other specific bugs or features that you think I could help
> with while getting my feet wet in the code base, please do let me know.
> Alternatively, if there's a significant flaw in my submission, I'd love
> to have your feedback.
>
> Nice to meet you,
>
> Mike Anastasia
>
>
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>