Re: [Rails-devel] Progress on 1880 merge into Rails 2.0, but still open issues

[Stefan F. <ste...@we...>]

Thanks again Martin, see further comments below.

> This has been changed by Mike, ParslotModel and ParSlotManager are used
> to achieve that now. SO yes that code is a relict imho.

OK I understand. On first glance I have to rewrite the ParSlotModel 
anyway to confirm the new Rails 2.0 approach (and move it to the 
specific_1880 package). And most likely not all of ParSlotManager is 
undo-proof.
However this will be done for the next alpha.

> Let me think again. The basic code didnt support 6 Token cities...
>
> Commit IDs: 6744707 and 49f89e3
>
> made changes to GuiHex.java to support 6 token cities.

So I manually copied the relevant code changes from a diff between 1.8.x 
and sfy_1880 into my branch. On first glance it seems to achieve the 
effects. Cherry-pick unfortunately does not work in this occasion.

> The revenue engine for sure and sometimes of course a subsequent
> sideeffect the code trying to find valid connections for the investors.
> And i am not particularly sure that the Tile laying Code suggesting new
> tiles was handling that correctly also all the time. (And yes thats in
> Rails1.8.x)

To find those problems I will need more details on concrete test cases.
Maybe you could check the alpha from today how it currently works in 
Rails 2.x.