Re: [Rails-devel] Progress on 1880 merge into Rails 2.0, but still open issues

[Martin B. <dr....@t-...>]

Am 10.04.2014 12:34, schrieb Stefan Frey:
> Martin,
> Thanks for your replies, see my comments below.
> I have attached screenshots of both rails 1/2 for comparison of the
> visual map effects.
> Stefan
>
Hi Stefan,
The list scratches attachments.
>> we defined an additional field value to the StockspaceType. Any field
>> can have an Revenue value that will be used in 1880 by a dynamic Revenue
>> Modifier to add the value on the stockmarket to the revenue generated.
>
> I did not refer to the revenue value, but to the number of slots that
> can be used to start used at a par price to start a company.
> This seems to be not correct in rails 2.0, there are the variables
> parPlace_100 ... and they are not used anywhere. Maybe they are a
> relict. And there is the parslot attribute of startspace which is
> never read? It might be correct in 1.8.7, so it most have somehow got
> lost in during the merge.
>

This has been changed by Mike, ParslotModel and ParSlotManager are used
to achieve that now. SO yes that code is a relict imho.

>>
>> Relict will be fixed tonight in map.xml
>>
>> Hm ? the svg tile for bejing looks correct ? at least in rails1.8.x its
>> the correct one. i have fixed that in my development branch..
>
> The svg is correct, however the tokens are not displayed correctly.
> Most likely there is code missing from rails1.8.7 that painted the
> tokens correctly.
>

Let me think again. The basic code didnt support 6 Token cities...

Commit IDs: 6744707 and 49f89e3

made changes to GuiHex.java to support 6 token cities.


>>
>> It should be on the right side of E11 and on the left side of E13  ?
>> Theres no tile E1 on the map ?
>
> Sorry I meant E11. It shows the blue bars left and right (the one to
> E9 is incorrect). This might be related to the double-definition (in
> E11 and both E13, this is not required), however it should not cause
> to show up incorrect.
>
>>
>> One issue: the medium city large circle around a black dot are a
>> speciality of 1880 and can be upgrade into a large city or downsized to
>> a small stop. The game engine sometimes doesnt recognise the true
>> function of the halt/stop if its upgraded or downgraded.
>
> What do you mean game engine? The revenue calculation engine? Or for
> token lays? In Rails 1.8.7 or in Rails 2?
>
The revenue engine for sure and sometimes of course a subsequent
sideeffect the code trying to find valid connections for the investors.
And i am not particularly sure that the Tile laying Code suggesting new
tiles was handling that correctly also all the time. (And yes thats in
Rails1.8.x)

>>
>> Regards
>> Martin
>>
>>
>>

Regards,
Martin