Re: [Rails-devel] Progress on 1880 merge into Rails 2.0, but still open issues

[Martin B. <dr....@t-...>]

Hi Stefan,

i'll try later or tomorrow to fix the svg and xml discrepancies as well
as the Localized Text.

Kind Regards,
Martin

Am 22.03.2014 11:27, schrieb Stefan Frey:
> I have made some more progress to remove bugs that still exist in 1880 
> from the merge into Rails 2.0. Most of them were related to the fact 
> that executed actions are checked against allowed actions.
>
> However it seems that the code base used to merge 1880 into Rails 2.0 
> did not include everything up-to Rails 1.8.7:
>
> Especially some svg tiles are missing and the xml definitions deviate.
> I do not know exactly how this could happen, as they should have been 
> identical at the start of the merge.
>
> In addition there are a lot of keys missing in LocalisedText.properties
> for 1880, which is not the case in Rails 1.8.7.
>
> An example what is missing are the svg-files for tiles 455,-9021,-9031.
>
> Those belonged to commit 3f9305 from two years ago, which was based on 
> a patch from Martin commited by Erik.
>
> However I cannot simply cherry-pick this commit, as it also contains 
> many changes to the java classes, which later on have changed again.
>
> Could anyone of you double-check what happened and give an indication 
> which patches/components are still missing?
>
> Otherwise I will simply add those files that are obviously missing (svg) 
> and will compare the *.xml definition files and LocalisedText properties 
> and edit them manually.
>
> ===> Imporant remark:
> Please keep in mind, that I will only do this once 1880. I will not do 
> this for any future game that is developed from now on under Rails 1.x.
>
> This is a lot of work to do to narrow down all those little bits and now 
> that Rails 2.0 is really close to finalize, there is no reason to keep 
> working on Rails 1.x.
>
> And I for sure do not want to repeat this experience. ;-)
>
> To make things easier, I will give more information what are best 
> practices to implement a new game in Rails 2.0. However I want to have 
> Rails 2.0 out of the door, before I seriously start writing about it.
> In the meantime best thing to do, is simply asking.
>
> Stefan
>