Re: [Rails-devel] Progress of 1880 integration to Rails 2.0 and question on StartCompany_1880

[Martin B. <dr....@t-...>]

Hi Stefan,

sorry your Right, and i am wrong. I was referring to StartRound_1880 not
StartCompany_1880.
Now why did i introduce StartCompany_1880:

To make implement a mechanismn to handly buying rights and the parslot
indices.

The call to StartCompany_1880 is in StockRound_1880 at line 204

StartCompany_1880 action = new StartCompany_1880(comp, convertedPrices);

Kind Regards,
Martin

Am 15.03.2014 20:38, schrieb Stefan Frey:
> I referred to StartCompany_1880, the action subclass of StartCompany.
> I thought that Martin meant that StartCompany_1880 was only used by
> StartRound_1880 which was later replaced by your new classes. But may
> be I am wrong...
>
>
> Michael Alexander <out...@gm...> wrote:
>
>     StartRound or StartCompany? You asked about StartCompany_1880,
>     which I believe is used in StockRound_1880...  and I don't recall
>     writing that myself - you are sure that wasn't you Martin?  :)
>
>     Mike
>
>
>     On Sat, Mar 15, 2014 at 3:10 PM, Stefan Frey<ste...@we...
>     <mailto:ste...@we...>> wrote:
>
>         Ok I believe I understand now, however I wonder how the new
>         classes are backwards compatible with the old actions. Maybe
>         Mike can give me a hint?
>
>
>         "Dr. Martin Brumm" <dr....@t-...
>         <mailto:dr....@t-...>> wrote:
>
>             The function was replaced by Startround_sequential and
>             Startround_investor_1880 startround_privates_1880 by Mike
>
>
>             Von Samsung Mobile gesendet
>
>
>             -------- Ursprüngliche Nachricht --------
>             Von: Stefan Frey
>             Datum:15.03.2014 14:27 (GMT+01:00)
>             An: "Development list for Rails: an 18xx game"
>             Betreff: Re: [Rails-devel] Progress of 1880 integration to
>             Rails 2.0 and question on StartCompany_1880
>
>             Follow up question: How was the functionality of
>             StartCompany_1880 replaced in the current version? Are
>             your save files still loadable in 1.8.7?
>             Thanks,
>             Stefan
>
>
>             "Dr. Martin Brumm" <dr....@t-...
>             <mailto:dr....@t-...>> wrote:
>
>                 StartComany_1880 is never used. The Use in save Files
>                 is an Artefact from old versions.
>
>
>
>
>                 Von Samsung-Tablet gesendet
>
>
>                 -------- Ursprüngliche Nachricht --------
>                 Von: Stefan Frey
>                 Datum:15.03.2014 11:37 (GMT+01:00)
>                 An: "Development list for Rails: an 18xx game"
>                 Betreff: [Rails-devel] Progress of 1880 integration to
>                 Rails 2.0 and question on StartCompany_1880
>
>                 Martin & Mike:
>                 I have done further steps to integrate 1880 into the
>                 rails 2.0 branch.
>                 The current state is in branch sfy_1880, which was
>                 updated today.
>                 I will write more details what have been changed later
>                 this weekend.
>
>                 However I realized something strange:
>
>                 How do you use StartCompany_1880: There is no call to
>                 one of the
>                 constructors of that action. And actions are never
>                 created dynamically,
>                 as far as I know.
>
>                 And in fact the game engine only creates StartCompany
>                 actions. However
>                 in Martins save file examples there are
>                 StartCompany_1880 actions
>                 included. This does not work in Rails 2.0, as the
>                 check if the players
>                 only execute allowed actions is active. And it checks
>                 that the actions
>                 are of the same class.
>
>                 Could shed some light on this? I had a quick glance on
>                 your rails1.8.x
>                 branch and it seems that there is neither a call to
>                 the constructors.
>                 However in Rails 1.x the test if actions are allowed
>                 was never active.
>
>                 Thanks for your help,
>                 Stefan
>