[Rails-devel] 1880 ferry revenue modifier (was: 1880 map error)

[Stefan F. <ste...@we...>]

Martin or Alexander,
most likely I have solved that issue.
Could someone provide me an 1880 test file that has a run via ferries?

It is not as difficult, but it shows that I will have to dig up and 
collect my explanations on the algorithm and the interaction with the 
modifiers.

Will provide those as soon as I am sure that my new modifier works as 
expected.

Thanks,
Stefan


On 11/28/2013 10:24 PM, Martin Brumm wrote:
> Good Evening,
>
> the problem arises from the implementation of the
> FerryConnectionModifier in the Moment.
>
> It relies on the run.getVertices() which only stores the Hexes with a
> station/City on a run.
>
> But sometimes this mechanismn stores an intermediate Hex and thus Mike's
> calculation finds that theres a water combo in between..
>
> I noticed the RevenueBonusTemplate Class in the rails.algorithmns ?
> Can we use that with a negative Bonus (Malus) ?
>
> Should we create a RevenueMalusTemplate and add that to the Code ?  Then
> Overwrite RevenueAdapter with a new Class specific for 1880 ? Or put it
> in the main class (dont know if there are other Games that use Malus ?).
>
> And then use the FerryConnection Modifier to cancel out the effects of
> the Malus ?
>
> But then again we might have to find out if on that particular vertices
> combination a malus exists....
> Probably wont save us lots of trouble, if Stefan doesnt have an idea.
>
> Other angle:
> So how can one find out which route gets used between two cities (i.e.
> determine the hexes automatically ?)
> Looking @Stefan there for clues :)
>
> Regards
> Martin
>
>
> Am 28.11.2013 02:16, schrieb Michael Alexander:
>> There are three connections that are "by ferry".  Each connection that
>> is used take $10 off the run.  What is happening now is that if a run
>> uses two or more connections, $10 is only taken off once.
>>
>>
>> On Wed, Nov 27, 2013 at 5:28 PM, Stefan Frey <ste...@we...
>> <mailto:ste...@we...>> wrote:
>>
>>     If someone explains shortly what the requirement is, I might have a
>>     proposal to solve it in time.
>>
>>     On 11/27/2013 09:31 PM, Michael Alexander wrote:
>>     > Martin,
>>     >
>>     >      I don't think I'm going to get to the fix for the multiple
>>     water
>>     > hexes by Saturday.  I will let you know for sure by Friday.
>>     >
>>     > Mike
>>
>
>