Re: [Rails-devel] Porting 1880 code to 2.0

[Martin B. <dr....@t-...>]

Am 27.11.2013 20:19, schrieb Martin Brumm:
> Am 27.11.2013 12:44, schrieb Stefan Frey:
>> Martin:
>> OK if no save file is possible, could you please forward your 18xx.log?
>> If I start an 1880 game, it starts with a StockRound, however no 
>> commands are highlighted in for the first player.
>>
>> During setup of the game there is an error raised during creation of the 
>> private company JO, related to issues by creation of BuildingPermit 
>> objects. This exception is due to the fact that the constructor of 
>> BuildingPermit is protected only, it has to be public. However there are 
>> follow-up errors in the creation of Building Permit.
>>
>> I cannot see any exception related to OperatingRoundControl_1880.
>>
>> Where and when is this class created?
>>
>> Most likely I will have to re-read the 1880 rules now ;-)
>>
>> Stefan
>>
>>
> Hi Stefan,
>
> the problem raises its head in ChangeSet.addChange at the attempt to Add
> the new Special Property with
> the key/value Pair :key   
> "/CompanyManager/Private/JO/SpecialProperty_1" (id=83)    newValue   
> AddBuildingPermit  (id=53)
>
> into the     HashMapState{uri=/items}...
>
>
> And yes i admit that there might be a number of other bugs coming up...
>
> Kind Regards,
> Martin
>
>
>
> Hi Stefan,

the problem was that the new class used a not yet defined value in its
toString()-method.

Apparently this method was declared but not used directly anywhere so
far (at least i havent found the use). But of course a non existing
reference lead to a null pointer exception.

Guess we have to check all of our new classes for the fact that now at
creation the toString() method is called :)

Regards,
Martin