Menu
▾
▴
Re: [Rails-devel] Patch to fix private company revenue
|
From: Chris S. <chr...@gm...> - 2013-08-26 13:25:35
|
Also note that a player can decline to open a company in SR1. I once saw a game where a player's first company was founded after the first T4 was purchased. -- Chris Please consider the environment before printing this e-mail. On Mon, Aug 26, 2013 at 6:24 AM, Chris Shaffer <chr...@gm...> wrote: > I've seen players open a second company several times, and seen it > taken over once. Even if a share was available, it should not be > assigned to a foreign investor, since the person taking over the > company did not found it. Here's a scenario where that might happen: > > Player 1 launches HKR, FI takes HKR share > Player 1 launches JHA, no FI share taken > Player 2 buys JHA > Player 2 buys JHA > Player 1 seeing the takeover coming sells 2 JHA; player 2 becomes > president and still no FI takes a share even though one is available. > > -- > Chris > > Please consider the environment before printing this e-mail. > > > On Mon, Aug 26, 2013 at 2:10 AM, Dr....@t-... > <Dr....@t-...> wrote: >> Hi Michael, >> >> >> >> the behaviour of the code as currently observed is wrong. According to the >> rules neither Investor should have a share of the HKR. The Investor of >> Player A holds a BCR share, Player B buys 30% to become director (thus no >> shares are available until the Phase 3). >> >> >> >> And the rules state : >> >> "As soon as the owner of the FI founds his first company (buys the directors >> certificate), one share of this company is placed on the charter of the >> foreigen investor." >> >> >> >> So the current implementation by myself is flawed :(. >> >> >> >> Your approach to fixing that sounds good, but dont forget to check the fact >> that each FI gets only one share .) >> >> >> >> Regards, >> >> Martin >> >> >> >> P.s. your changes are already committed so please fetch them first and apply >> them to your local branch, otherwise i get to many patch mismatches :) >> >> P.P.s. Thanks again ! :) >> >> >> >> >> >> >> Von: Michael Alexander <out...@gm...> >> >> An: "Dr....@t-..." <Dr....@t-...>, >> "Development list for Rails: an 18xx game" >> <rai...@li...> >> >> Betreff: Re: [Rails-devel] Patch to fix private company revenue >> >> Datum: Mon, 26 Aug 2013 08:52:30 +0200 >> >> >> >> >> >> The scenario was this: >> >> Player A bought the IG (getting the BCR). His foreign investor took a BCR >> share. He then opened the HKR at 20%. Player B (who had not yet opened a >> company) bought the remaining 30% of HKR that was available and took over >> the company. The code assumed that Player B has opened it, and gave player >> B's investor a share of HKR. >> >> My approach to fixing it (which I have coded, but isn't in the files I sent >> because I just did it) was to have the public company keep track of the >> "founder" - which was the player who bought the president's share, and to >> put another check on the Investor to only allow it to take a share if the >> current player was also the founder. >> >> Mike >> >> >> On Mon, Aug 26, 2013 at 2:45 AM, Dr....@t-... >> <Dr....@t-...> wrote: >> >> Hi Michael, >> >> >> >> thanks, i'll incorporate the patches later today. >> >> >> >> Regarding the takeover in the initial round, tht should not be possible, as >> a player will found/start a company with at least 20 percent, the FI of the >> player gets another 10, that just leaves 20 percent in the open stock (till >> the first 3 has been bought). So theres no take over possible in the initial >> round. Ergo we have a bug in there somewhere. I'll have look later tonight >> at the save file. >> >> >> >> Regards, >> >> Martin >> >> >> >> Von: Michael Alexander <out...@gm...> >> >> An: "Development list for Rails: an 18xx game" >> <rai...@li...> >> >> Betreff: Re: [Rails-devel] Patch to fix private company revenue >> >> Datum: Mon, 26 Aug 2013 05:33:47 +0200 >> >> >> >> >> >> Martin, >> >> I think these patches fix the problems I saw with price slots. I saw a few >> things (BCR didn't get a slot, for example, and I had trouble getting >> companies to open at the right prices). I ended up pulling out the ParSlot >> into it's own class(es). It didn't seem appropriate for it to be part of >> the stock market. If you could take a look at these changes and let me know >> what you think, I'd appreciate it. >> >> I also included the save game that represents as far as I can get with this >> version in the online game I'm in before I hit another problem. In the >> initial stock round, one of the players took the presidency of a company >> from another player. The game (we believe incorrectly) then puts a share of >> that company in the FI. We think because the second player didn't form the >> company (he just took it over) that it shouldn't do that. >> >> Mike >> >> >> On Sat, Aug 24, 2013 at 5:27 PM, Martin Brumm <dr....@t-...> >> wrote: >> >> Am 24.08.2013 23:19, schrieb Michael Alexander: >> >> Hi Mike, >> >> i have a preliminary version in the latest 1880_specific committed. >> >> But it still has its flaws. >> Startround uses a different numeration, this is not yet carried over to the >> main StartCompany procedure. >> The StartCompany_procedure for the priceslot still needs adjustments also. >> If you want to give it a shot, great. >> >> I have prepared a build for the BGG-Guys to use with those caveats... >> Can be found at >> https://dl.dropboxusercontent.com/u/29072620/rails-1.7.12_1880.zip >> As i dont have access to the release build mechanismn on sourceforge myself >> :) >> >> Regards, >> Martin >> >> P.s. in the archive of rails-devel theres a lot of nice information >> regarding the intended architecture by Brett, Stefan and Erik. >> >> Martin, >> >> Are you working on the price slots? I was thinking about taking a look >> at them, but I wouldn't want to step on stuff you've already written. >> >> Mike >> >> >> On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm <dr....@t-...> >> wrote: >> >> Hi Michael, >> >> thanks again, i applied the patch to 1880_specific, though i thought i had >> fixed the behaviour in the code already pushed. >> >> The second fix for StartCompany_1880 needs to be classified into the >> category : "Ouch :)". >> >> Thanks for catching it. >> >> Regards, >> Martin >> >> >> ------------------------------------------------------------------------------ >> Introducing Performance Central, a new site from SourceForge and >> AppDynamics. Performance Central is your source for news, insights, >> analysis and resources for efficient Application Performance Management. >> Visit us today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> >> >> >> ------------------------------------------------------------------------------ >> Introducing Performance Central, a new site from SourceForge and >> AppDynamics. Performance Central is your source for news, insights, >> analysis and resources for efficient Application Performance Management. >> Visit us today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> >> >> >> >> ------------------------------------------------------------------------------ >> Introducing Performance Central, a new site from SourceForge and >> AppDynamics. Performance Central is your source for news, insights, >> analysis and resources for efficient Application Performance Management. >> Visit us today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk >> _______________________________________________ >> Rails-devel mailing list >> Rai...@li... >> https://lists.sourceforge.net/lists/listinfo/rails-devel >> |
