Re: [Rails-devel] Patch to fix private company revenue

[Michael A. <out...@gm...>]

Martin,

    Are you working on the price slots?  I was thinking about taking a look
at them, but I wouldn't want to step on stuff you've already written.

Mike


On Sat, Aug 24, 2013 at 3:36 PM, Martin Brumm
<dr....@t-...>wrote:

>  Hi Michael,
>
> thanks again, i applied the patch to 1880_specific, though  i thought i
> had fixed the behaviour in the code already pushed.
>
> The second fix for StartCompany_1880 needs to be classified into the
> category : "Ouch :)".
>
> Thanks for catching it.
>
> Regards,
> Martin
> Am 24.08.2013 19:55, schrieb Michael Alexander:
>
>      Two more patches for 1880_specific.  These patches fix the following
> problems:
>
>  - During "long" auctions in the initial stock round, the player whose
> turn it is to bid next or pass can get messed up.  For example:
>
>  Player A bids $5
>  Player B bids $10
>  Player C bids $15
>  Player D passes
> Player A passes
>  Player B bids $20
>  Player C bids $25
>  Player D will now be incorrectly given a chance to bid again, and if he
> passes, the company will be awarded to Player C.
>
>  - After the IG is purchased (giving ownership to the BCR), the player who
> should start the auction on the RC is calculated incorrectly.
>
>  - If a player does not have $200, the game crashes if they try to open a
> company.
>
>
>
>
> On Sat, Aug 24, 2013 at 11:59 AM, Michael Alexander <
> out...@gm...> wrote:
>
>>  Sounds good.  Thank you for the quick response.  I'll have a few more
>> shortly. :)
>>
>>  Mike
>>
>>
>> On Sat, Aug 24, 2013 at 11:29 AM, brett lentz <bre...@gm...>wrote:
>>
>>> Patches like this work just fine. :)
>>>
>>>  I'll get this applied later today.
>>>
>>>  In general, we have two styles of contributions. We'll take patches
>>> like this and one of the committers will merge them, if approved. Second,
>>> if you'd like to do more substantial development, we're happy to grant
>>> commit access once we've seen a few patches from you.
>>>
>>>  ---Brett.
>>>
>>>
>>>  On Sat, Aug 24, 2013 at 5:56 AM, Michael Alexander <
>>> out...@gm...> wrote:
>>>
>>>>   Here is my patch to fix private company revenue in the 1880_specific
>>>> branch.  (Does this work better in the future as an attachment?)
>>>>
>>>> diff --git a/data/1880/CompanyManager.xml b/data/1880/CompanyManager.xml
>>>> index ff26af7..5934325 100644
>>>> --- a/data/1880/CompanyManager.xml
>>>> +++ b/data/1880/CompanyManager.xml
>>>> @@ -91,7 +91,7 @@
>>>>          </SpecialProperties>
>>>>      </Company>
>>>>      <Company name="JO" longname="Jeme Tien Yow Engineer Office"
>>>> type="Private"
>>>> -        basePrice="70" revenue="20">
>>>> +        basePrice="70" revenue="25">
>>>>          <!-- SpecialProperties-->
>>>>          <!-- SpecialProperty condition="ifOwnedByPlayer"
>>>> when="tileLayingStep"
>>>>              class="rails.game.specific._1880.BuildingPermit"-->
>>>> @@ -99,7 +99,7 @@
>>>>          <!--  -->/SpecialProperties-->
>>>>      </Company>
>>>>      <Company name="IG" longname="Imperial Qing Government"
>>>> type="Private"
>>>> -        basePrice="160" revenue="20">
>>>> +        basePrice="160" revenue="0">
>>>>          <Info key="ComesWithPresidency" parm="BCR,20"/>
>>>>      </Company>
>>>>      <Company name="RC" longname="Rocket Company" type="Private"
>>>> basePrice="70"
>>>>
>>>>  Thanks,  Mike
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Introducing Performance Central, a new site from SourceForge and
>>>> AppDynamics. Performance Central is your source for news, insights,
>>>> analysis and resources for efficient Application Performance Management.
>>>> Visit us today!
>>>>
>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>>>> _______________________________________________
>>>> Rails-devel mailing list
>>>> Rai...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Introducing Performance Central, a new site from SourceForge and
>>> AppDynamics. Performance Central is your source for news, insights,
>>> analysis and resources for efficient Application Performance Management.
>>> Visit us today!
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> Rails-devel mailing list
>>> Rai...@li...
>>> https://lists.sourceforge.net/lists/listinfo/rails-devel
>>>
>>>
>>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> Rails-devel mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Introducing Performance Central, a new site from SourceForge and
> AppDynamics. Performance Central is your source for news, insights,
> analysis and resources for efficient Application Performance Management.
> Visit us today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>