Re: [Rails-devel] Patch to fix private company revenue

[Martin B. <dr....@t-...>]

Am 24.08.2013 17:29, schrieb brett lentz:

Hi Brett & Alexander,

patch applied and committed to specific_1880.

Thanks Alexander.
> Patches like this work just fine. :)
>
> I'll get this applied later today.
>
> In general, we have two styles of contributions. We'll take patches
> like this and one of the committers will merge them, if approved.
> Second, if you'd like to do more substantial development, we're happy
> to grant commit access once we've seen a few patches from you.
>
> ---Brett.
>
>
> On Sat, Aug 24, 2013 at 5:56 AM, Michael Alexander
> <out...@gm... <mailto:out...@gm...>> wrote:
>
>     Here is my patch to fix private company revenue in the
>     1880_specific branch.  (Does this work better in the future as an
>     attachment?)
>
>     diff --git a/data/1880/CompanyManager.xml
>     b/data/1880/CompanyManager.xml
>     index ff26af7..5934325 100644
>     --- a/data/1880/CompanyManager.xml
>     +++ b/data/1880/CompanyManager.xml
>     @@ -91,7 +91,7 @@
>              </SpecialProperties>
>          </Company>
>          <Company name="JO" longname="Jeme Tien Yow Engineer Office"
>     type="Private"
>     -        basePrice="70" revenue="20">
>     +        basePrice="70" revenue="25">
>              <!-- SpecialProperties-->
>              <!-- SpecialProperty condition="ifOwnedByPlayer"
>     when="tileLayingStep"
>                  class="rails.game.specific._1880.BuildingPermit"-->
>     @@ -99,7 +99,7 @@
>              <!--  -->/SpecialProperties-->
>          </Company>
>          <Company name="IG" longname="Imperial Qing Government"
>     type="Private"
>     -        basePrice="160" revenue="20">
>     +        basePrice="160" revenue="0">
>              <Info key="ComesWithPresidency" parm="BCR,20"/>
>          </Company>
>          <Company name="RC" longname="Rocket Company" type="Private"
>     basePrice="70"
>
>     Thanks,  Mike
>