Re: [Rails-devel] next 1835 bug

[Erik V. <eri...@xs...>]

A check was missing on that: M1 bought a 5-train and was still considered
being operational. 
I have added a check after resuming an OR after a PR formation round
triggered by buying a train: if the operating company has closed in the
meantime (as is the case here), the turn will be finished.

It now runs well, but I was surprised to see that now the PR gets a turn. I
doubt if that is correct.
AFAIK, the PR cannot operate if any minor has both operated and merged in
that same OR. Or am I wrong here?
I vaguely remember a discussion about this issue long ago, but I'm not sure
what  the outcome was.

I also fixed a harmless error in the definition of tile -114 (Braunschweig):
an extra redundant null track, which I have removed.
Nothing pushed yet.

Erik.

> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Friday, October 12, 2012 12:13 AM
> To: vol...@ar...; 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] next 1835 bug
> 
> There is an uncatched exception on the console:
> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
> 	at
> rails.game.OperatingRound.setBuyableTrains(OperatingRound.java:3056)
> 	at
> rails.game.OperatingRound.setPossibleActions(OperatingRound.java:392)
> 	...
> The cause probably is, that the operating company that bought the train no
> longer exists whilst wrapping up its OR turn. I presume this bug has crept
in
> by some change.
> I'll try to sort it out tomorrow.
> 
> Erik
> 
> 
> > -----Original Message-----
> > From: Schnell, Volker [mailto:vol...@ar...]
> > Sent: Thursday, October 11, 2012 7:56 PM
> > To: rai...@li...
> > Subject: [Rails-devel] next 1835 bug
> >
> > Hello,
> >
> > our game have some strange options.
> > the pre Pru M1 buy the first 5-Train. Then the merger takes place und
> rails
> > stopped.
> > "done" is an option, but nothing happens. see attached file The
> > Prussian
> can
> > operate normal incl. the 5-Train. The owner of the M1 receive no
revenue.
> >
> > greetings
> >
> > Volker
> >
> > --
> > Volker Schnell
> > email: vol...@ar...
> > homepage: home.arcor.de\volker_schnell
> 
> 
> 
>
----------------------------------------------------------------------------
--
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly what is
> happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic
> at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel