Re: [Rails-devel] 1835 Pfalzbahn token lay (was Re: Minor bug, 1835, 1.7.6)

[Erik V. <eri...@xs...>]

I have fixed both A and B (pushed to master).  The below only applies to
(preprinted) tiles that have the relayBaseTokens="yes" Upgrade attribute in
TileSet.xml.  
So far, this only applies to upgrades of a yellow OO-style tile to a green
one.

In such cases, the UI code now does some additional checks:
1. If both a home token and a 'remote' token have been laid before on that
hex, the home company president gets the first turn to decide where to put
its token.
2. If a station (city) has no free spots, it is no longer offered as a
choice for token laying.
The existing code already took care, that a choice list of length one is
executed without asking.

The combination of the above checks ensures, that in the case mentioned only
the BA president gets a question asked.

As far as I could test, this works correctly for 1835 PfB on hex L6.
I was not yet able to test if the related 1830 Erie and 1856 THB home hexes
still work as before, but I have no reason to doubt that.

My commit also includes Stefan's fix for closing the PfB manually.

Erik.

> Current Rails implementation:
> A) If the Pfalz owner tries to place a token on LU/MA before the BA token
> gets laid, he first gets the choice to choose between two undefined
stations:
> Only after that selection he gets informed that he is not allowed to place
the
> token now (due to being home hex of BA).
> 
> B) Both owner of tokens get asked and both are free to choose any of the
> stations. If both choose the same station, several follow-up bugs occur
(only
> one token is shown, revenue calculation throws errors).
> This has to be changed that only the BA owner get asked, and the other
> token gets assigned accordingly.