[Rails-commits] rails/game

[Erik V. <ev...@us...>]

 rails/game/StockRound.java |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit f654b2d5744b8048d6a78a04be9b760c8acc1631
Author: Erik Vos <eri...@xs...>
Date:   Mon Jun 4 15:15:11 2012 +0200

    1856: allow selling a just bought share by the president.
    
    In theory a half-presidency share is then sold, which is allowed
    according to a clarification by Steve Thomas (backed by Bill Dixon).
    Apparently it does not matter if the presidency can actually be dumped.

diff --git a/rails/game/StockRound.java b/rails/game/StockRound.java
index 7f03de7..c4df970 100644
--- a/rails/game/StockRound.java
+++ b/rails/game/StockRound.java
@@ -479,7 +479,15 @@ public class StockRound extends Round {
                 /* In some games (1856), a just bought share may not be sold */
                 // This code ignores the possibility of different share units
                 if ((Boolean)gameManager.getGameParameter(GameDef.Parm.NO_SALE_OF_JUST_BOUGHT_CERT)
-                        && company.equals(companyBoughtThisTurnWrapper.get())) {
+                        && company.equals(companyBoughtThisTurnWrapper.get())
+                        /* An 1856 clarification by Steve Thomas (backed by Bill Dixon) states that
+                         * in this situation a half-presidency may be sold
+                         * (apparently even if a dump would otherwise not be allowed),
+                         * as long as the number of shares does not become zero.
+                         * So the rule "can't sell a just bought share" only means,
+                         * that the number of shares may not be sold down to zero.
+                         * Added 4jun2012 by EV */
+                        && number == ownedShare/shareUnit) {
                     number--;
                 }
                 if (number <= 0) continue;