Re: [Rails-devel] A question or two about the Rails XML interface.

[John D. G. <jd...@di...>]

On 2012-05-14 08:15, Erik Vos wrote:
> It turns out that we already have an <Action> tag within <Phase>, with
> attributes 'name' and 'value' (value is unused).
> This tag is currently only used for 1880.
> 
> We could modify or extend that tag, e.g. like
> <Action name="formStateRR" value="KK;may_start"/>, allowing value to have a
> sequence of values.
> Perhaps it is nicer to replace 'value' by more meaningful attributes, such
> as 'company' for actions that affect a company, and 'step' to specify an
> action step.

Good idea.  I'll go with
   <Action name="formStateRR" company="KK" step="may_start"/>

>> While I'm on the subject of CompanyManager.xml -- I suggest adding an
>> option like
>>         <ExchangesForPresidency company="K1"> to the declarations of state
>> companies, to point back to the minor company that becomes the
>> president's share (and thus starts the formation of the state company).
>> This way, StateRRFormationRound (see below) needs only the name of the
>> state company as an argument.

> Hmm, I would rather expect a tag named <ExchangesForPresidency> as part of
> the declaration for K1.

No reason we can't have that also.  I notice that
<ExchangeForShare president="yes"> already exists.

> Alternatively, <StartsMajor> or something like that might even be a better
> name.
> But maybe your approach is more practical.  However, I would propose a less
> confusing name (at least, to me) like <Precursor> or <StartingMinor>.
 
OK, <StartingMinor> it is.