Re: [Rails-devel] Bug Report 1830 Rails1.7.2

[Stefan F. <ste...@we...>]

Erik,
sorry have not seen your comment. Was that embedded in a previous mail 
from you? Can you forward me the test case to avoid for me going back as 
I am pretty busy currently.
I want to check why there is no rectangle returned. I guess that it 
occurs if the company has no route. Was that a hidden (thus having no 
impact on gameplay) error?
Thanks,
Stefan


On 05/08/2012 12:06 PM, Erik Vos wrote:
> Absent any further comments, I have now committed and pushed this fix into
> master.
> Erik.
>
>> -----Original Message-----
>> From: Erik Vos [mailto:eri...@xs...]
>> Sent: Thursday, May 03, 2012 5:14 PM
>> To: 'Development list for Rails: an 18xx game'
>> Subject: Re: [Rails-devel] Bug Report 1830 Rails1.7.2
>>
>> Stefan, below I'm returning one sub-issue back to you...
>
>>> 5. Click "done".
>>
>> And indeed an exception appears on the console:
>> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
>> 	at
>> rails.ui.swing.MapPanel.scrollPaneShowRectangle(MapPanel.java:113)
>> 	at
>> rails.ui.swing.ORUIManager.setMapRelatedActions(ORUIManager.java:238)
>> 	at
>> rails.ui.swing.ORUIManager.updateStatus(ORUIManager.java:1677)
>> 	at
>> rails.ui.swing.ORUIManager.updateStatus(ORUIManager.java:1520)
>> 	at
>> rails.ui.swing.GameUIManager.updateUI(GameUIManager.java:562)
>> 	at
>> rails.ui.swing.GameUIManager.processAction(GameUIManager.java:329)
>> 	at rails.ui.swing.ORWindow.process(ORWindow.java:229)
>> 	at
>> rails.ui.swing.ORUIManager.processAction(ORUIManager.java:434)
>> 	at rails.ui.swing.ORPanel.actionPerformed(ORPanel.java:912)
>>
>> ORUIManager line 238 has:
>>
>>                          mapPanel.scrollPaneShowRectangle(
>>                                  NetworkVertex.getVertexMapCoverage(map,
>> companyGraph.vertexSet()));
>>
>> and the rectangle passed is null, which causes the exception.
>> As a quick fix I'm now checking the rectangle in
>> MapPanel.scrollPaneShowRectangle, and do nothing if it is null.
>> This fixes the immediate problem.
>>
>> I don't know if NetworkVertex.getVertexMapCoverage() returning a null
>> rectangle should be considered a bug.  I must leave that to Stefan.
>>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel