From: Erik V. <eri...@xs...> - 2012-04-08 22:47:26
|
That's right. Thanks. Erik. > -----Original Message----- > From: Stefan Frey [mailto:ste...@we...] > Sent: Monday, April 09, 2012 12:37 AM > To: Development list for Rails: an 18xx game > Subject: Re: [Rails-devel] Bug: 18EU, 1.7.0 > > Erik: > I assume you are referring to the following commit: > > 3b3c7 Allow 'pic' attribute in Hex definition in Map.xml. > > with follow-ups: > e6477 Fixed picture ID determination, which did not work for upgrade > 5b0f1 Fix to previous commit > > I have not picked them as I did not realize that they there required for the > Goderich fix. I will pick them into Rails1.7.x. > > Stefan > > > On 04/08/2012 11:40 PM, Erik Vos wrote: > > Not sure what's wrong here. I don't have this problem with the master > code. > > Version 1.7.2 has the correct XML for Hamburg: > > <Hex name="B7" value="30,50" tile="-903" pic="-939" > orientation="1" > > city="Hamburg"> > > <Access runThrough="yes"/> > > </Hex> > > so perhaps some old code is included that does not pick up or use the 'pic' > > attribute (which is new). > > Stefan, could you check this? > > > > Erik. > > > >> -----Original Message----- > >> From: John David Galt [mailto:jd...@di...] > >> Sent: Sunday, April 08, 2012 10:08 PM > >> To: Development list for Rails: an 18xx game > >> Subject: Re: [Rails-devel] Bug: 18EU, 1.7.0 > >> > >> Stefan Frey wrote: > >>> Martin: > >>> the fix is works perfectly and is exactly what was missing. > >>> Pushed into rails1.7.x branch. > >>> > >>> John: > >>> thanks for catching the bug. Most likely it was hidden as most > >>> players will prefer choosing to choose the home token at an already > >>> connected station. > >> > >> The fix worked, but another bug seems to have arisen in 1.7.2 -- > >> Hamburg (red > >> off-board) is now shown as three unconnected arrows. Running through > >> it still works, though. > >> > >> > > ---------------------------------------------------------------------- > > ------ > > -- > >> For Developers, A Lot Can Happen In A Second. > >> Boundary is the first to Know...and Tell You. > >> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > >> http://p.sf.net/sfu/Boundary-d2dvs2 > >> _______________________________________________ > >> Rails-devel mailing list > >> Rai...@li... > >> https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > ---------------------------------------------------------------------- > > -------- For Developers, A Lot Can Happen In A Second. > > Boundary is the first to Know...and Tell You. > > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > > http://p.sf.net/sfu/Boundary-d2dvs2 > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > ---------------------------------------------------------------------------- -- > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |