Re: [Rails-devel] 1880 "almost" playable for review and testing- Bughunting now possible would be t

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Martin:
you have implemented the static modifier inside the PubliCompany_1880 
class. By this each instance/object gets registered with the revenue 
manager and each of them gets called every time revenue is calculated.
So you have to check inside your implementation if the running company 
is equal to the company implementing, so check if 
(revenueManager.getCompany() != this) first.

I have added that already, as it is easier then you again submitting a 
patch.

And I took the liberty to rename all OffBoardModifier (1880, 1851, 18EU) 
to include the game name as each is specific for each game.

Stefan

On 03/13/2012 04:09 PM, Dr....@t-... wrote:
> HI Stefan & Erik,
>
> understood, but the mechanismn is not working as intended right now.
>
> Somewhere theres a hardcoded point that an offhex city is always a City
> and cant be scored as a town. At least if i use Eriks example the code
> doesnt treat the town as a town.
>
> Btw Stefan any clue why the revenuemodifier backfires the way it does in
> 1880 ?
>
> It generates not 1 but 21 trains (one for each public Company) to be
> calculated per private company and not one :) And of course calculates
> the routes for those 21 trains.
>
> Regards,
> Martin
>
> *Von:* Stefan Frey <ste...@we...>
> *An:* rai...@li...
> *Betreff:* Re: [Rails-devel] 1880 "almost" playable for review and
> testing- Bughunting now possible would be the better state :)
> *Datum:* Tue, 13 Mar 2012 15:47:18 +0100
>
> Martin & Erik:
> I support Erik's suggestion below. Erik and I introduced generic
> attributes exactly for that reason.
> Stefan
>
>  >
>  > 1. You have split the tile type OFF_MAP_AREA into separate OFF_MAP_CITY
>  > and OFF_MAP_TOWN types.
>  >
>  > I understand why you are doing that (the blue “off-map harbours” score
>  > as towns), but I don’t think this rather special 1880 feature warrants
>  > the addition of a new generic type.
>  >
>  > There should be a much easier way to accomplish what you want: in
>  > Map.xml, replace
>  >
>  >
> <Hexname="Q13"tile="-9021"orientation="4"value="20,30,40,50"city="Haikou"/>
>  >
>  > by
>  >
>  >
> <Hexname="Q13"tile="-9021"orientation="4"value="20,30,40,50"score="town"city="Haikou"/>
>  >
>  > and similar for hex N16.
>  >
>  > I’m saying “there /should/ be” because this way to configure scoring is
>  > as yet hardly tested. This is the right time to do so…
>  >
>  > BTW I suppose in NetworkVertex line 251 you have
>  >
>  > *if*((station.getType().equals(Station./OFF_MAP_CITY/)) ||
>  > (station.getType().equals(Station./OFF_MAP_CITY/))) {
>  >
>  > … I suppose one of these OFF_MAP_CITY’s is a typo for OFF_MAP_TOWN. But
>  > if you follow my suggestion, this change isn’t necessary at all.
>  >
>  > 2. For your new blue preprinted harbour tiles, you define a new tile
>  > colour name /Tile.BLUE_COLOUR_NAME/.
>  >
>  > I don’t think that there is any need to define such a new name. This
>  > and the other “colour names” in this class have only superficial
>  > relation with the actual tile colours – their function is to define the
>  > tile type with respect to upgradeability and related characteristics.
>  > Here, I used the word “colour” for lack of a better name – the word
>  > “type” would much better describe the purpose of this item, but “type”
>  > is already heavily overused. Perhaps I should have used “level”.
>  >
>  > In this context, your off-map harbour hexes behave exactly like all
>  > other off-map hexes (except for scoring, see above). So, strange as it
>  > may seem, the “colour” of your new tiles 9021 and 9031 can best be
>  > described as “red”.
>  >
>  > (In hindsight, “offmap” would perhaps have been a better choice for the
>  > “colour” name of all off-map tiles than “red”).
>  >
>  > I’ll come back to your questions separately, if time permits.
>  >
>  >
>  > Erik.
>  >
>  > *From:*Dr....@t-... [mailto:Dr....@t-...]
>  > *Sent:* Friday, March 09, 2012 8:27 AM
>  > *To:* Rails Development
>  > *Subject:* [Rails-devel] 1880 "almost" playable for review and testing-
>  > Bughunting now possible would be the better state :)
>  >
>  > Hi Stefan, Erik, Frederick, Brent, et al.
>  >
>  > please check the code enclosed. I hope its complete and can be added to
>  > the latest master.
>  >
>  > If not my git setup is definetely FUBARed.
>  >
>  > commit c3bf5cd3efef8640b149d9f89744a6415864a1d3
>  > Author: Martin Brumm <Dr....@t-... <javascript:void(0)>
>  > <Dr....@t-... <javascript:void(0)>>> 2012-03-08 22:33:22
>  > Committer: Martin Brumm <Dr....@t-... <javascript:void(0)>
>  > <Dr....@t-... <javascript:void(0)>>> 2012-03-08 22:33:22
>  > Parent: 3f95ed86c7a463c64341871e73028af7edd88911 (added the 1880
>  > specific ShareSellingRound to the configuration.)
>  > Branches: master
>  >
>  > Implementing a SpecialBuyRight for a Number of Trains, not yet finished
>  > need to find the trigger and a valid way to proceed for the following
>  > mechanismn:
>  >
>  > If a train has been bought and we have a phase change the second train
>  > might be acquired once by the owner of the private Rocket of China
>  > (2+2,3,3+3,4 are possible trains/phases) So we need to ask the player if
>  > he wants to exercise that special buy action... Afterwards if he does
>  > the paper is closed. Different approaches not yet successfull.
>  >
>  > Second special power, after the last train of 2+2 or 3 or 3+3
>  > provenience the owner of the P0 might once declare his company closed
>  > and gets 40, 70 or 100 Yuan respectivly, private company is then closed.
>  > Note that money goes to the player not any company.
>  >
>  > Otherwise most things should be in and working now.
>  >
>  > So we need here a big check from Erik, Stefan, Brent and Frederick if
>  > everything is ok :)
>  >
>  > And let the testing start... (i am damn sure something will go wrong :))
>  >
>  > Regards,
>  > Martin
>  >
>  > Does anybody know a command to extract the commit history and put it in
>  > one file without the code ? :)
>  >
>  > Known Bugs:
>  >
>  > StatusWindow isnt reflecting Player Order Correctly after Startround has
>  > ended: Workaround: Save and reload Game
>  >
>  > Revenue Calculation for Minors is whacky... Havent figured out yet where
>  > the huge amount of trains is coming from :)
>  >
>  > Advice needed on implementing the specialpowers of the privates, sofar
>  > my tries have been unsuccessfull and thus deleted from the code.
>  >
>  > And as usual please point out or refactor the code if needed by your
>  > experience.
>  >
>  > Probably some others testing needs now to commence :)
>  >
>  >
>  >
>  >
> ------------------------------------------------------------------------------
>  > Virtualization& Cloud Management Using Capacity Planning
>  > Cloud computing makes use of virtualization - but cloud computing
>  > also focuses on allowing computing to be delivered as a service.
>  > http://www.accelacomm.com/jaw/sfnl/114/51521223/
> <?ctl=dereferer&to=aHR0cDovL3d3dy5hY2NlbGFjb21tLmNvbS9qYXcvc2ZubC8xMTQvNTE1MjEyMjMv>
>  >
>  >
>  >
>  > _______________________________________________
>  > Rails-devel mailing list
>  > Rai...@li... <javascript:void(0)>
>  > https://lists.sourceforge.net/lists/listinfo/rails-devel
> <?ctl=dereferer&to=aHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vcmFpbHMtZGV2ZWw%3D>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> <?ctl=dereferer&to=aHR0cDovL3Auc2YubmV0L3NmdS9sZWFybmRldm5vdy1kMmQ%3D>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li... <javascript:void(0)>
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> <?ctl=dereferer&to=aHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vcmFpbHMtZGV2ZWw%3D>
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] 1880 "almost" playable for review and testing- Bughunting now possible would be t

Re: [Rails-devel] 1880 "almost" playable for review and testing- Bughunting now possible would be the better state :)