Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Bill R. <ro...@gm...>]

On 2012-02-08, at 0:45 , Frederick Weld wrote:

> Bill:
> Thanks for the details.
> Unfortunately, I wasn't able to reproduce the exception, even when
> disabling the grid table layout option.
> But the details you provided were enough to identify the symptom
> (getBorderInsets returns null on the field to be added). Now, the
> GridPanel should be robust enough to handle that.
> 
> The problem is that this perhaps does not really help you as you
> reported that the OR window didn't proceed to OR 1.1. I can't tell why
> this is the case unless being able to reproduce the issue...
> 
> Would you mind checking what happens now on your local installation?
> 
> --Frederick

Frederik and Stefan,

I am still seeing the problem.  Looking at it in the debugger, when the exception is thrown it is not because getBorderInsets returns null, it is because innerBorder (and thus nativeInnerBorder) is null.

Digging further, this happens when GridPanel.addField is called to add a Spinner, which has a null border, and so passes in a null value to the constructor.

I can make this problem go away by adding the following test to the FieldBorder constructor, just above line 257 where I get the exception:

if (innerBorder == null) return;
           
Once I do this, the interface works as expected, but I do not know what side effects are likely to occur as a result.

I've attached a savegame, but as far as I can tell the problem is completely generic.  This happens when I create new games and when I load existing games.

Bill