Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Stefan F. <ste...@we...>]

Bill:
thanks for the patch. The git one works perfectly, so you can restrict 
yourself to that one in the future.

There will be another another bug-fix release later today.
Frederick could look into the issue of 1856 not running in master? Most 
likely that is due to customized UI classes?

Interestingly this is another case where there is no ex-post check for 
illegal actions in the game engine. Thus games can be loaded without an 
error even if the tile upgrade is considered illegal due to the changed
data files.

Stefan



On 02/07/2012 04:41 AM, Bill Rosgen wrote:
> Hello,
>
> I've attached a patch to fix the recently reported 1856 upgrade bug regarding which phases dits can be upgraded/downgraded in.  The problem is in the data files, where the phase names for these tile lays is incorrect (Phases 5,6 should be 6,D).
>
> I've also attached two savegames of a test game that show the problem: in the first, dits can be upgraded too early, as a 6 train has not yet been purchases, and in the second dits cannot be upgraded once a diesel has been bought.
>
> There are two patches, the first (0001-...) is in git format and the second (1856%3A...) is in Eclipse format.  Both patches are against the rails1.6.x branch, as with the recent UI work in master, I'm currently unable to get 1856 to work.  The patches should apply cleanly to master as well, but I'm not sure how hard it is to persuade git to do this without a cherry-pick.  If it is difficult to apply these patches, it may be easier to simply correct the data files by hand.
>
> Bill
>
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel