[Rails-devel] Bug fix: 1856 dit upgrade phases

[Bill R. <ro...@gm...>]

Hello,

I've attached a patch to fix the recently reported 1856 upgrade bug regarding which phases dits can be upgraded/downgraded in.  The problem is in the data files, where the phase names for these tile lays is incorrect (Phases 5,6 should be 6,D).  

I've also attached two savegames of a test game that show the problem: in the first, dits can be upgraded too early, as a 6 train has not yet been purchases, and in the second dits cannot be upgraded once a diesel has been bought.

There are two patches, the first (0001-...) is in git format and the second (1856%3A...) is in Eclipse format.  Both patches are against the rails1.6.x branch, as with the recent UI work in master, I'm currently unable to get 1856 to work.  The patches should apply cleanly to master as well, but I'm not sure how hard it is to persuade git to do this without a cherry-pick.  If it is difficult to apply these patches, it may be easier to simply correct the data files by hand.

Bill