Re: [Rails-devel] Push request: Refactored network info (incl. keyboard shortcut and version for end-users)

[Frederick W. <fre...@go...>]

Thanks for the push!

I performed some refactoring as I was not too happy with some aspects.
Would you mind pushing the 0003 patch?

*******
Routes of current company calculated asynchronously

Polished the handling of route calculations. This was needed as a
follow-up to introducing persistent route display of the current
company.

Achieved the following:
- All route calculations are performed asynchronously (as it was already
the case before for set-revenue route calculations).
- ORPanel now only uses one revenue adapter for both use cases
(current route display and set-revenue calculation).
*******

For the Q & A:

> * You only show the optimal routes on map, but there is nothing
> displayed about what the run for and which cities etc.?
Nothing is displayed. More information is available in the network
info menu. But this could be expanded of course (if we got the pull
from the 18xx end users).

> * I thought I had coded an automatic size adjustment of the config window
> to the number of options available. Did it not work like that?
Unfortunately, this didn't work. The config window starts with a fixed
size (6xx * 4xx) and does not resize.

> * The bug (revenue breaks with an error if company has no route at all) you
> reported is already known, however not fixed in master yet (that still resides
> in branch revenue if I remember correctly). As it used to do no harm, I was
> too lazy to merge it yet.
Now, it does not harm any more (as everything is run asynchronously).
So you don't have to merge this.

> * Other issue: I would prefer background maps displaying the coordinates on
> their own instead of Rails adding them, this spoils the beauty somehow ;-)
Within rails, I experimented with anti-aliasing or outlining the
coordinates but the results weren't satisfactory. Keep in mind that
this minimum font size we wanted for the station tokens cannot be
maintained for the coordinates if they are part of the map...