Re: [Rails-devel] Push request: Refactored network info (incl. keyboard shortcut and version for end-users)

[Stefan F. <ste...@we...>]

Frederick:
Both patches pushed. Both work for me.

Q & A:
* You only show the optimal routes on map, but there is nothing
displayed about what the run for and which cities etc.?

* I thought I had coded an automatic size adjustment of the config window
to the number of options available. Did it not work like that?

* The bug (revenue breaks with an error if company has no route at all) you 
reported is already known, however not fixed in master yet (that still resides 
in branch revenue if I remember correctly). As it used to do no harm, I was 
too lazy to merge it yet.

* Other issue: I would prefer background maps displaying the coordinates on 
their own instead of Rails adding them, this spoils the beauty somehow ;-) 

Stefan


On Tuesday, January 03, 2012 09:22:32 pm Frederick Weld wrote:
> I finally concluded to introduce a new config option ("Display routes
> of currently active company") instead of the keyboard shortcut. The
> main reason is that, while being highly desirable for 18xx newbies,
> implementing this option was not much effort once I replaced the popup
> by some lazy invalidation mechanism (of the route display).
> 
> Would you please git push this?
> 
> @Stefan: There appears to be a bug in the route calculation. It can be
> reproduced by the attached save game (just buy a train for KU - route
> display has to be active of course). I could have corrected the
> symptoms but probably it's better if you had a look at this.
> 
> --------------------
> 
> Subject: [PATCH 1/2] Fixed hexmap layering (tokens and text now displayed
> on top of routes)
> 
> Before, route strokes were placed on top of the map, thus hiding
> potentially valuable information.
> 
> This has been adjusted: Train routes are now drawn on top of the hexes
> but below any further map information (tokens, home bases, texts for
> costs, special tokens)
> 
> Subject: [PATCH 2/2] Added option to display optimal routes of currently
>  active company
> 
> If this option is chosen, optimal routes are displayed for each OR
> step. This option replaces prior keyboard shortcut Ctrl+N which had
> some disadvantages (popup, optimal route display only temporary).
> 
> The config section "map/report" has been split as it contained too
> many items after adding aforementioned option.