From: Erik V. <eri...@xs...> - 2012-01-03 12:59:13
|
> -----Original Message----- > From: Stefan Frey [mailto:ste...@we...] > Sent: Tuesday, January 03, 2012 12:12 PM > To: Development list for Rails: an 18xx game > Subject: Re: [Rails-devel] Push request: Enforcement of forced train > purchases > > See comments below > > On Tuesday, January 03, 2012 08:27:16 am Frederick Weld wrote: > > Regarding "a train": > > One option to accomodate both Erik's and Stefan's approach would be as > > follows: Each 18xx variant has a set of trains that are relevant for > > checking routes. For performance reasons, this set should be minimal. > > So for 1830 it would be {2} and for 18VA (if it had route-dependent > > enforcement) would be {2,1G}. The adapter's route check would be run > > with this set. > > That is possible, however I do not recommend to implement features > potentially never used. From my experience after some time they get > untested and/or unmaintained. For the time being I would define a static > global inside RevenueAdapter. I suppose you mean: define and use a fixed set {2}, and I agree with that idea. At least we would then have a placeholder that we could later make configurable, should the need arise. Erik. |