Re: [Rails-devel] Push request: Enforcement of forced train purchases

[Stefan F. <ste...@we...>]

Quick answers first, see below.

On Monday, January 02, 2012 08:14:03 am Frederick Weld wrote:
> Regarding the definition of routes:
> Thanks for pointing out that there are variants that do not require
> forcedly purchsed trains to run (at least 1844). Actually, I started
> with a 2-train route check only to leave this approach when thinking
> of hex trains. The patch could easily be amended to revert back to
> that logic. (But, as Stefan said, the first step would consist of
> clarify this in a discussion.)

My current favorite for an implementation is to run a virtual 2-train
and check if it shows non-zero income => Company has a route. That will run 
fast, is easy to implement and very close to what players might usually 
expect. This method could/should be implemented inside the algorithm package. 

> 
> Regarding rails' layering:
> It would be a valid design decision to keep route awareness out of the
> game engine. But then every consumer of the game engine has to take
> care of becoming route aware on himself. Currently, that's not a big
> deal as there is only one consumer (the UI). But in the longer term,
> there could also be other consumers (RemoteHuman, AI) and, then,
> having put route awareness into the game engine would come in very
> handy.

More on this in a later e-mail.

> 
> Regarding incompatibility with Rails 2.0 (@Stefan):
> Which aspect of this patch is incompatible to rails 2.0? Which
> adjustment would be necessary in order to avert this?

The incompatibility is narrowly defined in the sense that the commit/patch 
cannot be merged automatically with the Rails 2.0 patch:
All patches that include a change GameManager or any of the Round classes  
cannot be merged automatically anymore. 

It does not mean that it incompatible in a broader sense, it is only that 
someone has to do the merge manually at some time in the future. And as you 
are already implement faster as I can currently comment on, it is unlikely 
that I will be able to that ;-)

> 
> ---------------------------------------------------------------------------
> --- Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a
> complex infrastructure or vast IT resources to deliver seamless, secure
> access to virtual desktops. With this all-in-one solution, easily deploy
> virtual desktops for less than the cost of PCs and save 60% on VDI
> infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel