Re: [Rails-devel] Push request: Correction bundle (Precise token label positioning, initial map image display, 1856 map)

[brett l. <bre...@gm...>]

On Sun, Jan 1, 2012 at 5:59 PM, Erik Vos <eri...@xs...> wrote:
>> > commit 9fe97ef2fa38cf5d7c6d43c1916a0ceb0541034b
>> >
>> >    Added precise sizing and positioning of token labels
>> >
>> >    Introduced a generic logic that provides for precise
>> > sizing/positioning
>> >    for any label text length and zoom factor.
>> >
>> >    Replaces prior heuristic that, among others, placed labels partly
>> >    outside of the tokens.
>> >
>> > --> See Erik's description of the prior state:
>> > https://sourceforge.net/mailarchive/message.php?msg_id=28555719
>
> Now that I have seen the result, I'm not too happy about it.  The token labels fit inside the circles indeed, but readability has suffered a bit too much for my taste.
> For instance, the 1830 NYNH and 1856 BBG tokens are now hardly readable (for me) at normal scale.
> It's fine for me to have to rely on the colours only, but that's not true for everybody, as we have recently discussed.
>
> I'm not proposing to revert this commit, but I don't consider it a final solution either.
>
> Erik.
>

That's about what I expected.

IMO, the calculation being performed has improved, but now we'll need
to figure out a sensible default value for the scaling.

---Brett.