From: <ste...@we...> - 2011-12-30 10:45:07
|
Erik & Frederick, I half a 75% finished reply in my draft folder after reviewing the patch. There is no technical reason to hold the patch (I like both the implementation and the documentation), however there are two issues which I believe should be considered: Even if I agree with Fredericks rule interpretation of "having a route" I am sure that there will be other interpretations (especially if one generalizes to all possible games and trains) and I would prefer to see a discussion at least on this list, but it is even more likely that it should end up on the yahoo list. >From a design point of view I agree with Eriks point of view that it should stay outside of the game engine, however for different reasons... But here my opinion is not that important as the patch will not make into Rails 2.0 anyway. So please be patient for more details. Stefan -----Ursprüngliche Nachricht----- Von: "Frederick Weld" <fre...@go...> Gesendet: Dec 30, 2011 11:17:21 AM An: "Development list for Rails: an 18xx game" <rai...@li...> Betreff: Re: [Rails-devel] Push request: Enforcement of forced train purchases You are right that parts of the route calculation might be performed twice. However: (1) This only occurs if all other necessary conditions for forced train purchases apply (see lazy route calculation in OperatingRound.isForcedTrainPurchase). (2) Even then, this duplication only applies to the initialization of the network graph, as the second route determination is parameterized differently with respect to trains (publicly available train types vs. company owned ones (=zero) for triggering by the UI layer). For the target design, I fully agree with you. The tricky part would consist of avoiding duplication during graph construction and route calculation, given that each OR-step is potentially based on a different graph (eg., lay tile changes graph for lay token) and works with different train sets (set revenue vs. forced train purchase). ------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox _______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel |