[Rails-devel] Push request: 2 minor bug fixes (autosave handling and defaulting of game options)

[Frederick W. <fre...@go...>]

Would you please push these patches into origin/master?

--- Frederick

commit 6144b4c35787a884be65a11d08f662f9f5b3ca7a

    Fixed retrieval of default game options (if options pane was not opened)

    Game options have to be read from GamesList.xml and not from the
    respective game's Games.xml GameOption tags.
    Before the fix, this was not the case if the options pane had not been
    opened (which is the moment at which the GamesList's default options
    were loaded).

    This fix also solves Bug 3448429, as the reported missing 18EU route
    calculation was due to inconsistent defaulting between GamesList
    (default=suggest) and Games (default=deactivate). Now, the defaults
    are always taken from GamesList.

commit f8a0b7eaf7334fd36973df9e82e6dd1d1e76dea0

    Fixed autosave functionality (handling of 18xx_autosave.xxx files)

    Target design is that
    (1) new temp file (.tmp) is created
    (2) former autosave (.rails) becomes the backup autosave (.rails.bak)
    (3) temp file (.tmp) becomes the new autosave (.rails)

    Prior to the fix, the implementation did not process step (2) correctly,
    as backup autosaves were never dropped. This meant that autosave resulted
    in an error message and three files in the autosave folder (.tmp , .rails ,
    .rails.bak). That's why autosave had never worked for me (and I doubt that
    it could have worked for others).