Re: [Rails-devel] Bug in 18EU implementation in 1.54

[Erik V. <eri...@xs...>]

> From: Stefan Frey [mailto:ste...@we...]
> are you sure that the FinalMinorExchangeRound is the only one effected?
>
> There are a few more Pseudo-StockRounds which all inherit from
> StockRound that might be effected:

I have checked these only visually.

> * PrussianFormationRound

... has its own finishRound() method that does not up the share price and
does not call super methods.

> * ShareSellingRound and ShareSellingRound_1856

... you're probably right on this one. I thought: share selling is forced
and will always end up with shares in the Pool, but of course that does not
apply to all companies.

> * TreasuryShareRound

... does not call finishRound().

On second thoughts, it's probably safer to set the new 'raiseIfSoldOut'
attribute to false by default, and move the true setting from the
constructor to the start() method. The latter method is only called by
"real" stock rounds; all other types have their own variety of this method.
I'll also add a warning comment.

Erik.