Menu
▾
▴
Re: [Rails-devel] Special tile laying
|
From: Erik V. <eri...@xs...> - 2011-12-06 21:13:13
|
I have created a new OperatingRound method named validateSpecialTileLay(), which contains all of the prevalidation code that previously existed in getSpecialTileLays(). Most of that code was added in my previous commit. This change enabled me to fix the 1835 cases, in addition to the previous 1830 and 18AL cases. In OperatingRound_1835 the former rather than the latter method is now overridden. Some code duplication has been removed as well this way. Still to do: 1889, where the situation is even more complex. Erik. > -----Original Message----- > From: Erik Vos [mailto:eri...@xs...] > Sent: Friday, December 02, 2011 8:44 PM > To: 'Development list for Rails: an 18xx game' > Subject: RE: [Rails-devel] Special tile laying > > Stefan, > > In OperatingRound, I have excluded SpecialTileLay as a property that causes > the addition of a UseSpecialProperty action (which duplicated the LayTile > action). > > However, you have added special code in OperatingRound_1889 to add a > UseSpecialProperty for this specific case, and I have not touched that code. > So my new precautions will not apply to this 1889 case yet, and have not > sorted out how to accomplish that. Some refactoring will be needed. > > Erik. > > > -----Original Message----- > > From: Stefan Frey [mailto:ste...@we...] > > Sent: Friday, December 02, 2011 1:08 PM > > To: Development list for Rails: an 18xx game > > Subject: Re: [Rails-devel] Special tile laying > > > > Follow-up to Erik: > > Have you pushed the commit already in which you removed the special > > tile option from the Special menu? > > I checked my 1889 test games and the tile lay is still available from > > the Special Menu. > > Stefan > > > > On Thursday, December 01, 2011 02:47:56 pm Stefan Frey wrote: > > > Erik: > > > quick answer on the last issue: > > > The special menu entry was used to facility the special tile lay of > > > private B in Rails: Player B is allowed to lay the tile independent > > > of an ownership of the company. > > > So removing that possibility breaks 1889 support and potentially > > > existing game files. > > > Stefan > > > > > > > 4) I have removed the additional inclusion of such special tile > > > > lays as options in the "Special" menu. This was accomplished by a > > > > different mechanism and would not follow the above new rules. > > > > I'm not entirely sure why this menu option had been included, and > > > > if it is really needed. I'll check my old emails later, but I can > > > > think now of two reasons: > > > > - special tiles lays exist that are permitted outside the normal > > > > tile laying step, > > > > - increasing user-friendliness by adding an alternative procedure, > > > > with the usual "special action" highlight. > > > > In any case, if this feature must be retained, it will have to be > > > > provided by the UI rather than by the game engine, as it was > previously. > > > > > > > > Erik. > > > > > > > > > > > > ------------------------------------------------------------------ > > > > -- > > > > ----- > > > > -- --- All the data continuously generated in your IT > > > > infrastructure contains a definitive record of customers, > > > > application performance, security threats, fraudulent activity, > > > > and more. Splunk takes this data and makes sense of it. IT sense. And > common sense. > > > > http://p.sf.net/sfu/splunk-novd2d > > > > _______________________________________________ > > > > Rails-devel mailing list > > > > Rai...@li... > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > -------------------------------------------------------------------- > > > -- > > > ----- > > > --- All the data continuously generated in your IT infrastructure > > > contains a definitive record of customers, application performance, > > > security threats, fraudulent activity, and more. Splunk takes this > > > data and makes sense of it. IT sense. And common sense. > > > http://p.sf.net/sfu/splunk-novd2d > > > _______________________________________________ > > > Rails-devel mailing list > > > Rai...@li... > > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > ---------------------------------------------------------------------- > > -------- All the data continuously generated in your IT infrastructure > > contains a definitive record of customers, application performance, > > security threats, fraudulent activity, and more. Splunk takes this > > data and makes sense of it. IT sense. And common sense. > > http://p.sf.net/sfu/splunk-novd2d > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel |
