Re: [Rails-devel] 18EU bug in 1.5.2

[<Dr....@t-...>]

Hi Stefan, 

	it probably will effect all games that have an Bid Mechanismus aside
from the normal Startround Behaviour. 

	I'll recheck the behaviour for 1880 on Thursday as i am traveling
right now and dont have access to the code. 

	Regards, 

	Martin  

	  Von: Stefan Frey <ste...@we...>
 An: "Development list for Rails: an 18xx game"
<rai...@li...>
 Betreff: Re: [Rails-devel] 18EU bug in 1.5.2
 Datum: Tue, 08 Nov 2011 16:10:45 +0100

 Bill,
 I will respond on behave and in addition to Erik (see below).

 It seems that Erik thought at that time of his bug fix that the code
for 
 automatic passes was out of date/ineffective and simply commented it
out. 

 However this is something that I introduced because of a feature
request 
 especially for those occasions in 18EU. It took me some time to fix
side-
 effects that the next player was not chosen in the correct sequence
after an 
 automatic pass. I considered the 18EU StartRound to be quite a beast
;-) 
 (please no offense taken - Erik).

 This did not occur for the standard StartRound (1830 style). I cannot

 remember if I have checked 1835 StartRound at that time.

 Unfortunately this is a UI function and thus cannot be tested by the
current
 automatic game tests.

 My preferred solution is to fix that by uncommenting the code and
publish a
 new Release 1.5.3, but I want Erik's opinion first, if this has any
impact on 
 1835 or other games.

 Stefan

 On Tuesday, November 08, 2011 03:44:44 pm Bill Rosgen wrote:
 > Erik,
 > 
 > As far as I can tell, a bug was introduced in commit 1893c3 that
makes the
 > 18EU minor auction unplayable in certain circumstances.  This is
the
 > commit with message: "In 1835 Start Round, removed popups that
reported
 > forced passes.  Also removed some redundant/ineffective code." 
 > Specifically, I think the problem occurs whenever a player is
forced to
 > pass in an auction due to a lack of funds.
 > 
 > It seems like the 18EU Starting Round depended on exactly how
forced-passes
 > were being implemented.  In the attached savegame, Carol has spent
all of
 > her money and so must pass on the minor being auctioned, but
instead of
 > this happening, the Starting Round window vanishes and Rails
becomes
 > non-functional.
 > 
 > Digging further, the commented out code on lines 897-9 of
 > rails/GameManager.java seems to be the source of this behaviour. 
 > Uncommenting it (as well as the function it calls in
PossibleActions)
 > fixes 18EU, but it presumably will cause breakage elsewhere.  I
suspect
 > that StartRound_18EU.java has somehow become obsolete, but after
spending
 > a while going through the various StartRound and GameManager
classes, I
 > can't find the problem.
 > 
 > Bill

 ------------------------------------------------------------------------------
 RSA(R) Conference 2012
 Save $700 by Nov 18
 Register now
 http://p.sf.net/sfu/rsa-sfdev2dev1
 _______________________________________________
 Rails-devel mailing list
 Rai...@li...
 https://lists.sourceforge.net/lists/listinfo/rails-devel