[Rails-devel] 18EU bug in 1.5.2

[Bill R. <ro...@gm...>]

Erik,

As far as I can tell, a bug was introduced in commit 1893c3 that makes the 18EU minor auction unplayable in certain circumstances.  This is the commit with message: "In 1835 Start Round, removed popups that reported forced passes.  Also removed some redundant/ineffective code."  Specifically, I think the problem occurs whenever a player is forced to pass in an auction due to a lack of funds.

It seems like the 18EU Starting Round depended on exactly how forced-passes were being implemented.  In the attached savegame, Carol has spent all of her money and so must pass on the minor being auctioned, but instead of this happening, the Starting Round window vanishes and Rails becomes non-functional.

Digging further, the commented out code on lines 897-9 of rails/GameManager.java seems to be the source of this behaviour.  Uncommenting it (as well as the function it calls in PossibleActions) fixes 18EU, but it presumably will cause breakage elsewhere.  I suspect that StartRound_18EU.java has somehow become obsolete, but after spending a while going through the various StartRound and GameManager classes, I can't find the problem.

Bill