From: Phil D. <de...@gm...> - 2011-10-25 11:11:51
|
If I recall 1851 is supposed to be unlimited plain track too...although that might already be included in rails as it stands On 25 October 2011 11:38, Bill Rosgen <ro...@gm...> wrote: > Bug 3064825 requests the ability to select unlimited plain track only (i.e. tiles 7,8,9). It is reported that this is included in the 18EU rules, though I cannot find it in my copy. In any case, it maybe doesn't hurt to have the option. > > I've attached a patch that makes this change for 18EU (and shouldn't break any other games). The unlimited tiles checkbox is expanded to take the values 'No,Plain,Yes', with the default remaining 'No'. I have also had to make a change to Tile.java to implement the 'Plain' option. Any tile with no stations and exactly one piece of track is considered 'Plain'. In 18EU this applies to exactly tiles 7,8, and 9, but I would rather not hardcode these tile ids. I've also added the option to the 1826 prototype data files, but it's not currently available as no variants are defined in GameList.xml. > > It is maybe worth adding this test as a function isPlain() in the Tile class, but I'm not sure: this makes the test easier to find, but will any other code will ever need to ask if a tile is 'Plain'? > > Other than the comment on the bug that this is in the rules for 18EU and 1826, I see no reason to limit this to 18EU. If this is thought to be a good idea, I can easily make changes to the other data files to enable the option across all games. > > I've attached a couple of patches, again the first is in git format and the second is in Egit format. If this seems like a good thing to apply globally, let me know and I will produce a similar patch that applies to all of the games implemented in Rails. > > Bill > > > ------------------------------------------------------------------------------ > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Cisco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > > |