Re: [Rails-devel] Test report: 1835 in Rails 1.5.1 (Windows XP) - corrected

[Erik V. <eri...@xs...>]

Found and fixed two 1835 bugs.  Game Notes updated.

> -----Original Message-----
> From: John David Galt [mailto:jd...@di...]

> 4. The bug reported in Game Notes, where the game would hang if the By
> did not float in the first round, is no longer fatal, at least for me.

Fixed this one, and removed it from the Game Notes. 
The error was that no possible actions were generated in this situation.

> To be exact: As soon as the "Start Round" is passed out, focus moves to
the
> Game Status window, and its "Pass" and "Autopass" buttons change color as
> if they'd been enabled (but that window's name does NOT change to "Stock
> Round [n]", and a popup "Error: No action available" appears).

I found the focus moving to the Map window. 

> I worked around this by simply doing File -> Save on the menu bar and
saving
> the game.  (A restore wasn't needed.)  This moved the focus to the map
> window and made it an operating round, which of course is how it should
> have been.  When the OR finished, "Start Round" reappeared on the screen.

So this workaround is no longer necessary.

> 5. Nit: The first operating round is still "0.1".

No longer (as a side effect of the above fix).

> 14. The game reaches the point of the attached save file.  When the PR
buys
> the 5-train, SX has to discard a train (correctly changed from happening
upon
> purchase of the 4+4).  But then the game hangs while trying to merge the
> remaining private and minor companies.  I had to "undo" the 5-train
purchase
> (using the report window) to be able to save the game.
> 
> I've included the log as well.

A real bug: already closed privates (HB in this case) were again submitted
to the merge step in the PR formation process.
Fixed.

I have also put the correct workaround into the Game Notes for cases where
PfB en OBB do not close where these should: use the Special|Close privates
menu option.

Erik.