Re: [Rails-devel] Keeping compatibility (was: Test report: 1835 in Rails 1.5.1)

[Stefan F. <ste...@we...>]

The solution Brett suggested was implemented by me some time ago:
This enabled the auto-pass in the Start-Round.

It does not skip an action or player, but selects and executes the pass action 
automatically if it is the only possible action for a Player. The advantage of 
this is that does not break the save file compatibility.

I mentioned at that time that this behavior could be extended to the 
ShareRound if we check if the ActionSet only consists of Pass and Autopass.

At that time I did introduce the new message to the ReportBuffer (this creates 
the Popup before the next player without Autopass) to make players aware of 
the changed behavior.

Maybe the best solution is to make this configurable.
Something like AutoSkipPassingPlayers = {Silent, Warn, No}

Any thoughts what the default should be? This reminds me that in principle the 
configuration system allows different default profiles, maybe we should have 
one for beginner and one for experts?

Stefan




On Tuesday, October 11, 2011 03:36:23 pm Erik Vos wrote:
> I understand, but that would mean adding special compatibility code to skip
> such now 'silent' player actions when loading a saved file.
> 
> That's possible, but it's ugly.  For a long time, there has been such code
> in Game.load() to cope with one removed 'Done' action in (I believe) 1856.
>  That code is gone now. There is also such a case in 18EU, where I have
> not added compatibility code, but where have had to edit lots of old saved
> files to remove that extra 'Done', and I still occasionally encounter such
> saved files.
> 
> Erik.
> 
> > I didn't necessarily mean remove the actions from the log or save file. I
> > meant simply that we'd silently move the game forward until there's an
> > action needing player intervention.
> > 
> > ---Brett.
> > 
> > On Tue, Oct 11, 2011 at 5:56 AM, Erik Vos <eri...@xs...> wrote:
> > > I agree that tidying up these behaviours would be a good thing.
> > > 
> > > I think removing popups is easy to do.  Pressing the 'OK' on such
> > > popups
> > 
> > does not count as a player action.
> > 
> > > But removing unnecessary 'Pass' and 'Done' actions is a different
> > > matter,
> > 
> > because it has a bad side effect: all saved games that contain at least
> > one such removed action will no longer load. At least not without
> > special compatibility code to detect and catch such cases (and I'm not
> > sure if it's feasible at all).  This is especially bad for the
> > developers, who heavily rely on sometimes pretty old saved files for
> > testing.
> > 
> > > This consideration has so far kept me from removing such actions.  The
> > > one
> > 
> > case I once did has caused me a lot of trouble.
> > 
> > > Ultimately we will have to bite the bullet.  There is already quite
> > > some
> > 
> > compatibility code that I would like to get rid of as well.
> > 
> > > Would it be an idea to set this as a goal for Rails 2.0?  Or 2.1? 
> > > Remember: it
> > 
> > means that we will have to rebuild all test cases.  Not just those in the
> > repository.
> > 
> > > Erik.
> 
> ---------------------------------------------------------------------------
> --- All the data continuously generated in your IT infrastructure contains
> a definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2d-oct
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel