Re: [Rails-devel] 1880 intermediate features

[Erik V. <eri...@xs...>]

Hi Martin,

 

1.       I think you are missing some Batik library.  On my PC, it compiles fine.

 

2.       It does not run, though. StartRoundWindow_1880 cannot be instantiated.  I can fix that by removing its two-argument constructor.  Please note, that the new construction process (after the classname had be made variable) needs the (default, empty) no-argument constructor.  A new method init(StartRound round, GameUIManager parent) is now called separately to initialise this window.  See the new StartRoundWindow class.

 

3.       In my opinion, you should put everything related to building rights into 1880-specific classes.  I think the only missing one is BuyStartItem_1880.  That should not be a problem, as you create this action object in StartRound_1880.

 

4.       Miscellaneous remarks:
-  To make your new capitalisation type more generic, I would suggest to replace its value “fiftyPercent” by “percentage” and add an attribute ‘percentage=”50”’.
- Similarly, I would propose to replace the revenue tags Revenue5 etc. by a single tag type (e.g. ExtraRevenue) and an ‘amount’ attribute.

 

Regards,
Erik.

 

 

 

From: Dr....@t-... [mailto:Dr....@t-...] 
Sent: Saturday, October 08, 2011 6:18 PM
To: Rails Development
Subject: [Rails-devel] 1880 intermediate features

 

Hi all,

 

this patch contains some of the needed alterations in regard to the Stockmarket in 1880 and the Startround should now function.

 

I currently get problems running the code, it says a transcoder is missing ? Did anybody lately compiled the code ?

 

Exact error message follows down below:

 

Exception in thread "AWT-EventQueue-0" java.lang.Error: Unresolved compilation problems: 
    The import org.apache.batik.transcoder cannot be resolved
    The import org.apache.batik.transcoder cannot be resolved
    ImageTranscoder cannot be resolved to a type
    The method createImage(int, int) of type ImageLoader.BufferedImageTranscoder must override a superclass method
    TranscoderOutput cannot be resolved to a type
    TranscoderException cannot be resolved to a type

    at rails.ui.swing.ImageLoader.<init>(ImageLoader.java:10)
    at rails.ui.swing.GameUIManager.gameUIInit(GameUIManager.java:185)
    at rails.ui.swing.GameSetupWindow.startNewGame(GameSetupWindow.java:509)
    at rails.ui.swing.GameSetupWindow.actionPerformed(GameSetupWindow.java:251)
    at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
    at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
    at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
    at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
    at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
    at java.awt.Component.processMouseEvent(Component.java:6289)
    at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
    at java.awt.Component.processEvent(Component.java:6054)
    at java.awt.Container.processEvent(Container.java:2041)
    at java.awt.Component.dispatchEventImpl(Component.java:4652)
    at java.awt.Container.dispatchEventImpl(Container.java:2099)
    at java.awt.Component.dispatchEvent(Component.java:4482)
    at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
    at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
    at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
    at java.awt.Container.dispatchEventImpl(Container.java:2085)
    at java.awt.Window.dispatchEventImpl(Window.java:2478)
    at java.awt.Component.dispatchEvent(Component.java:4482)
    at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:644)
    at java.awt.EventQueue.access$000(EventQueue.java:85)
    at java.awt.EventQueue$1.run(EventQueue.java:603)
    at java.awt.EventQueue$1.run(EventQueue.java:601)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
    at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
    at java.awt.EventQueue$2.run(EventQueue.java:617)
    at java.awt.EventQueue$2.run(EventQueue.java:615)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:614)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

 

This is on Windows using Eclipse.

 

I'll try and get a new clone later and see if the error still crops up or is just locally.

 

Regards,

Martin