Re: [Rails-devel] Tokens misplaced on tile #59?

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

>>  Using git bisect I am able to track the offending commit (at least as
far as 1830 goes) to commit 0c69cf, which introduced the Coalfields variant.
Digging further, the cities on tile #59 were at positions  052 and 352
before this commit, but at positions 152 and 452 following the commit.
>>

This puzzles me. As far as I can see, the position values 152 and 452 for
tile #59 exist since the introduction of these codes 6 years ago.

It turns out, that this kind of token misplacement only occurs 
- in games with EW-oriented tiles
- for tokenable cities that are located off-center
- but only for cities located near a tile corner, not if located near a tile
edge.

Token locations are calculated in GUIHex.getTokenCenter(), and so far I
can't find anything that can explain why only corner-facing cities would
suffer from this problem.
I can't find anything irregular, neither in this code, nor in the
translations from the TileDesigner city location names  to my position codes
in ConvertTilesXML cityMap.

Erik.

> -----Original Message-----
> From: Erik Vos [mailto:eri...@xs...]
> Sent: Wednesday, October 05, 2011 11:39 PM
> To: 'Development list for Rails: an 18xx game'
> Subject: Re: [Rails-devel] Tokens misplaced on tile #59?
> 
> It's actually a 30 degrees clockwise rotation.
> 
> I'll have a look tomorrow. One possibility is that some code has got
confused
> with respect to the hex orientation (NS or EW).  I know there have been
> changes around the hex orientation logic, and maybe some consequence of
> that has been missed.
> 
> Erik.
> 
> > -----Original Message-----
> > From: Bill Rosgen [mailto:ro...@gm...]
> > Sent: Wednesday, October 05, 2011 6:52 PM
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Tokens misplaced on tile #59?
> >
> > This happens in new games created and played with 1.5, and it also
> > happens in games created and played in older versions.
> >
> > If the bug isn't universal, I can post screenshots that demonstrate
> > the problem.  It would be odd, however, if the change in the data
> > files was
> not
> > the source of the problem.  I cannot, however, find an explanation for
> > the changes to the (automatically generated) data files.
> >
> > Bill
> >
> > On 2011-10-05, at 22:08 , Phil Davies wrote:
> >
> > > I've not noticed this problem but does it occur if you replay a game
> > > from the start?  I wonder if this is an issue of using an old save
> > > with newer codebase?
> > >
> > > I'll try these out later and see
> > >
> > > Phil
> > >
> > > On 5 October 2011 14:56, Bill Rosgen <ro...@gm...> wrote:
> > >> Hello,
> > >>
> > >> Am I the only one who is seeing tokens misplaced on tile #59.
> (Actually, it
> > seems to be any station with position x5y for arbitrary x and y.)
> Specifically,
> > they appear one 60 degree rotation from the correct place.  I've
> > attached
> a
> > savegame that shows this for the Erie's home hex.  This also appears
> > in
> the
> > 1830 Reading variant, with the preprinted PRR and the RDG home tiles.
> > >>
> > >> I have spent some time this evening trying to find the problem, but
> > >> I
> am
> > largely at a loss.  Using git bisect I am able to track the offending
> commit (at
> > least as far as 1830 goes) to commit 0c69cf, which introduced the
> Coalfields
> > variant.  Digging further, the cities on tile #59 were at positions
> > 052
> and 352
> > before this commit, but at positions 152 and 452 following the commit.
> > >>
> > >> This, one would think, could be easily found in the data files, or
> > >> in
> the
> > code that generates data/Tiles.xml from data/TileDictionary.xml.  I
> > have looked at the previous commit that modified Tiles.xml: I can see
> > the
> change
> > in tile #59 (and presumably other tiles also), but I cannot find any
> changes to
> > the tile database or the program that generates Tiles.xml that look
> > like
> they
> > would cause this change.
> > >>
> > >> I can (and will) continue to try to find the source of the problem,
> > >> as
> clearly
> > hand-editing the generated Tiles.xml files is not a solution, but I
> thought I
> > would ask to see if anyone knows how/why such a change might have
> been
> > introduced.
> > >>
> > >> The two attached savegames show the problem (at least on my end).
> > >> The
> > 1830 savegame has the Erie's home token out of place, and the 1830R
> > savegame has the RDG's token (among others) in the wrong place.  If
> > you
> are
> > checking out old code, note that only the 1830 savegame is likely to
> > work,
> as
> > the 1830 Reading savegame requires fixes that were only released in
> > Rails 1.5.
> > >>
> > >> Bill
> > >>
> > >> -------------------------------------------------------------------
> > >> --
> > >> --------- All the data continuously generated in your IT
> > >> infrastructure contains a definitive record of customers,
> > >> application performance, security threats, fraudulent activity and
> > >> more. Splunk takes this data and makes sense of it. Business sense.
IT
> sense.
> > >> Common sense.
> > >> http://p.sf.net/sfu/splunk-d2dcopy1
> > >> _______________________________________________
> > >> Rails-devel mailing list
> > >> Rai...@li...
> > >> https://lists.sourceforge.net/lists/listinfo/rails-devel
> > >>
> > >>
> > >
> > > --------------------------------------------------------------------
> > > --
> > > -------- All the data continuously generated in your IT
> > > infrastructure contains a definitive record of customers,
> > > application performance, security threats, fraudulent activity and
> > > more. Splunk takes this data and makes sense of it. Business sense. IT
> sense. Common sense.
> > > http://p.sf.net/sfu/splunk-d2dcopy1
> > > _______________________________________________
> > > Rails-devel mailing list
> > > Rai...@li...
> > > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
> >
> >
>
----------------------------------------------------------------------------
> --
> > All the data continuously generated in your IT infrastructure contains
> > a definitive record of customers, application performance, security
> > threats, fraudulent activity and more. Splunk takes this data and
> > makes sense of
> it.
> > Business sense. IT sense. Common sense.
> > http://p.sf.net/sfu/splunk-d2dcopy1
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 
>
----------------------------------------------------------------------------
--
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security threats,
> fraudulent activity and more. Splunk takes this data and makes sense of
it.
> Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2dcopy1
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel