Re: [Rails-devel] 1830 Reading Variant Correction (6e25c4)

[Bill R. <ro...@gm...>]

Actually item (2) was already fixed in the master as well, but in a different (probably inferior way):  getName() in GameOption() checks to see if parametrisedName is null (and returns the variable 'name' instead).  This check is now redundant and can be removed if the desire is to keep the code as simple as possible. 

Bill

On 2011-08-25, at 14:06 , Stefan Frey wrote:

> Adam:
> thanks a lot for your patch.
> 
> I have applied your patch to the master and pushed to the repo.
> 
> Some remarks:
> A) Could you please create a git patch next time? ( git format-patch from the 
> command line) and add your name/e-mail (you can use the command git config for 
> this). Eclipse (even with egit) only creates standard patches.
> 
> B) It seems that you did not use the most current master, as (3) was already 
> fixed by Erik Vos.
> 
> C) This reminds me that we should add some more functionality to the allowed 
> "if..." tags for the XML. Something like if ... else... should be possible.
> Enabling "and" and/or "or" what be great too.
> 
> D) Brett already tagged 1.4.3, however did not publish. I suggest re-tagging 
> or creating a new tag.
> 
> Stefan
> 
> On Wednesday, August 24, 2011 10:23:29 am Adam Badura wrote:
>> While playing 1830+Reading with current Rails 1.4.2 we encountered a
>> problem with C&O as it was not on the map and once its OR turn came the
>> game crushed.
>> 
>> I analized and discovered three issues:
>> 
>> (1) There is a localized string missing for 1830 option.
>> 
>> (2) There was bug in game options parsing from XML. Non-parametrized names
>> did not initialized the name that they then returned resulting in options
>> being overwritten in maps as they have had all “null” name.
>> 
>> (3) 1830 XML company descriptor missed home station setting for “Reading”
>> variant only. It included “Coalfields & Reading” but “Reading” alone not.
>> And it seems this was the issue that prevented us from playing. I do have
>> some doubts however. In “Coalfields” and “Coalfields & Reading” C&O is
>> supposed to start at K13 rather then F6. Is it correct? And with “Reading”
>> alone is it still F6 (I assumed so in the attached patch).
>> 
>> 
>> In attachment a correcting patch.
>> 
>> Adam Badura
> 
> ------------------------------------------------------------------------------
> EMC VNX: the world's simplest storage, starting under $10K
> The only unified storage solution that offers unified management 
> Up to 160% more powerful than alternatives and 25% more efficient. 
> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel