Re: [Rails-devel] Patch: getName() in parser.GameOption and C&O Home in 1830-Reading

[Erik V. <eri...@xs...>]

> -----Original Message-----
> From: Bill Rosgen [mailto:ro...@gm...]
> 
> In the first case, it seems that when calling GameOption.getName() the
> returned string is "null" for any option that is not a parametrized option
(i.e.
> pretty much anything that isn't UnlimitedTopTrains).  This seems to happen
> because at least as far back as commit dd14df the getName() function
> returns the string parametrizedName, which is only non-null for
> parametrized options.   The attached patch fixes this by adding an
explicit
> check to test if parametrizedName is null, returning the regular name if
it is.
> I'm not sure if this is the best way to fix this, but it seems to work.

The intention was to have parametrizedName equal to name in the absence of
parameters, but indeed that is not the case in the Game setup phase
(probably since Brett has refactored that - but the bug in GameOption is
mine). I'll have another look at that, but for now I'll accept your fix.

Erik.