From: Erik V. <eri...@xs...> - 2011-08-15 19:08:34
|
> * Are you sure that the time of calling initStopProperties that all other > objects are already setup correctly? That should be OK: this method is called via finishConfiguration(), i.e. after all XML has been parsed (that is a hard rule). > And you should ensure that it is not > possible to change the values of the runTo and runThrough attributes of hex > and station after creation of the stop objects, otherwise there could be nasty > surprises, if someone tries this in the future. I think I have not added any setters yet, but I have already mentioned that we might need some. In cases like 1851 Birmingham, runTo is in fact phase-dependent (although you have probably already solved that with some modifier). > The alternative is to go > through the list of attributes each time the methods are called. Sounds unnecessary to me. > * I currently do not support the loop attribute. I know, but I had hoped that you would like to add it (apologies for not asking so explicitly). It's all in the spirit of giving more power to the non-programmers amongst us. Several people have already started implementing games by preparing XML, only to find that they have to involve you and me to get the details done. I'm very well aware that we cannot make everything configurable in XML, and that it would be silly to strive for it. But why not do it for simple settings that occur relatively frequently? I thought 'loop' would be such a case, and pretty easy to implement (but I cannot really judge that). We also have cases like 18EU Paris/Berlin/Vienna, where I already have added loop="no". If you have no plan to start supporting it soon, my hopeful loop settings should indeed be removed. Erik. |