From: Erik V. <eri...@xs...> - 2011-08-13 16:49:14
|
Stefan, Revised proposals and some further questions below. > -----Original Message----- > From: Stefan Frey [mailto:ste...@we...] > The only issue I have is related to the type attribute: > > Could you please add another attribute that defines if the stop has to be > counted against the major or minor train reach? Maybe call this revenueType > or scoreType? Values are {major|minor}. Or rename the type attribute to > name and call that type. Very good point. I had mixed up stopType and scoreType. For stopTypes we can now reuse the original 'city' and 'town' markers: stopType = {city|town|offmap|halt|pass|port|mine|null} Note: I have removed 'medium', as it does not affect scoring, only upgrading. (The special upgrading rules for medium cities in 1854 and 1880 can already be dealt with. Perhaps the upgrade rules could be simplified by adding a special <Hex> attribute to mark *hexes* as medium cities). scoreType = {major|minor}. Q4: Do we need a separate type for 1860 halts? And perhaps 1825 halts (see also Q7 below)? I think each stopType needs a default scoreType, as follows: stopType = {city(major)|town(major*)|offmap(major)|halt(minor?)|pass(major)|port(minor) |mine(major)} . * Q5: or minor? I chose 'major' because 1830 and many other games there is no difference between cities and towns as regards scoring, but OTOH the train properties and I believe your code can already deal with either. Some other issues: Q6: How are we going to deal with train-dependent runTo values, as we have in 1837 (mines) and 18VA (CMDs), where only G-trains may run from/to such stops? Q7: In 1825, the only difference between cities and towns is, that routes may not start or end at a town (except for some special trains). We could implement this by setting <Access stopType="town" runTo="no"/>, but I don't know if that would work, and it would be train-dependent too. Does runThrough="yes" require runTo="yes", or are these two settings entirely independent? Erik. |