Menu
▾
▴
Re: [Rails-devel] Output of failed tests (a3aed4)
|
From: Stefan F. <ste...@we...> - 2011-08-06 07:56:04
|
Erik: sure you could: However you should be aware that I plan to update the test code to the JUnit 4 series soon, as I prefer to write unit tests in JUnit 4 instead of JUnit 3 for my new states implementation. So you should not simply copy&paste the code, but please add a new entry in the configuration files for a failed report directory and use that in the existing code. Then you can apply the new settings in test.profile of your own. Still wondering: I do not know the diff viewer you are using, but does it really only allow to compare two files with identical names in two different directories? In my case it as it easy to compare two files with different names in the same directory? Stefan On Saturday, August 06, 2011 09:36:46 am Erik Vos wrote: > > -----Original Message----- > > From: Stefan Frey [mailto:ste...@we...] > > Sent: Saturday, August 06, 2011 8:01 AM > > To: Development list for Rails: an 18xx game > > Subject: [Rails-devel] Output of failed tests (a3aed4) > > > > Erik, > > I have added the function. > > > > I took the freedom to change the details a little to my favored approach. > > > > If a test fails the failed report is created in the same directory put > > with a > > > different extension (.failed). > > If a test runs correctly again, the failed report is automatically > > deleted. > > > The reason for the change is that it is easier to fire up the diff tool > > (at least for > > > me) and it avoids creating new directories which are usually empty. > > However, it thwarts my intended usage, because I now have to move and > rename the failed files. Well, I guess I can create my own version. > > Erik. > > > Stefan > > > > On Thursday, August 04, 2011 04:19:12 pm Erik Vos wrote: > > > Stefan, > > > > > > I would prefer just a copy of the (new) report, preferably saved in a > > > separate directory somewhere in the test tree (for instance > > > test/data/newreports). Name should be identical to the 'old' report > > name. > > > > This way I can load these directories as a whole into a graphical tool > > > such as WinMerge that gives a quick overview of the (non-)identity of > > > all reports, and allows a side-by-side comparison of the two versions > > > of the each report. > > > > > > Erik. > > > > > > > -----Original Message----- > > > > From: Stefan Frey [mailto:ste...@we...] > > > > Sent: Thursday, August 04, 2011 7:52 AM > > > > To: Development list for Rails: an 18xx game > > > > Subject: Re: [Rails-devel] Automated testing (7e4acf) > > > > > > > > Erik: > > > > fixed the failing tests. The issue was that I did not clear NDC.key > > > > after > > > > > > each > > > > > > > test so it still contained a reference due to the previous > > > > game(manager) > > > > > > and > > > > > > > thus confused the mechanism of the initial queue of the report > > > > buffer. > > > > > > > > I do not save the test reports currently, but that was on my > > > > wishlist > > > > > > anyhow. > > > > > > > Do you prefer simply a copy of the test report or a diff-output to > > > > the expected report which would be easy to create using a java diff > > > > library? > > > > > > Stefan > > > > > > > > On Wednesday, August 03, 2011 02:59:35 pm Erik Vos wrote: > > > > > See below. > > > > > > > > > > > -----Original Message----- > > > > > > From: Stefan Frey [mailto:ste...@we...] > > > > > > > > > > > > Regarding the failed tests from your phase changes they show > > > > > > that > > > > > > A) Phase names in 1856 changed > > > > > > > > > > Ah yes, I should have reported that. With my latest commit I have > > > > > also renamed all (distinct) phases after the last bought train, > > > > > where that wasn't the case, deferring the "real" (but not always > > > > > usable) phase names to the new "realName" attribute that I have > > > > > added recently (and is now shown in square brackets in the UI). I > > > > > think I now did 1856 and 1870, > > > > > 1835 had been done before (and 1880 by Martin). Not done 1825. > > > > > > > > > > > B) All messages "train obsolete" were removed from 1830_A (C&R > > > > > > > > variant). > > > > > > > > > > C) All messages "train rusted" were removed from both games 1889 > > > > > > and 18AL_A. > > > > > > > > > > > > D) 18EU_A surprisingly kept the train rusted messages, but lost > > > > > > the > > > > > > > > > > message > > > > > > > > > > > "TrainsAvailable,P". > > > > > > > > > > > > It seems that A) was an intended change, for B) to D) I am not > > > > > > so > > > > > > sure. > > > > > > > > > Maybe you should check this. > > > > > > > > > > Nothing was intentional, I had just forgotten to put these report > > > > > lines into the new code. > > > > > The message "All X-trains are sold out, Y-trains now available" > > > > > wasn't even localised, and had to be split into two lines, because > > > > > the second half is now displayed on a separate line in *all* cases > > > > > where a new type becomes available. So I have added a new > > > > "TrainsSoldOut" entry. > > > > > > > To check any differences, I would like to be able to compare the > > > > > old and new TE_ST reports line by line in a tool like WinMerge. > > > > > Are the new reports saved anywhere? If not, wouldn't that be a > > > > > useful addition, or have you already made that possible in another > > > > way? > > > > > > > Erik > > > > > > > > > > > > > > > ------------------------------------------------------------------ > > > > > ---- > > > > > ----- > > > > > --- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA > > > > > The must-attend event for mobile developers. Connect with experts. > > > > > Get tools for creating Super Apps. See the latest technologies. > > > > > Sessions, hands-on labs, demos & much more. Register early & save! > > > > > http://p.sf.net/sfu/rim-blackberry-1 > > > > > _______________________________________________ > > > > > Rails-devel mailing list > > > > > Rai...@li... > > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > ---------------------------------------------------------------------- > > > ----- > > > - -- > > > > > > > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The > > > > must- attend event for mobile developers. Connect with experts. > > > > Get tools for creating Super Apps. See the latest technologies. > > > > Sessions, hands-on labs, demos & much more. Register early & save! > > > > http://p.sf.net/sfu/rim-blackberry-1 > > > > _______________________________________________ > > > > Rails-devel mailing list > > > > Rai...@li... > > > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > > > > > ---------------------------------------------------------------------- > > > ----- > > > --- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The > > > must-attend event for mobile developers. Connect with experts. > > > Get tools for creating Super Apps. See the latest technologies. > > > Sessions, hands-on labs, demos & much more. Register early & save! > > > http://p.sf.net/sfu/rim-blackberry-1 > > > _______________________________________________ > > > Rails-devel mailing list > > > Rai...@li... > > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > --------------------------------------------------------------------------- > - -- > > > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must- > > attend event for mobile developers. Connect with experts. > > Get tools for creating Super Apps. See the latest technologies. > > Sessions, hands-on labs, demos & much more. Register early & save! > > http://p.sf.net/sfu/rim-blackberry-1 > > _______________________________________________ > > Rails-devel mailing list > > Rai...@li... > > https://lists.sourceforge.net/lists/listinfo/rails-devel > > --------------------------------------------------------------------------- > --- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA > The must-attend event for mobile developers. Connect with experts. > Get tools for creating Super Apps. See the latest technologies. > Sessions, hands-on labs, demos & much more. Register early & save! > http://p.sf.net/sfu/rim-blackberry-1 > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel |
